Change in ...coreboot[master]: soc/intel/cannonlake: set SaGv_Enabled to 3 for CFL

[Shelley Chen (Code Review)]

Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31096

Change subject: soc/intel/cannonlake: set SaGv_Enabled to 3 for CFL
......................................................................

soc/intel/cannonlake: set SaGv_Enabled to 3 for CFL

CFL/WHL excepts SaGv_Enabled to be set to 3, but a
https://review.coreboot.org/c/coreboot/+/30917 changed the value to 4.

BUG=b:123184474
BRANCH=None
TEST=Make sure hatch can boot up to kernel

Change-Id: I3c059c259239196e2fe0a2ecad6b7babad6de2ff
Signed-off-by: Shelley Chen 
---
M src/soc/intel/cannonlake/chip.h
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/31096/1

diff --git a/src/soc/intel/cannonlake/chip.h b/src/soc/intel/cannonlake/chip.h
index a877ec1..086636a 100644
--- a/src/soc/intel/cannonlake/chip.h
+++ b/src/soc/intel/cannonlake/chip.h
@@ -109,7 +109,8 @@
    enum {
    	SaGv_Disabled,
    	SaGv_FixedLow,
-#if IS_ENABLED(CONFIG_SOC_INTEL_CANNONLAKE)
+#if IS_ENABLED(CONFIG_SOC_INTEL_CANNONLAKE) && \
+	!IS_ENABLED(CONFIG_SOC_INTEL_COFFEELAKE)
    	SaGv_FixedMid,
 #endif
    	SaGv_FixedHigh,

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31096 )

Change subject: soc/intel/cannonlake: set SaGv_Enabled to 3 for CFL
......................................................................

Patch Set 1:

(1 comment)

I didn't see this when I made CB:31095

https://review.coreboot.org/#/c/31096/1/src/soc/intel/cannonlake/chip.h 
File src/soc/intel/cannonlake/chip.h:

https://review.coreboot.org/#/c/31096/1/src/soc/intel/cannonlake/chip.h@112 
PS1, Line 112: IS_ENABLED(CONFIG_SOC_INTEL_CANNONLAKE)
Is this needed? It defaults to y for CNL/CFL/WHL

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31096 )

Change subject: soc/intel/cannonlake: set SaGv_Enabled to 3 for CFL
......................................................................

Patch Set 1:

Duplicate: https://review.coreboot.org/c/coreboot/+/31095

[Shelley Chen (Code Review)]

Shelley Chen has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31096 )

Change subject: soc/intel/cannonlake: set SaGv_Enabled to 3 for CFL
......................................................................

Abandoned