Angel Pons has uploaded this change for review. ( https://review.coreboot.org/29446
Change subject: src/mb/asus/p5qc: Fix some mistakes ......................................................................
src/mb/asus/p5qc: Fix some mistakes
There are some small mistakes in these recently-added mainboards:
- board_info.txt: Lists board socket incorrectly. - cmos.default: Loglevel was decreased some time ago. - devicetree.cb: Spelling mistake. - Kconfig: Mainboard name does not have a hyphen.
Change-Id: I08d9b06e79683acd3994b84647bce401ed6741e2 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/asus/p5qc/Kconfig M src/mainboard/asus/p5qc/board_info.txt M src/mainboard/asus/p5qc/cmos.default M src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb M src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb 5 files changed, 13 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/29446/1
diff --git a/src/mainboard/asus/p5qc/Kconfig b/src/mainboard/asus/p5qc/Kconfig index 2bcee16..e8d596f 100644 --- a/src/mainboard/asus/p5qc/Kconfig +++ b/src/mainboard/asus/p5qc/Kconfig @@ -42,7 +42,7 @@ config MAINBOARD_PART_NUMBER string default "P5QC" if BOARD_ASUS_P5QC - default "P5Q-PRO" if BOARD_ASUS_P5Q_PRO + default "P5Q PRO" if BOARD_ASUS_P5Q_PRO
config DEVICETREE string diff --git a/src/mainboard/asus/p5qc/board_info.txt b/src/mainboard/asus/p5qc/board_info.txt index 111f2e4..42d4812 100644 --- a/src/mainboard/asus/p5qc/board_info.txt +++ b/src/mainboard/asus/p5qc/board_info.txt @@ -1,6 +1,6 @@ Category: desktop Board URL: https://www.asus.com/Motherboards/P5QC/ -ROM package: SOP-8 +ROM package: DIP-8 ROM protocol: SPI ROM socketed: y Flashrom support: y diff --git a/src/mainboard/asus/p5qc/cmos.default b/src/mainboard/asus/p5qc/cmos.default index ccdb7c8..ad822d5 100644 --- a/src/mainboard/asus/p5qc/cmos.default +++ b/src/mainboard/asus/p5qc/cmos.default @@ -1,5 +1,5 @@ boot_option=Fallback -debug_level=Spew +debug_level=Debug power_on_after_fail=Disable nmi=Enable sata_mode=AHCI diff --git a/src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb b/src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb index f7088fc..8753d4c 100644 --- a/src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb +++ b/src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb @@ -85,15 +85,15 @@ irq 0x72 = 12 end device pnp 2e.106 off end # SPI1 - device pnp 2e.107 off end # GIPO6 - device pnp 2e.207 off end # GIPO7 - device pnp 2e.307 on # GIPO8 + device pnp 2e.107 off end # GPIO6 + device pnp 2e.207 off end # GPIO7 + device pnp 2e.307 on # GPIO8 irq 0xe4 = 0xfb irq 0xe5 = 0x82 end - device pnp 2e.407 off end # GIPO9 + device pnp 2e.407 off end # GPIO9 device pnp 2e.8 off end # WDT - device pnp 2e.108 off end # GPIO 1 + device pnp 2e.108 off end # GPIO1 device pnp 2e.9 off end # GPIO2 device pnp 2e.109 on end # GPIO3 device pnp 2e.209 on # GPIO4 diff --git a/src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb b/src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb index 52bbb40..6fac063 100644 --- a/src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb +++ b/src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb @@ -82,15 +82,15 @@ irq 0x72 = 12 end device pnp 2e.106 off end # SPI1 - device pnp 2e.107 off end # GIPO6 - device pnp 2e.207 off end # GIPO7 - device pnp 2e.307 on # GIPO8 + device pnp 2e.107 off end # GPIO6 + device pnp 2e.207 off end # GPIO7 + device pnp 2e.307 on # GPIO8 irq 0xe4 = 0xfb irq 0xe5 = 0x02 end - device pnp 2e.407 off end # GIPO9 + device pnp 2e.407 off end # GPIO9 device pnp 2e.8 off end # WDT - device pnp 2e.108 off end # GPIO 1 + device pnp 2e.108 off end # GPIO1 device pnp 2e.9 off end # GPIO2 device pnp 2e.109 on end # GPIO3 device pnp 2e.209 on # GPIO4
-
Angel Pons (Code Review)