Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74186 )
Change subject: ec/starlabs/merlin/acpi: Don't attempt to change EC values ......................................................................
ec/starlabs/merlin/acpi: Don't attempt to change EC values
The EC will constantly update the battery variables approximately every 60 seconds; they should be used unmodified, rather than trying to change them.
Signed-off-by: Sean Rhodes sean@starlabs.systems Change-Id: I3cff0ac6a322018cbca33b5f90dd62b3475da25c Reviewed-on: https://review.coreboot.org/c/coreboot/+/74186 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Lean Sheng Tan sheng.tan@9elements.com --- M src/ec/starlabs/merlin/acpi/battery.asl 1 file changed, 17 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Lean Sheng Tan: Looks good to me, approved
diff --git a/src/ec/starlabs/merlin/acpi/battery.asl b/src/ec/starlabs/merlin/acpi/battery.asl index 12aaa74..abdcc5b 100644 --- a/src/ec/starlabs/merlin/acpi/battery.asl +++ b/src/ec/starlabs/merlin/acpi/battery.asl @@ -34,9 +34,6 @@ Method (_BIF, 0, Serialized) { BPKG[1] = B1DC - If (B1FC >= B1DC) { - B1FC = B1DC - } BPKG[2] = B1FC BPKG[4] = B1DV If (B1FC)