Jakub Czapiga has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74125 )
Change subject: util/spd_tools: Add support for Phoenix platform ......................................................................
util/spd_tools: Add support for Phoenix platform
Update spd_gen and part_id_gen utilities to accommodate Phoenix platform so that SPD can be generated for the memory parts used in that platform. SPD requirements for Phoenix and Mendocino platforms are identical.
BUG=b:273383819 TEST=Run spd_gen and ensure that both Mendocino and Phoenix platforms share the platform manifest for LP5 memory parts.
Change-Id: I7a12f73065864f08db8922c1a69eb503865a25b1 Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/74125 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jon Murphy jpmurphy@google.com --- M spd/lp5/platforms_manifest.generated.txt M util/spd_tools/src/part_id_gen/part_id_gen.go M util/spd_tools/src/spd_gen/lp5.go M util/spd_tools/src/spd_gen/spd_gen.go 4 files changed, 26 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Jon Murphy: Looks good to me, approved
diff --git a/spd/lp5/platforms_manifest.generated.txt b/spd/lp5/platforms_manifest.generated.txt index b971e66..a52acdc 100644 --- a/spd/lp5/platforms_manifest.generated.txt +++ b/spd/lp5/platforms_manifest.generated.txt @@ -3,4 +3,5 @@
MTL,set-0 ADL,set-0 +PHX,set-1 MDN,set-1 diff --git a/util/spd_tools/src/part_id_gen/part_id_gen.go b/util/spd_tools/src/part_id_gen/part_id_gen.go index 7a22f6c..699905d 100644 --- a/util/spd_tools/src/part_id_gen/part_id_gen.go +++ b/util/spd_tools/src/part_id_gen/part_id_gen.go @@ -42,6 +42,7 @@ "CZN", "MDN", "MTL", + "PHX", }
var supportedMemTechs = [...]string{ diff --git a/util/spd_tools/src/spd_gen/lp5.go b/util/spd_tools/src/spd_gen/lp5.go index 3c6495c..65a7a57 100644 --- a/util/spd_tools/src/spd_gen/lp5.go +++ b/util/spd_tools/src/spd_gen/lp5.go @@ -177,7 +177,7 @@
var LP5PlatformSetMap = map[int][]int{ 0: {PlatformMTL, PlatformADL}, - 1: {PlatformMDN}, + 1: {PlatformPHX, PlatformMDN}, }
var LP5SetInfo = map[int]LP5Set{ diff --git a/util/spd_tools/src/spd_gen/spd_gen.go b/util/spd_tools/src/spd_gen/spd_gen.go index d254905..9f9c6f5 100644 --- a/util/spd_tools/src/spd_gen/spd_gen.go +++ b/util/spd_tools/src/spd_gen/spd_gen.go @@ -74,6 +74,7 @@ PlatformCZN PlatformMDN PlatformMTL + PlatformPHX PlatformMax )
@@ -94,6 +95,7 @@ PlatformCZN: "CZN", PlatformMDN: "MDN", PlatformMTL: "MTL", + PlatformPHX: "PHX", }
var memTechMap = map[string]memTech{