Attention is currently required from: Raul Rangel, Aaron Durbin, Furquan Shaikh, Marshall Dawson, Julius Werner, Eric Peers.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56048 )
Change subject: lib/future: Implement Futures API
......................................................................
Patch Set 4:
(2 comments)
File src/lib/Kconfig:
https://review.coreboot.org/c/coreboot/+/56048/comment/f4fe6dbc_43383781
PS2, Line 103: bool
Add a prompt so it can be disabled for debug?
After talking with Raul, it seems like disabling the feature at this level doesn't really make sense. If individual features make use of this, they might not have the ability to fall back to an alternative method.
File src/lib/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/56048/comment/56da5d04_70ef61a0
PS2, Line 274: -y
Make dependent on the config option being enabled?
After talking with Raul, it seems like disabling the feature at this level doesn't really make sense. If individual features make use of this, they might not have the ability to fall back to an alternative method.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56048
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I350aebcd07024a00b90495bf937f8bca5193d02f
Gerrit-Change-Number: 56048
Gerrit-PatchSet: 4
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Aaron Durbin
adurbin@gmail.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Eric Peers
epeers@google.com
Gerrit-Comment-Date: Wed, 07 Jul 2021 19:06:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment