[XS] Change in coreboot[main]: console: Only add non-stub code to romstage if SEPARATE_ROMSTAGE=y - coreboot-gerrit

16 Jun 2024


      Attention is currently required from: Nicholas Chin, Paul Menzel.
Felix Singer has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83088?usp=email )
Change subject: console: Only add non-stub code to romstage if SEPARATE_ROMSTAGE=y
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83088/comment/c9b029fa_043ad178?usp... :
PS3, Line 33: TEST=qemu-i440fx builds successfully with all possible settings of
            : CONFIG_SEPARATE_ROMSTAGE and CONFIG_BOOTBLOCK_CONSOLE.
...
Add a follow-up with a build config checking this?
This shouldn't block this patch. Markung as resolved.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/83088?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I59b3f0c52a4338b1573e0a647bc16cec4943fd7f
Gerrit-Change-Number: 83088
Gerrit-PatchSet: 3
Gerrit-Owner: Nicholas Chin nic.c3.14@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nicholas Chin nic.c3.14@gmail.com
Gerrit-Comment-Date: Sun, 16 Jun 2024 13:47:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org