HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32676
Change subject: src: Remove unused include <timestamp.h> ......................................................................
src: Remove unused include <timestamp.h>
Change-Id: Id05fc39c0c0d0560e34e55f793060d29df82d026 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/cheza/mainboard.c M src/mainboard/google/mistral/bootblock.c M src/mainboard/google/mistral/mainboard.c M src/soc/intel/braswell/romstage/romstage.c 4 files changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/32676/1
diff --git a/src/mainboard/google/cheza/mainboard.c b/src/mainboard/google/cheza/mainboard.c index 42adf56..7a19d32 100644 --- a/src/mainboard/google/cheza/mainboard.c +++ b/src/mainboard/google/cheza/mainboard.c @@ -16,7 +16,6 @@ #include <device/device.h> #include <bootblock_common.h> #include <gpio.h> -#include <timestamp.h> #include <soc/usb.h>
static struct usb_board_data usb1_board_data = { diff --git a/src/mainboard/google/mistral/bootblock.c b/src/mainboard/google/mistral/bootblock.c index 6718d52..4ef8fec 100644 --- a/src/mainboard/google/mistral/bootblock.c +++ b/src/mainboard/google/mistral/bootblock.c @@ -14,7 +14,6 @@ */
#include <bootblock_common.h> -#include <timestamp.h>
void bootblock_mainboard_init(void) { diff --git a/src/mainboard/google/mistral/mainboard.c b/src/mainboard/google/mistral/mainboard.c index 1d62adb..d50758c 100644 --- a/src/mainboard/google/mistral/mainboard.c +++ b/src/mainboard/google/mistral/mainboard.c @@ -15,7 +15,6 @@
#include <device/device.h> #include <bootblock_common.h> -#include <timestamp.h> #include <vendorcode/google/chromeos/chromeos.h> #include <soc/usb.h>
diff --git a/src/soc/intel/braswell/romstage/romstage.c b/src/soc/intel/braswell/romstage/romstage.c index 342b05c..22b0df2 100644 --- a/src/soc/intel/braswell/romstage/romstage.c +++ b/src/soc/intel/braswell/romstage/romstage.c @@ -29,7 +29,6 @@ #include <elog.h> #include <mrc_cache.h> #include <string.h> -#include <timestamp.h> #include <vendorcode/google/chromeos/chromeos.h> #include <fsp/util.h> #include <soc/gpio.h>
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32676 )
Change subject: src: Remove unused include <timestamp.h> ......................................................................
Patch Set 1:
Separate the mainboard/* and soc/* related changes in separate patch/CL.
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32676
to look at the new patch set (#2).
Change subject: mainboard: Remove unused include <timestamp.h> ......................................................................
mainboard: Remove unused include <timestamp.h>
Change-Id: Id05fc39c0c0d0560e34e55f793060d29df82d026 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/cheza/mainboard.c M src/mainboard/google/mistral/bootblock.c M src/mainboard/google/mistral/mainboard.c 3 files changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/32676/2
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32676 )
Change subject: mainboard: Remove unused include <timestamp.h> ......................................................................
Patch Set 2: Code-Review+2
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32676 )
Change subject: mainboard: Remove unused include <timestamp.h> ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32676 )
Change subject: mainboard: Remove unused include <timestamp.h> ......................................................................
mainboard: Remove unused include <timestamp.h>
Change-Id: Id05fc39c0c0d0560e34e55f793060d29df82d026 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/32676 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: David Hendricks david.hendricks@gmail.com Reviewed-by: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com --- M src/mainboard/google/cheza/mainboard.c M src/mainboard/google/mistral/bootblock.c M src/mainboard/google/mistral/mainboard.c 3 files changed, 0 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved Sumeet R Pawnikar: Looks good to me, approved
diff --git a/src/mainboard/google/cheza/mainboard.c b/src/mainboard/google/cheza/mainboard.c index 42adf56..7a19d32 100644 --- a/src/mainboard/google/cheza/mainboard.c +++ b/src/mainboard/google/cheza/mainboard.c @@ -16,7 +16,6 @@ #include <device/device.h> #include <bootblock_common.h> #include <gpio.h> -#include <timestamp.h> #include <soc/usb.h>
static struct usb_board_data usb1_board_data = { diff --git a/src/mainboard/google/mistral/bootblock.c b/src/mainboard/google/mistral/bootblock.c index 6718d52..4ef8fec 100644 --- a/src/mainboard/google/mistral/bootblock.c +++ b/src/mainboard/google/mistral/bootblock.c @@ -14,7 +14,6 @@ */
#include <bootblock_common.h> -#include <timestamp.h>
void bootblock_mainboard_init(void) { diff --git a/src/mainboard/google/mistral/mainboard.c b/src/mainboard/google/mistral/mainboard.c index 1d62adb..d50758c 100644 --- a/src/mainboard/google/mistral/mainboard.c +++ b/src/mainboard/google/mistral/mainboard.c @@ -15,7 +15,6 @@
#include <device/device.h> #include <bootblock_common.h> -#include <timestamp.h> #include <vendorcode/google/chromeos/chromeos.h> #include <soc/usb.h>
-
David Hendricks (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)
-
Sumeet R Pawnikar (Code Review)