Change in coreboot[master]: superio/nuvoton/nct6779d: Add symbol to select COM port

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Paul Menzel (Code Review)

3 Oct 2020 3 Oct '20

10:14 a.m.

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45971 )

Change subject: superio/nuvoton/nct6779d: Add symbol to select COM port ......................................................................

superio/nuvoton/nct6779d: Add symbol to select COM port

Like the NCT6776 and NCT6791D, the NCT6779D has muxed COMA/GPIO8 functions. Since it requires setting different bits, add a new Kconfig symbol to do it.

TEST=Selecting the symbol gives working serial console on the Asus F2A85-M PRO. Change-Id: I024ea86634b489985112ddb7ce07886e412e4c0b Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M src/superio/nuvoton/common/early_serial.c M src/superio/nuvoton/nct6779d/Kconfig 2 files changed, 7 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/45971/1

diff --git a/src/superio/nuvoton/common/early_serial.c b/src/superio/nuvoton/common/early_serial.c index cc21f40..6809a2a 100644 --- a/src/superio/nuvoton/common/early_serial.c +++ b/src/superio/nuvoton/common/early_serial.c @@ -53,7 +53,8 @@ nuvoton_pnp_enter_conf_state(dev);

if (CONFIG(SUPERIO_NUVOTON_NCT5539D_COM_A) || - CONFIG(SUPERIO_NUVOTON_NCT6776_COM_A)) + CONFIG(SUPERIO_NUVOTON_NCT6776_COM_A) || + CONFIG(SUPERIO_NUVOTON_NCT6779D_COM_A)) /* Route COM A to GPIO8 pin group */ pnp_write_config(dev, 0x2a, 0x40);

diff --git a/src/superio/nuvoton/nct6779d/Kconfig b/src/superio/nuvoton/nct6779d/Kconfig index ce2af16..2427bdd 100644 --- a/src/superio/nuvoton/nct6779d/Kconfig +++ b/src/superio/nuvoton/nct6779d/Kconfig @@ -3,3 +3,8 @@ config SUPERIO_NUVOTON_NCT6779D bool select SUPERIO_NUVOTON_COMMON_PRE_RAM + +config SUPERIO_NUVOTON_NCT6779D_COM_A + bool + depends on SUPERIO_NUVOTON_NCT6779D + default n

Attachments:

attachment.htm (text/html — 3.7 KB)

Show replies by date

Paul Menzel (Code Review)

12 Oct 12 Oct

3:04 a.m.

Hello build bot (Jenkins), Felix Held,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45971

to look at the new patch set (#4).

Change subject: superio/nuvoton/nct6779d: Add symbol to select COM port ......................................................................

superio/nuvoton/nct6779d: Add symbol to select COM port

Like the NCT6776 and NCT6791D, the NCT6779D has muxed COMA/GPIO8 functions. Since it requires setting different bits, add a new Kconfig symbol to do it.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/45971/4

Nico Huber (Code Review)

13 Oct 13 Oct

1:43 a.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45971 )

Change subject: superio/nuvoton/nct6779d: Add symbol to select COM port ......................................................................

Patch Set 4: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/45971/4/src/superio/nuvoton/common/... File src/superio/nuvoton/common/early_serial.c:

https://review.coreboot.org/c/coreboot/+/45971/4/src/superio/nuvoton/common/... PS4, Line 57: CONFIG(SUPERIO_NUVOTON_NCT6779D_COM_A)) For the future, we could just have a single Kconfig, reflecting what it does, e.g.

config SUPERIO_NUVOTON_COM_A_2A_7

-- To view, visit https://review.coreboot.org/c/coreboot/+/45971 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I024ea86634b489985112ddb7ce07886e412e4c0b Gerrit-Change-Number: 45971 Gerrit-PatchSet: 4 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 12 Oct 2020 22:43:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Held (Code Review)

2:28 p.m.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45971 )

Change subject: superio/nuvoton/nct6779d: Add symbol to select COM port ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45971/4/src/superio/nuvoton/common/... File src/superio/nuvoton/common/early_serial.c:

https://review.coreboot.org/c/coreboot/+/45971/4/src/superio/nuvoton/common/... PS4, Line 57: CONFIG(SUPERIO_NUVOTON_NCT6779D_COM_A))

...

For the future, we could just have a single Kconfig, reflecting what it does, e.g. […]

good idea. i'm ok with doing that as a follow-up patch. from what i saw on the one different case it's the same bit that needs to be cleared and the issue was probably that not only that bit was cleared, but that the whole register was rewritten. might be worth looking into that; maybe we only need one Kconfig symbol for all Nuvoton SIO chips

-- To view, visit https://review.coreboot.org/c/coreboot/+/45971 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I024ea86634b489985112ddb7ce07886e412e4c0b Gerrit-Change-Number: 45971 Gerrit-PatchSet: 4 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 13 Oct 2020 11:28:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Angel Pons (Code Review)

8:10 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45971 )

Change subject: superio/nuvoton/nct6779d: Add symbol to select COM port ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45971/5//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45971/5//COMMIT_MSG@10 PS5, Line 10: different Really?

-- To view, visit https://review.coreboot.org/c/coreboot/+/45971 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I024ea86634b489985112ddb7ce07886e412e4c0b Gerrit-Change-Number: 45971 Gerrit-PatchSet: 5 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Tue, 13 Oct 2020 17:10:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Nico Huber (Code Review)

8:21 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45971 )

Change subject: superio/nuvoton/nct6779d: Add symbol to select COM port ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45971/5//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45971/5//COMMIT_MSG@10 PS5, Line 10: different

...

Really?

Hmmmmmmmmmmmm, hard to bikeshed language here. It's the same bit _location_ but different bit _value_ (compared to the default)? But I have to admit it's ambiguous.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45971 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I024ea86634b489985112ddb7ce07886e412e4c0b Gerrit-Change-Number: 45971 Gerrit-PatchSet: 5 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Tue, 13 Oct 2020 17:21:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Angel Pons (Code Review)

8:50 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45971 )

Change subject: superio/nuvoton/nct6779d: Add symbol to select COM port ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45971/5//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45971/5//COMMIT_MSG@10 PS5, Line 10: different

...

Hmmmmmmmmmmmm, hard to bikeshed language here. It's the same bit _location_ […]

I guess this is what happens when the commit message from CB:33640 is reused. The thing is, all Nuvoton SIOs with this option have the same polarity on the same bit of the same register to mux the COM A function.

So, instead of adding yet another Kconfig symbol, one might as well rename one and remove the other two.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45971 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I024ea86634b489985112ddb7ce07886e412e4c0b Gerrit-Change-Number: 45971 Gerrit-PatchSet: 5 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Tue, 13 Oct 2020 17:50:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Angel Pons (Code Review)

17 Oct 17 Oct

4:13 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45971 )

Change subject: superio/nuvoton/nct6779d: Add symbol to select COM port ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45971/5//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45971/5//COMMIT_MSG@10 PS5, Line 10: different

...

I guess this is what happens when the commit message from CB:33640 is reused. […]

CB:46521 and CB:46522 make this patch unnecessary.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45971 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I024ea86634b489985112ddb7ce07886e412e4c0b Gerrit-Change-Number: 45971 Gerrit-PatchSet: 5 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Sat, 17 Oct 2020 13:13:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Paul Menzel (Code Review)

4:43 p.m.

Paul Menzel has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45971 )

Change subject: superio/nuvoton/nct6779d: Add symbol to select COM port ......................................................................

Abandoned

...

CB:46521 and CB:46522 make this patch unnecessary.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45971 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I024ea86634b489985112ddb7ce07886e412e4c0b Gerrit-Change-Number: 45971 Gerrit-PatchSet: 5 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: abandon

1554

days inactive

1568

days old

coreboot-gerrit@coreboot.org

8 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
Felix Held (Code Review)
Nico Huber (Code Review)
Paul Menzel (Code Review)