Philip Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33655
Change subject: mb/google/hatch: Add GPIO to enable/disable FPMCU power ......................................................................
mb/google/hatch: Add GPIO to enable/disable FPMCU power
A FPMCU power-control pin (GPP_C11) is added to the latest hatch reference schematic.
Even though this is not implemented in hatch rev1 board, the future hatch family boards with FPMCU should all have this control pin.
On the old boards without this control pin, GPP_C11 is a floating TP, and thus this patch should be backward-compatible.
BUG=b:130307667, b:135216932 TEST=build
Signed-off-by: Philip Chen philipchen@google.com Change-Id: I6a84eeb6aab562258e749a8a5d09dadfa0e43587 --- M src/mainboard/google/hatch/variants/baseboard/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/33655/1
diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c index 0b66075..0045141 100644 --- a/src/mainboard/google/hatch/variants/baseboard/gpio.c +++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c @@ -139,8 +139,8 @@ PAD_CFG_NF(GPP_C9, NONE, DEEP, NF1), /* C10 : GPP_10 ==> GPP_C10_TP */ PAD_NC(GPP_C10, DN_20K), - /* C11 : GPP_11 ==> GPP_C11_TP */ - PAD_NC(GPP_C11, DN_20K), + /* C11 : GPP_11 ==> EN_FP_RAILS */ + PAD_CFG_GPO(GPP_B11, 1, DEEP), /* C12 : GPP_C12 ==> NC */ PAD_NC(GPP_C12, NONE), /* C13 : EC_PCH_INT_L
Philip Chen has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/33655 )
Change subject: mb/google/hatch: Add a GPIO to enable/disable FPMCU power ......................................................................
mb/google/hatch: Add a GPIO to enable/disable FPMCU power
A FPMCU power-control pin (GPP_C11) is added to the latest hatch reference schematic.
Even though this is not implemented in hatch rev1 board, the future hatch family boards with FPMCU should all have this control pin.
On the old boards without this control pin, GPP_C11 is a floating TP, and thus this patch should be backward-compatible.
BUG=b:130307667, b:135216932 TEST=build
Signed-off-by: Philip Chen philipchen@google.com Change-Id: I6a84eeb6aab562258e749a8a5d09dadfa0e43587 --- M src/mainboard/google/hatch/variants/baseboard/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/33655/2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33655 )
Change subject: mb/google/hatch: Add a GPIO to enable/disable FPMCU power ......................................................................
Patch Set 2: Code-Review+2
Hello build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33655
to look at the new patch set (#3).
Change subject: mb/google/hatch: Add a GPIO to enable/disable FPMCU power ......................................................................
mb/google/hatch: Add a GPIO to enable/disable FPMCU power
A FPMCU power-control pin (GPP_C11) is added to the latest hatch reference schematic.
Even though this is not implemented in hatch rev1 board, the future hatch family boards with FPMCU should all have this control pin.
On the old boards without this control pin, GPP_C11 is a floating TP, and thus this patch should be backward-compatible.
BUG=b:130307667, b:135216932 TEST=build
Signed-off-by: Philip Chen philipchen@google.com Change-Id: I6a84eeb6aab562258e749a8a5d09dadfa0e43587 --- M src/mainboard/google/hatch/variants/baseboard/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/33655/3
Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33655 )
Change subject: mb/google/hatch: Add a GPIO to enable/disable FPMCU power ......................................................................
Patch Set 3:
Rebased. Can we merge it?
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33655 )
Change subject: mb/google/hatch: Add a GPIO to enable/disable FPMCU power ......................................................................
Patch Set 3: Code-Review+2
Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33655 )
Change subject: mb/google/hatch: Add a GPIO to enable/disable FPMCU power ......................................................................
mb/google/hatch: Add a GPIO to enable/disable FPMCU power
A FPMCU power-control pin (GPP_C11) is added to the latest hatch reference schematic.
Even though this is not implemented in hatch rev1 board, the future hatch family boards with FPMCU should all have this control pin.
On the old boards without this control pin, GPP_C11 is a floating TP, and thus this patch should be backward-compatible.
BUG=b:130307667, b:135216932 TEST=build
Signed-off-by: Philip Chen philipchen@google.com Change-Id: I6a84eeb6aab562258e749a8a5d09dadfa0e43587 Reviewed-on: https://review.coreboot.org/c/coreboot/+/33655 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/hatch/variants/baseboard/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c index 5d0b861..9529cc7 100644 --- a/src/mainboard/google/hatch/variants/baseboard/gpio.c +++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c @@ -139,8 +139,8 @@ PAD_CFG_NF(GPP_C9, NONE, DEEP, NF1), /* C10 : GPP_10 ==> GPP_C10_TP */ PAD_NC(GPP_C10, NONE), - /* C11 : GPP_11 ==> GPP_C11_TP */ - PAD_NC(GPP_C11, NONE), + /* C11 : GPP_11 ==> EN_FP_RAILS */ + PAD_CFG_GPO(GPP_C11, 1, DEEP), /* C12 : GPP_C12 ==> NC */ PAD_NC(GPP_C12, NONE), /* C13 : EC_PCH_INT_L
-
Furquan Shaikh (Code Review) -
Philip Chen (Code Review)