Attention is currently required from: Raul Rangel, Patrick Rudolph.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63725 )
Change subject: cpu/x86/64bit: Generate static page tables from an assembly file
......................................................................
Patch Set 3:
(1 comment)
File src/cpu/x86/64bit/pt.S:
https://review.coreboot.org/c/coreboot/+/63725/comment/2ea66529_2f3b2eca
PS3, Line 27: .quad _GEN_PAGE(0x200000 * 0)
Can you use a macro to reduce the duplication?
https://sourceware.org/binutils/docs/as/Macro.html
I'll try.
Sadly 100 is the max amount of nested macros allowed. Let's see if it's possible to improve that...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63725
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia1e31b701a2584268c85d327bf139953213899e3
Gerrit-Change-Number: 63725
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Wed, 20 Apr 2022 16:42:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment