Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35300 )
Change subject: /mb/google/octopus: Add a new sku for meep ......................................................................
/mb/google/octopus: Add a new sku for meep
Add a new sku4 for meep: sku4: Stylus + no rear camera
BUG=b:140360096 TEST=emerge-octopus coreboot
Change-Id: Icde7f032c0acf7562b5d5f2c6a8b0c2de91c45b2 Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/octopus/variants/meep/include/variant/sku.h M src/mainboard/google/octopus/variants/meep/variant.c 2 files changed, 5 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/35300/1
diff --git a/src/mainboard/google/octopus/variants/meep/include/variant/sku.h b/src/mainboard/google/octopus/variants/meep/include/variant/sku.h index 41cd490..c12ba80 100644 --- a/src/mainboard/google/octopus/variants/meep/include/variant/sku.h +++ b/src/mainboard/google/octopus/variants/meep/include/variant/sku.h @@ -17,9 +17,10 @@ #define __MAINBOARD_SKU_H__
enum { - SKU_1_MEEP = 1, - SKU_2_MEEP = 2, - SKU_3_MEEP = 3, + SKU_1_MEEP = 1, /* Stylus + rear camera*/ + SKU_2_MEEP = 2, /* no Stylus + rear camera */ + SKU_3_MEEP = 3, /* no Stylus + no rear camera */ + SKU_4_MEEP = 4, /* Stylus + no rear camera */ SKU_33_DORP = 33, /* HDMI */ SKU_34_DORP = 34, /* HDMI+Kblight */ SKU_35_DORP = 35, /* HDMI+TS */ diff --git a/src/mainboard/google/octopus/variants/meep/variant.c b/src/mainboard/google/octopus/variants/meep/variant.c index 5b924d2..ed76a29 100644 --- a/src/mainboard/google/octopus/variants/meep/variant.c +++ b/src/mainboard/google/octopus/variants/meep/variant.c @@ -28,6 +28,7 @@ case SKU_1_MEEP: case SKU_2_MEEP: case SKU_3_MEEP: + case SKU_4_MEEP: filename = "wifi_sar-meep.hex"; break; case SKU_49_VORTININJA:
Chen Wisley has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/35300 )
Change subject: mb/google/octopus: Add a new sku for meep ......................................................................
mb/google/octopus: Add a new sku for meep
Add a new sku4 for meep: sku4: Stylus + no rear camera
BUG=b:140360096 TEST=emerge-octopus coreboot
Change-Id: Icde7f032c0acf7562b5d5f2c6a8b0c2de91c45b2 Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/octopus/variants/meep/include/variant/sku.h M src/mainboard/google/octopus/variants/meep/variant.c 2 files changed, 5 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/35300/2
Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35300 )
Change subject: mb/google/octopus: Add a new sku for meep ......................................................................
Patch Set 2:
Hi Justin/Marco,
Could you have a review?
Thanks
Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35300 )
Change subject: mb/google/octopus: Add a new sku for meep ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35300 )
Change subject: mb/google/octopus: Add a new sku for meep ......................................................................
mb/google/octopus: Add a new sku for meep
Add a new sku4 for meep: sku4: Stylus + no rear camera
BUG=b:140360096 TEST=emerge-octopus coreboot
Change-Id: Icde7f032c0acf7562b5d5f2c6a8b0c2de91c45b2 Signed-off-by: Wisley Chen wisley.chen@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35300 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Justin TerAvest teravest@chromium.org --- M src/mainboard/google/octopus/variants/meep/include/variant/sku.h M src/mainboard/google/octopus/variants/meep/variant.c 2 files changed, 5 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Justin TerAvest: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/variants/meep/include/variant/sku.h b/src/mainboard/google/octopus/variants/meep/include/variant/sku.h index 41cd490..c12ba80 100644 --- a/src/mainboard/google/octopus/variants/meep/include/variant/sku.h +++ b/src/mainboard/google/octopus/variants/meep/include/variant/sku.h @@ -17,9 +17,10 @@ #define __MAINBOARD_SKU_H__
enum { - SKU_1_MEEP = 1, - SKU_2_MEEP = 2, - SKU_3_MEEP = 3, + SKU_1_MEEP = 1, /* Stylus + rear camera*/ + SKU_2_MEEP = 2, /* no Stylus + rear camera */ + SKU_3_MEEP = 3, /* no Stylus + no rear camera */ + SKU_4_MEEP = 4, /* Stylus + no rear camera */ SKU_33_DORP = 33, /* HDMI */ SKU_34_DORP = 34, /* HDMI+Kblight */ SKU_35_DORP = 35, /* HDMI+TS */ diff --git a/src/mainboard/google/octopus/variants/meep/variant.c b/src/mainboard/google/octopus/variants/meep/variant.c index 5b924d2..ed76a29 100644 --- a/src/mainboard/google/octopus/variants/meep/variant.c +++ b/src/mainboard/google/octopus/variants/meep/variant.c @@ -28,6 +28,7 @@ case SKU_1_MEEP: case SKU_2_MEEP: case SKU_3_MEEP: + case SKU_4_MEEP: filename = "wifi_sar-meep.hex"; break; case SKU_49_VORTININJA:
-
Chen Wisley (Code Review) -
Justin TerAvest (Code Review)
-
Patrick Georgi (Code Review)
-
Wisley Chen (Code Review)