Change in ...coreboot[master]: google/kukui: turn off backlight before config display

[jitao shi (Code Review)]

jitao shi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33571

Change subject: google/kukui: turn off backlight before config display
......................................................................

google/kukui: turn off backlight before config display

Turn off backlight before display config and then turn on backlight
after display config. Avoid flash white screen when configuring
display.

BUG=b:129299873
BRANCH=none

Change-Id: Icc16c4297eb3c6b6a4770a36661a2e3cab418048
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/panel_kukui.c
1 file changed, 3 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/33571/1

diff --git a/src/mainboard/google/kukui/panel_kukui.c b/src/mainboard/google/kukui/panel_kukui.c
index be76aa4..887634f 100644
--- a/src/mainboard/google/kukui/panel_kukui.c
+++ b/src/mainboard/google/kukui/panel_kukui.c
@@ -145,10 +145,11 @@
    return false;
 };

+/* Setup backlight control pins as output pin and power-off by default */
 static int kukui_backlight(struct board_display_intf *intf)
 {
-	gpio_output(GPIO(PERIPHERAL_EN13), 1);
-	gpio_output(GPIO(DISP_PWM), 1);	/* DISP_PWM0 */
+	gpio_output(GPIO(PERIPHERAL_EN13), 0);
+	gpio_output(GPIO(DISP_PWM), 0);

return 0;
 };

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: google/kukui: turn off backlight before config display
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/33571/1/src/mainboard/google/kukui/panel_kuk... 
File src/mainboard/google/kukui/panel_kukui.c:

https://review.coreboot.org/#/c/33571/1/src/mainboard/google/kukui/panel_kuk... 
PS1, Line 148: Setup
The verb is spelled with a space: Set up.

[jitao shi (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33571

to look at the new patch set (#2).

Change subject: google/kukui: turn off backlight before config display
......................................................................

google/kukui: turn off backlight before config display

Turn off backlight before display config and then turn on backlight
after display config. Avoid flash white screen when configuring
display.

BUG=b:129299873
BRANCH=none

Change-Id: Icc16c4297eb3c6b6a4770a36661a2e3cab418048
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/panel_kukui.c
1 file changed, 3 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/33571/2

[jitao shi (Code Review)]

jitao shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: google/kukui: turn off backlight before config display
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/33571/1/src/mainboard/google/kukui/panel_kuk... 
File src/mainboard/google/kukui/panel_kukui.c:

https://review.coreboot.org/#/c/33571/1/src/mainboard/google/kukui/panel_kuk... 
PS1, Line 148: Setup
> The verb is spelled with a space: Set up.

Done

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: google/kukui: turn off backlight before config display
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/33571/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/33571/2//COMMIT_MSG@7 
PS2, Line 7: google/kukui: turn off backlight before config display
… before display configuration

https://review.coreboot.org/#/c/33571/2//COMMIT_MSG@10 
PS2, Line 10: Avoid flash white screen when configuring
            : display.
When does this happen? During payload or OS time? coreboot should be so fast, that the display won’t have a chance to flash when coreboot executes.

Change in coreboot[master]: google/kukui: turn off backlight before config display

[jitao shi (Code Review)]

jitao shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: google/kukui: turn off backlight before config display
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/33571/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/33571/2//COMMIT_MSG@7 
PS2, Line 7: google/kukui: turn off backlight before config display
> … before display configuration

I will fix it next patchset

https://review.coreboot.org/c/coreboot/+/33571/2//COMMIT_MSG@10 
PS2, Line 10: Avoid flash white screen when configuring
            : display.
> When does this happen? During payload or OS time? coreboot should be so fast, that the display won’t […]

If the backlight on before panel power on, there will be some noise or write on screen.

So we put the backlight enable after the display configuration ready.

For example AUO  panel. Auo panel will flash write screen.

Change in coreboot[master]: google/kukui: turn off backlight before display configuration

[jitao shi (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33571

to look at the new patch set (#3).

Change subject: google/kukui: turn off backlight before display configuration
......................................................................

google/kukui: turn off backlight before display configuration

Turn off backlight before display configuration and then turn on
backlight after display config. Avoid flash white screen when
configuring display.

BUG=b:129299873
BRANCH=none

Change-Id: Icc16c4297eb3c6b6a4770a36661a2e3cab418048
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/panel_kukui.c
1 file changed, 3 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/33571/3

Change in coreboot[master]: google/kukui: turn off backlight before display configuration

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: google/kukui: turn off backlight before display configuration
......................................................................

Patch Set 3:

please just merge this to https://review.coreboot.org/c/coreboot/+/32511

Change in coreboot[master]: mb/google/kukui: Add panels for Kukui

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#4) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: mb/google/kukui: Add panels for Kukui
......................................................................

mb/google/kukui: Add panels for Kukui

Support panels in Kukui rev 1 and rev 2.
Note the panel IDs were not properly set in Kukui (was all '0') so we are
simply using fake IDs here.

BUG=b:129299873
BRANCH=none
TEST=Build as Kukui and boots on Rev 2 unit.

Change-Id: Icc16c4297eb3c6b6a4770a36661a2e3cab418048
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/mainboard.c
A src/mainboard/google/kukui/panel_kukui.c
2 files changed, 130 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/33571/4

Change in coreboot[master]: mb/google/kukui: Add panels for Kukui

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#5) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: mb/google/kukui: Add panels for Kukui
......................................................................

mb/google/kukui: Add panels for Kukui

Support panels in Kukui rev 1 and rev 2.
Note the panel IDs were not properly set in Kukui (was all '0') so we are
simply using fake IDs here.

BUG=b:129299873
BRANCH=none
TEST=Build as Kukui and boots on Rev 2 unit.

Change-Id: Icc16c4297eb3c6b6a4770a36661a2e3cab418048
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
M src/mainboard/google/kukui/mainboard.c
A src/mainboard/google/kukui/panel_kukui.c
3 files changed, 131 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/33571/5

Change in coreboot[master]: mb/google/kukui: Add panels for Kukui

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#6) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: mb/google/kukui: Add panels for Kukui
......................................................................

mb/google/kukui: Add panels for Kukui

Support panels in Kukui rev 1 and rev 2.
Note the panel IDs were not properly set in Kukui (was all '0') so we are
simply using fake IDs here.

BUG=b:129299873
BRANCH=none
TEST=Build as Kukui and boots on Rev 2 unit.

Change-Id: Icc16c4297eb3c6b6a4770a36661a2e3cab418048
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
M src/mainboard/google/kukui/mainboard.c
A src/mainboard/google/kukui/panel_kukui.c
3 files changed, 132 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/33571/6

Change in coreboot[master]: mb/google/kukui: Add panels for Kukui

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#11) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: mb/google/kukui: Add panels for Kukui
......................................................................

mb/google/kukui: Add panels for Kukui

Support panels in Kukui rev 1 and rev 2.
Note the panel IDs were not properly set in Kukui (was all '0') so we are
simply using fake IDs here.

BUG=b:129299873
BRANCH=none
TEST=Build as Kukui and boots on Rev 2 unit.

Change-Id: Icc16c4297eb3c6b6a4770a36661a2e3cab418048
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
M src/mainboard/google/kukui/mainboard.c
A src/mainboard/google/kukui/panel_kukui.c
3 files changed, 162 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/33571/11

Change in coreboot[master]: mb/google/kukui: Add panels for Kukui

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#12) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: mb/google/kukui: Add panels for Kukui
......................................................................

mb/google/kukui: Add panels for Kukui

Support panels in Kukui rev 1 and rev 2.
Note the panel IDs were not properly set in Kukui (was all '0') so we are
simply using fake IDs here.

BUG=b:129299873
BRANCH=none
TEST=Build as Kukui and boots on Rev 2 unit.

Change-Id: Icc16c4297eb3c6b6a4770a36661a2e3cab418048
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_kukui.c
2 files changed, 149 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/33571/12

Change in coreboot[master]: mb/google/kukui: Add panels for Kukui

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#17) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: mb/google/kukui: Add panels for Kukui
......................................................................

mb/google/kukui: Add panels for Kukui

Support panels in Kukui rev 1 and rev 2.
Note the panel IDs were not properly set in Kukui (was all '0') so we are
simply using fake IDs here.

BUG=b:129299873
BRANCH=none
TEST=Build as Kukui and boots on Rev 2 unit.

Change-Id: Icc16c4297eb3c6b6a4770a36661a2e3cab418048
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_kukui.c
2 files changed, 149 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/33571/17

Change in coreboot[master]: mb/google/kukui: Add panels for Kukui

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: mb/google/kukui: Add panels for Kukui
......................................................................

Patch Set 17:

same story - can't find/reply/ack comments in PS3.

Change in coreboot[master]: mb/google/kukui: Add panels for Kukui

[Yu-Ping Wu (Code Review)]

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: mb/google/kukui: Add panels for Kukui
......................................................................

Patch Set 17: Code-Review+1

Change in coreboot[master]: mb/google/kukui: Add panels for Kukui

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#18) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: mb/google/kukui: Add panels for Kukui
......................................................................

mb/google/kukui: Add panels for Kukui

Support panels in Kukui rev 1 and rev 2.
Note the panel IDs were not properly set in Kukui (was all '0') so we are
simply using fake IDs here.

BUG=b:129299873
BRANCH=none
TEST=Build as Kukui and boots on Rev 2 unit.

Change-Id: Icc16c4297eb3c6b6a4770a36661a2e3cab418048
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_kukui.c
2 files changed, 141 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/33571/18

Change in coreboot[master]: mb/google/kukui: Add panels for Kukui

[Yu-Ping Wu (Code Review)]

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: mb/google/kukui: Add panels for Kukui
......................................................................

Patch Set 21: Code-Review+1

Change in coreboot[master]: mb/google/kukui: Add panels for Kukui

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#23) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: mb/google/kukui: Add panels for Kukui
......................................................................

mb/google/kukui: Add panels for Kukui

Support panels in Kukui rev 1 and rev 2.
Note the panel IDs were not properly set in Kukui (was all '0') so we are
simply using fake IDs here.

BUG=b:129299873
BRANCH=none
TEST=Build as Kukui and boots on Rev 2 unit.

Change-Id: Icc16c4297eb3c6b6a4770a36661a2e3cab418048
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_kukui.c
2 files changed, 141 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/33571/23

Change in coreboot[master]: mb/google/kukui: Add panels for Kukui

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#24) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: mb/google/kukui: Add panels for Kukui
......................................................................

mb/google/kukui: Add panels for Kukui

Support panels in Kukui rev 1 and rev 2.
Note the panel IDs were not properly set in Kukui (was all '0') so we are
simply using fake IDs here.

BUG=b:129299873
BRANCH=none
TEST=Build as Kukui and boots on Rev 2 unit.

Change-Id: Icc16c4297eb3c6b6a4770a36661a2e3cab418048
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_kukui.c
2 files changed, 116 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/33571/24

Change in coreboot[master]: mb/google/kukui: Add panel for Kukui

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#25) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: mb/google/kukui: Add panel for Kukui
......................................................................

mb/google/kukui: Add panel for Kukui

Support Kukui rev 2 panel (via SSD2858).

BUG=b:129299873
BRANCH=none
TEST=Build as Kukui and boots on Rev 2 unit.

Change-Id: Icc16c4297eb3c6b6a4770a36661a2e3cab418048
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_kukui.c
2 files changed, 116 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/33571/25

Change in coreboot[master]: mb/google/kukui: Add panel for Kukui

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#26) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: mb/google/kukui: Add panel for Kukui
......................................................................

mb/google/kukui: Add panel for Kukui

Support Kukui rev 2 panel (via SSD2858).

BUG=b:129299873
BRANCH=none
TEST=Build as Kukui and boots on Rev 2 unit.

Change-Id: Icc16c4297eb3c6b6a4770a36661a2e3cab418048
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_kukui.c
2 files changed, 116 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/33571/26

Change in coreboot[master]: mb/google/kukui: Add panel for Kukui

[Yu-Ping Wu (Code Review)]

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: mb/google/kukui: Add panel for Kukui
......................................................................

Patch Set 27: Code-Review+1

Change in coreboot[master]: mb/google/kukui: Add panel for Kukui

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#29) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: mb/google/kukui: Add panel for Kukui
......................................................................

mb/google/kukui: Add panel for Kukui

Support Kukui rev 2 panel (via SSD2858).

BUG=b:129299873
BRANCH=none
TEST=Build as Kukui and boots on Rev 2 unit.

Change-Id: Icc16c4297eb3c6b6a4770a36661a2e3cab418048
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_kukui.c
2 files changed, 116 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/33571/29

Change in coreboot[master]: mb/google/kukui: Add panel for Kukui

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#30) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: mb/google/kukui: Add panel for Kukui
......................................................................

mb/google/kukui: Add panel for Kukui

Support Kukui rev 2 panel (via SSD2858).

BUG=b:129299873
BRANCH=none
TEST=Build as Kukui and boots on Rev 2 unit.

Change-Id: Icc16c4297eb3c6b6a4770a36661a2e3cab418048
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_kukui.c
2 files changed, 116 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/33571/30

Change in coreboot[master]: mb/google/kukui: Add panel for Kukui

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#36) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: mb/google/kukui: Add panel for Kukui
......................................................................

mb/google/kukui: Add panel for Kukui

Support Kukui rev 2 panel (via SSD2858).

BUG=b:129299873
BRANCH=none
TEST=Build as Kukui and boots on Rev 2 unit.

Change-Id: Icc16c4297eb3c6b6a4770a36661a2e3cab418048
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_kukui.c
2 files changed, 116 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/33571/36

Change in coreboot[master]: mb/google/kukui: Add panel for Kukui

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: mb/google/kukui: Add panel for Kukui
......................................................................

Patch Set 43: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/33571/43/src/mainboard/google/kukui... 
File src/mainboard/google/kukui/panel_kukui.c:

https://review.coreboot.org/c/coreboot/+/33571/43/src/mainboard/google/kukui... 
PS43, Line 111: 	/* Kukui didn't set panel ID correctly so we have to check. */
Do you mean rev1 didn't set it correctly?

Change in coreboot[master]: mb/google/kukui: Add panel for Kukui

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#44) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: mb/google/kukui: Add panel for Kukui
......................................................................

mb/google/kukui: Add panel for Kukui

Support Kukui rev 2 panel (via SSD2858).

BUG=b:129299873
BRANCH=none
TEST=Build as Kukui and boots on Rev 2 unit.

Change-Id: Icc16c4297eb3c6b6a4770a36661a2e3cab418048
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_kukui.c
2 files changed, 117 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/33571/44

Change in coreboot[master]: mb/google/kukui: Add panel for Kukui

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: mb/google/kukui: Add panel for Kukui
......................................................................

Patch Set 47: Code-Review+2

Change in coreboot[master]: mb/google/kukui: Add panel for Kukui

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: mb/google/kukui: Add panel for Kukui
......................................................................

Patch Set 48:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33571/43/src/mainboard/google/kukui... 
File src/mainboard/google/kukui/panel_kukui.c:

https://review.coreboot.org/c/coreboot/+/33571/43/src/mainboard/google/kukui... 
PS43, Line 111: 	/* Kukui didn't set panel ID correctly so we have to check. */
> Do you mean rev1 didn't set it correctly?

Originally we do support P1 panel here so the comment was for that (we have to use a fake ID). Let me rephrase this.

Change in coreboot[master]: mb/google/kukui: Add panel for Kukui

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: mb/google/kukui: Add panel for Kukui
......................................................................

Patch Set 48:

(2 comments)

https://review.coreboot.org/c/coreboot/+/33571/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/33571/2//COMMIT_MSG@7 
PS2, Line 7: google/kukui: turn off backlight before config display
> I will fix it next patchset

Ack

https://review.coreboot.org/c/coreboot/+/33571/2//COMMIT_MSG@10 
PS2, Line 10: Avoid flash white screen when configuring
            : display.
> If the backlight on before panel power on, there will be some noise or write on screen. […]

Ack

Change in coreboot[master]: mb/google/kukui: Add panel for Kukui

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#49) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: mb/google/kukui: Add panel for Kukui
......................................................................

mb/google/kukui: Add panel for Kukui

Support Kukui rev 2 panel (via SSD2858).

BUG=b:129299873
BRANCH=none
TEST=Build as Kukui and boots on Rev 2 unit.

Change-Id: Icc16c4297eb3c6b6a4770a36661a2e3cab418048
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_kukui.c
2 files changed, 117 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/33571/49

Change in coreboot[master]: mb/google/kukui: Add panel for Kukui

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#50) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: mb/google/kukui: Add panel for Kukui
......................................................................

mb/google/kukui: Add panel for Kukui

Support Kukui rev 2 panel (via SSD2858).

BUG=b:129299873
BRANCH=none
TEST=Build as Kukui and boots on Rev 2 unit.

Change-Id: Icc16c4297eb3c6b6a4770a36661a2e3cab418048
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_kukui.c
2 files changed, 117 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/33571/50

Change in coreboot[master]: mb/google/kukui: Add panel for Kukui

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: mb/google/kukui: Add panel for Kukui
......................................................................

Patch Set 51: Code-Review+2

Change in coreboot[master]: mb/google/kukui: Add panel for Kukui

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#53) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: mb/google/kukui: Add panel for Kukui
......................................................................

mb/google/kukui: Add panel for Kukui

Support Kukui rev 2 panel (via SSD2858).

BUG=b:129299873
BRANCH=none
TEST=Build as Kukui and boots on Rev 2 unit.

Change-Id: Icc16c4297eb3c6b6a4770a36661a2e3cab418048
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_kukui.c
2 files changed, 117 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/33571/53

Change in coreboot[master]: mb/google/kukui: Add panel for Kukui

[Julius Werner (Code Review)]

Julius Werner has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33571 )

Change subject: mb/google/kukui: Add panel for Kukui
......................................................................

mb/google/kukui: Add panel for Kukui

Support Kukui rev 2 panel (via SSD2858).

BUG=b:129299873
BRANCH=none
TEST=Build as Kukui and boots on Rev 2 unit.

Change-Id: Icc16c4297eb3c6b6a4770a36661a2e3cab418048
Signed-off-by: Jitao Shi 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33571
Tested-by: build bot (Jenkins) 
Reviewed-by: Julius Werner 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_kukui.c
2 files changed, 117 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Julius Werner: Looks good to me, approved

diff --git a/src/mainboard/google/kukui/Makefile.inc b/src/mainboard/google/kukui/Makefile.inc
index 554be69..727f889 100644
--- a/src/mainboard/google/kukui/Makefile.inc
+++ b/src/mainboard/google/kukui/Makefile.inc
@@ -25,4 +25,5 @@
 ramstage-y += mainboard.c
 ramstage-y += memlayout.ld
 ramstage-$(CONFIG_BOARD_GOOGLE_KRANE) += panel_krane.c
+ramstage-$(CONFIG_BOARD_GOOGLE_KUKUI) += panel_kukui.c
 ramstage-y += reset.c
diff --git a/src/mainboard/google/kukui/panel_kukui.c b/src/mainboard/google/kukui/panel_kukui.c
new file mode 100644
index 0000000..eb2f228
--- /dev/null
+++ b/src/mainboard/google/kukui/panel_kukui.c
@@ -0,0 +1,116 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2019 Huaqin Telecom Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <boardid.h>
+#include <delay.h>
+#include <gpio.h>
+
+#include "panel.h"
+
+static void power_on_ssd2858(void)
+{
+	gpio_output(GPIO_MIPIBRDG_PWRDN_L_1V8, 0);
+	gpio_output(GPIO_MIPIBRDG_RST_L_1V8, 0);
+	gpio_output(GPIO_PPVARP_LCD_EN, 1);
+	gpio_output(GPIO_PPVARN_LCD_EN, 1);
+	gpio_output(GPIO_PP1800_LCM_EN, 1);
+	gpio_output(GPIO_PP3300_LCM_EN, 1);
+	gpio_output(GPIO_PP1200_MIPIBRDG_EN, 1);
+	gpio_output(GPIO_VDDIO_MIPIBRDG_EN, 1);
+	mdelay(20);
+	gpio_output(GPIO_MIPIBRDG_PWRDN_L_1V8, 1);
+	mdelay(20);
+	gpio_output(GPIO_MIPIBRDG_RST_L_1V8, 1);
+	mdelay(20);
+}
+
+static struct panel_description P097PFG_SSD2858 = {
+	.power_on = power_on_ssd2858,
+	.edid = {
+		.ascii_string = "CMN P097PFG",
+		.panel_bits_per_color = 8,
+		.panel_bits_per_pixel = 24,
+		.mode = {
+			.name = "1536x2048@60Hz",
+			.pixel_clock = 211660,
+			.lvds_dual_channel = 0,
+			.refresh = 60,
+			.ha = 1536, .hbl = 160, .hso = 140, .hspw = 10,
+			.va = 2048, .vbl = 32, .vso = 20, .vspw = 2,
+			.phsync = '-', .pvsync = '-',
+			.x_mm = 147, .y_mm = 196,
+		},
+	},
+	.orientation = LB_FB_ORIENTATION_NORMAL,
+	.init = {
+		INIT_GENERIC_CMD(0xff, 0x00),
+		/* LOCKCNT=0x1f4, MRX=0, POSTDIV=1 (/2} }, MULT=0x49
+		 * 27 Mhz => 985.5 Mhz */
+		INIT_GENERIC_CMD(0x00, 0x08, 0x01, 0xf4, 0x01, 0x49),
+		/* MTXDIV=1, SYSDIV=3 (=> 4) */
+		INIT_GENERIC_CMD(0x00, 0x0c, 0x00, 0x00, 0x00, 0x03),
+		/* MTXVPF=24bpp, MRXLS=4 lanes, MRXVB=bypass, MRXECC=1,
+		 * MRXEOT=1, MRXEE=1 */
+		INIT_GENERIC_CMD(0x00, 0x14, 0x0c, 0x3d, 0x80, 0x0f),
+		INIT_GENERIC_CMD(0x00, 0x20, 0x15, 0x92, 0x56, 0x7d),
+		INIT_GENERIC_CMD(0x00, 0x24, 0x00, 0x00, 0x30, 0x00),
+
+		INIT_GENERIC_CMD(0x10, 0x08, 0x01, 0x20, 0x08, 0x45),
+		INIT_GENERIC_CMD(0x10, 0x1c, 0x00, 0x00, 0x00, 0x00),
+		INIT_GENERIC_CMD(0x20, 0x0c, 0x00, 0x00, 0x00, 0x04),
+		/* Pixel clock 985.5 Mhz * 0x49/0x4b = 959 Mhz */
+		INIT_GENERIC_CMD(0x20, 0x10, 0x00, 0x4b, 0x00, 0x49),
+		INIT_GENERIC_CMD(0x20, 0xa0, 0x00, 0x00, 0x00, 0x00),
+		/* EOT=1, LPE = 0, LSOUT=4 lanes, LPD=25 */
+		INIT_GENERIC_CMD(0x60, 0x08, 0x00, 0xd9, 0x00, 0x08),
+		INIT_GENERIC_CMD(0x60, 0x14, 0x01, 0x00, 0x01, 0x06),
+		/* DSI0 enable (default: probably not needed) */
+		INIT_GENERIC_CMD(0x60, 0x80, 0x00, 0x00, 0x00, 0x0f),
+		/* DSI1 enable */
+		INIT_GENERIC_CMD(0x60, 0xa0, 0x00, 0x00, 0x00, 0x0f),
+
+		/* HSA=0x18, VSA=0x02, HBP=0x50, VBP=0x0c */
+		INIT_GENERIC_CMD(0x60, 0x0c, 0x0c, 0x50, 0x02, 0x18),
+		/* VACT= 0x800 (2048} }, VFP= 0x14, HFP=0x50 */
+		INIT_GENERIC_CMD(0x60, 0x10, 0x08, 0x00, 0x14, 0x50),
+		/* HACT=0x300 (768) */
+		INIT_GENERIC_CMD(0x60, 0x84, 0x00, 0x00, 0x03, 0x00),
+		INIT_GENERIC_CMD(0x60, 0xa4, 0x00, 0x00, 0x03, 0x00),
+
+		/* Take panel out of sleep. */
+		INIT_GENERIC_CMD(0xff, 0x01),
+		INIT_DCS_CMD(0x11),
+		INIT_DELAY_CMD(120),
+		INIT_DCS_CMD(0x29),
+		INIT_DELAY_CMD(20),
+		INIT_GENERIC_CMD(0xff, 0x00),
+
+		INIT_DELAY_CMD(120),
+		INIT_DCS_CMD(0x11),
+		INIT_DELAY_CMD(120),
+		INIT_DCS_CMD(0x29),
+		INIT_DELAY_CMD(20),
+		INIT_END_CMD,
+	},
+};
+
+struct panel_description *get_panel_description(int panel_id)
+{
+	/* The Innolux panel before P2 is no longer supported. */
+	if (board_id() < 2)
+		return NULL;
+
+	return &P097PFG_SSD2858;
+}