Peichao Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add a new panel configuration for Kodama ......................................................................
mediatek/mt8183: add a new panel configuration for Kodama
BUG=b:138156559 TEST=panel should be working properly in the coreboot phase
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/display.h A src/mainboard/google/kukui/panel_kodama.c 3 files changed, 569 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/1
diff --git a/src/mainboard/google/kukui/Makefile.inc b/src/mainboard/google/kukui/Makefile.inc index a0556c1..5f01134 100644 --- a/src/mainboard/google/kukui/Makefile.inc +++ b/src/mainboard/google/kukui/Makefile.inc @@ -22,6 +22,10 @@
ramstage-y += boardid.c ramstage-y += chromeos.c +ramstage-y += display.c +ramstage-$(CONFIG_BOARD_GOOGLE_KUKUI) += panel_kukui.c +ramstage-$(CONFIG_BOARD_GOOGLE_KRANE) += panel_krane.c +ramstage-$(CONFIG_BOARD_GOOGLE_KODAMA) += panel_kodama.c ramstage-y += mainboard.c ramstage-y += memlayout.ld ramstage-y += reset.c diff --git a/src/mainboard/google/kukui/display.h b/src/mainboard/google/kukui/display.h new file mode 100644 index 0000000..8e0f10a --- /dev/null +++ b/src/mainboard/google/kukui/display.h @@ -0,0 +1,119 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2019 Bitland Tech Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef __MAINBOARD_GOOGLE_DISPLAY_H__ +#define __MAINBOARD_GOOGLE_DISPLAY_H__ + +#include <soc/dsi.h> +#include <soc/gpio.h> + +#define MAKE_AS_A_STRING(arg) #arg + +enum kukui_panel_id { + PANEL_KUKUI_FIRST = 0, + PANEL_KUKUI_INNOLUX = 0, + PANEL_KUKUI_P097PFG_SSD2858, + PANEL_KUKUI_UNKNOWN, + PANEL_KUKUI_COUNT, + PANEL_KUKUI_UNINITIALIZED +}; + +enum krane_panel_id { + PANEL_KRANE_FIRST = 0, + PANEL_KRANE_BOE_TV101WUM_NL6, + PANEL_KRANE_UNKNOWN, + PANEL_KRANE_COUNT, + PANEL_KRANE_UNINITIALIZED +}; + +enum flapjack_panel_id { + PANEL_FLAPJACK_FIRST = 0, + PANEL_FLAPJACK_BOE_TV101WUM_NG0, + PANEL_FLAPJACK_BOE_TV080WUM_NG0, + PANEL_FLAPJACK_INX_OTA7290D10P, + PANEL_FLAPJACK_AUO_NT51021D8P, + PANEL_FLAPJACK_UNKNOWN, + PANEL_FLAPJACK_COUNT, + PANEL_FLAPJACK_UNINITIALIZED +}; + +enum kodama_panel_id { + PANEL_KODAMA_FIRST = 0, + PANEL_KODAMA_BOE_TV101WUM_NL6, + PANEL_KODAMA_UNKNOWN, + PANEL_KODAMA_COUNT, + PANEL_KODAMA_UNINITIALIZED +}; + +union panel_id { + enum kukui_panel_id kukui_panel; + enum krane_panel_id krane_panel; + enum flapjack_panel_id flapjack_panel; + enum kodama_panel_id kodama_panel; + int value; +}; + +struct panel_info { + union panel_id disp_id; /* the ID for panel */ + const char *panel_name; /* display panel name */ + int voltage; /* voltage of LCM_ID */ + struct edid *edid; /* edid info of this panel */ + struct lcm_init_table *init_table; /* init command table */ + u32 table_size; /* init command table size */ +}; + +#define PANEL(_panel_id, _voltage, _edid, _init_table) \ + { \ + .disp_id = {_panel_id},\ + .panel_name = MAKE_AS_A_STRING(_panel_id),\ + .voltage = _voltage,\ + .edid = &_edid,\ + .init_table = _init_table,\ + .table_size = ARRAY_SIZE(_init_table)} \ + + +struct board_display_intf { + const char *board; /* board name */ + struct panel_info *all_panel_info; /* all supported panel info */ + u32 all_panel_info_size; /* num of supported panel */ + /* + * Runtime member + */ + struct panel_info *cur_panel_info; /* detected panel info */ + /* + * board related functions + */ + + union panel_id (*get_panel_id)(struct board_display_intf *intf); + bool (*is_panel_id_valid)(union panel_id id); + int (*backlight)(struct board_display_intf *intf); + int (*power)(struct board_display_intf *intf); +}; + +/* + * Exported functions + */ + +struct board_display_intf *get_current_display_intf(void); +int update_panel_info(struct board_display_intf *intf); +void display_startup(struct board_display_intf *intf); + + +/* + * Panel Interface for boards + */ +extern struct board_display_intf panel_display_intf; + +#endif diff --git a/src/mainboard/google/kukui/panel_kodama.c b/src/mainboard/google/kukui/panel_kodama.c new file mode 100644 index 0000000..b8e6338 --- /dev/null +++ b/src/mainboard/google/kukui/panel_kodama.c @@ -0,0 +1,446 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2019 Bitland Tech Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <console/console.h> +#include <delay.h> +#include <device/device.h> +#include <edid.h> +#include <gpio.h> +#include <soc/auxadc.h> +#include <soc/ddp.h> +#include <soc/dsi.h> +#include <soc/gpio.h> +#include <boardid.h> + +#include "display.h" +#include "gpio.h" + +#define KODAMA_PANEL_ADC_ID 2 +#define KODAMA_PANEL_ID_BIT_POSITION 16 + +const int tolerance = 82000; /* 82,000 uV */ + +/* Kodama BOE tv101wum-NL6 panel : PANEL_KODAMA_BOE_TV101WUM_NL6 */ +static struct edid kodama_boe_tv101wum_edid = { + .panel_bits_per_color = 8, + .panel_bits_per_pixel = 24, + .mode = { + .name = "1200x1920@60Hz", + .pixel_clock = 159425, + .lvds_dual_channel = 0, + .refresh = 60, + .ha = 1200, .hbl = 143, .hso = 110, .hspw = 1, .hborder = 0, + .va = 1920, .vbl = 26, .vso = 11, .vspw = 1, .vborder = 0, + .phsync = '-', .pvsync = '-', + .x_mm = 135, .y_mm = 216, + }, +}; + +static struct lcm_init_table boe_tv101wum_lcm_INIT_DCS_CMD[] = { + {INIT_DCS_CMD, 1, {0x10} }, + {DELAY_CMD, 0x22, {} }, + {INIT_DCS_CMD, 2, {0xB0, 0x05} }, + {INIT_DCS_CMD, 2, {0xB1, 0xE5} }, + {INIT_DCS_CMD, 2, {0xB3, 0x52} }, + {INIT_DCS_CMD, 2, {0xB0, 0x00} }, + {INIT_DCS_CMD, 2, {0xB3, 0x88} }, + {INIT_DCS_CMD, 2, {0xB0, 0x04} }, + {INIT_DCS_CMD, 2, {0xB8, 0x00} }, + {INIT_DCS_CMD, 2, {0xB0, 0x00} }, + {INIT_DCS_CMD, 2, {0xB2, 0x50} }, + {INIT_DCS_CMD, 2, {0xB6, 0x03} }, + {INIT_DCS_CMD, 2, {0xBA, 0x8B} }, + {INIT_DCS_CMD, 2, {0xBF, 0x15} }, + {INIT_DCS_CMD, 2, {0xC0, 0x0F} }, + {INIT_DCS_CMD, 2, {0xC2, 0x0C} }, + {INIT_DCS_CMD, 2, {0xC3, 0x02} }, + {INIT_DCS_CMD, 2, {0xC4, 0x0C} }, + {INIT_DCS_CMD, 2, {0xC5, 0x02} }, + {INIT_DCS_CMD, 2, {0xB0, 0x01} }, + {INIT_DCS_CMD, 2, {0xE0, 0x26} }, + {INIT_DCS_CMD, 2, {0xE1, 0x26} }, + {INIT_DCS_CMD, 2, {0xDC, 0x00} }, + {INIT_DCS_CMD, 2, {0xDD, 0x00} }, + {INIT_DCS_CMD, 2, {0xCC, 0x26} }, + {INIT_DCS_CMD, 2, {0xCD, 0x26} }, + {INIT_DCS_CMD, 2, {0xC8, 0x00} }, + {INIT_DCS_CMD, 2, {0xC9, 0x00} }, + {INIT_DCS_CMD, 2, {0xD2, 0x04} }, + {INIT_DCS_CMD, 2, {0xD3, 0x04} }, + {INIT_DCS_CMD, 2, {0xE6, 0x03} }, + {INIT_DCS_CMD, 2, {0xE7, 0x03} }, + {INIT_DCS_CMD, 2, {0xC4, 0x08} }, + {INIT_DCS_CMD, 2, {0xC5, 0x08} }, + {INIT_DCS_CMD, 2, {0xD8, 0x07} }, + {INIT_DCS_CMD, 2, {0xD9, 0x07} }, + {INIT_DCS_CMD, 2, {0xC2, 0x06} }, + {INIT_DCS_CMD, 2, {0xC3, 0x06} }, + {INIT_DCS_CMD, 2, {0xD6, 0x05} }, + {INIT_DCS_CMD, 2, {0xD7, 0x05} }, + {INIT_DCS_CMD, 2, {0xC0, 0x0C} }, + {INIT_DCS_CMD, 2, {0xC1, 0x0C} }, + {INIT_DCS_CMD, 2, {0xD4, 0x0B} }, + {INIT_DCS_CMD, 2, {0xD5, 0x0B} }, + {INIT_DCS_CMD, 2, {0xCA, 0x0A} }, + {INIT_DCS_CMD, 2, {0xCB, 0x0A} }, + {INIT_DCS_CMD, 2, {0xDE, 0x09} }, + {INIT_DCS_CMD, 2, {0xDF, 0x09} }, + {INIT_DCS_CMD, 2, {0xC6, 0x26} }, + {INIT_DCS_CMD, 2, {0xC7, 0x26} }, + {INIT_DCS_CMD, 2, {0xCE, 0x00} }, + {INIT_DCS_CMD, 2, {0xCF, 0x00} }, + {INIT_DCS_CMD, 2, {0xDA, 0x26} }, + {INIT_DCS_CMD, 2, {0xDB, 0x26} }, + {INIT_DCS_CMD, 2, {0xE2, 0x00} }, + {INIT_DCS_CMD, 2, {0xE3, 0x00} }, + {INIT_DCS_CMD, 2, {0xB0, 0x02} }, + {INIT_DCS_CMD, 2, {0xC0, 0x00} }, + {INIT_DCS_CMD, 2, {0xC1, 0x07} }, + {INIT_DCS_CMD, 2, {0xC2, 0x0D} }, + {INIT_DCS_CMD, 2, {0xC3, 0x18} }, + {INIT_DCS_CMD, 2, {0xC4, 0x27} }, + {INIT_DCS_CMD, 2, {0xC5, 0x28} }, + {INIT_DCS_CMD, 2, {0xC6, 0x30} }, + {INIT_DCS_CMD, 2, {0xC7, 0x2E} }, + {INIT_DCS_CMD, 2, {0xC8, 0x2F} }, + {INIT_DCS_CMD, 2, {0xC9, 0x1A} }, + {INIT_DCS_CMD, 2, {0xCA, 0x20} }, + {INIT_DCS_CMD, 2, {0xCB, 0x29} }, + {INIT_DCS_CMD, 2, {0xCC, 0x26} }, + {INIT_DCS_CMD, 2, {0xCD, 0x32} }, + {INIT_DCS_CMD, 2, {0xCE, 0x33} }, + {INIT_DCS_CMD, 2, {0xCF, 0x31} }, + {INIT_DCS_CMD, 2, {0xD0, 0x06} }, + {INIT_DCS_CMD, 2, {0xD2, 0x00} }, + {INIT_DCS_CMD, 2, {0xD3, 0x07} }, + {INIT_DCS_CMD, 2, {0xD4, 0x12} }, + {INIT_DCS_CMD, 2, {0xD5, 0x26} }, + {INIT_DCS_CMD, 2, {0xD6, 0x3D} }, + {INIT_DCS_CMD, 2, {0xD7, 0x3F} }, + {INIT_DCS_CMD, 2, {0xD8, 0x3F} }, + {INIT_DCS_CMD, 2, {0xD9, 0x3F} }, + {INIT_DCS_CMD, 2, {0xDA, 0x3F} }, + {INIT_DCS_CMD, 2, {0xDB, 0x3F} }, + {INIT_DCS_CMD, 2, {0xDC, 0x3F} }, + {INIT_DCS_CMD, 2, {0xDD, 0x3F} }, + {INIT_DCS_CMD, 2, {0xDE, 0x3F} }, + {INIT_DCS_CMD, 2, {0xDF, 0x3A} }, + {INIT_DCS_CMD, 2, {0xE0, 0x37} }, + {INIT_DCS_CMD, 2, {0xE1, 0x35} }, + {INIT_DCS_CMD, 2, {0xE2, 0x07} }, + {INIT_DCS_CMD, 2, {0xB0, 0x03} }, + {INIT_DCS_CMD, 2, {0xC8, 0x0B} }, + {INIT_DCS_CMD, 2, {0xC9, 0x07} }, + {INIT_DCS_CMD, 2, {0xC3, 0x00} }, + {INIT_DCS_CMD, 2, {0xE7, 0x00} }, + {INIT_DCS_CMD, 2, {0xC5, 0x2A} }, + {INIT_DCS_CMD, 2, {0xDE, 0x2A} }, + {INIT_DCS_CMD, 2, {0xCA, 0x43} }, + {INIT_DCS_CMD, 2, {0xC9, 0x07} }, + {INIT_DCS_CMD, 2, {0xE4, 0xC0} }, + {INIT_DCS_CMD, 2, {0xE5, 0x0D} }, + {INIT_DCS_CMD, 2, {0xCB, 0x00} }, + {INIT_DCS_CMD, 2, {0xB0, 0x06} }, + {INIT_DCS_CMD, 2, {0xB8, 0xA5} }, + {INIT_DCS_CMD, 2, {0xC0, 0xA5} }, + {INIT_DCS_CMD, 2, {0xC7, 0x0F} }, + {INIT_DCS_CMD, 2, {0xD5, 0x32} }, + {INIT_DCS_CMD, 2, {0xB8, 0x00} }, + {INIT_DCS_CMD, 2, {0xC0, 0x00} }, + {INIT_DCS_CMD, 2, {0xBC, 0x00} }, + {INIT_DCS_CMD, 2, {0xB0, 0x07} }, + {INIT_DCS_CMD, 2, {0xB1, 0x00} }, + {INIT_DCS_CMD, 2, {0xB2, 0x09} }, + {INIT_DCS_CMD, 2, {0xB3, 0x19} }, + {INIT_DCS_CMD, 2, {0xB4, 0x2F} }, + {INIT_DCS_CMD, 2, {0xB5, 0x44} }, + {INIT_DCS_CMD, 2, {0xB6, 0x52} }, + {INIT_DCS_CMD, 2, {0xB7, 0x6A} }, + {INIT_DCS_CMD, 2, {0xB8, 0x8A} }, + {INIT_DCS_CMD, 2, {0xB9, 0xCA} }, + {INIT_DCS_CMD, 2, {0xBA, 0x0C} }, + {INIT_DCS_CMD, 2, {0xBB, 0x87} }, + {DELAY_CMD, 0x05, {} }, + {INIT_DCS_CMD, 2, {0xBC, 0x06} }, + {INIT_DCS_CMD, 2, {0xBD, 0x0A} }, + {INIT_DCS_CMD, 2, {0xBE, 0x9B} }, + {INIT_DCS_CMD, 2, {0xBF, 0x0C} }, + {INIT_DCS_CMD, 2, {0xC0, 0x3D} }, + {INIT_DCS_CMD, 2, {0xC1, 0x71} }, + {INIT_DCS_CMD, 2, {0xC2, 0x90} }, + {INIT_DCS_CMD, 2, {0xC3, 0xA0} }, + {INIT_DCS_CMD, 2, {0xC4, 0xA8} }, + {INIT_DCS_CMD, 2, {0xC5, 0xB1} }, + {INIT_DCS_CMD, 2, {0xC6, 0xBB} }, + {INIT_DCS_CMD, 2, {0xC7, 0xC0} }, + {INIT_DCS_CMD, 2, {0xC8, 0xC4} }, + {INIT_DCS_CMD, 2, {0xC9, 0x00} }, + {INIT_DCS_CMD, 2, {0xCA, 0x00} }, + {INIT_DCS_CMD, 2, {0xCB, 0x16} }, + {INIT_DCS_CMD, 2, {0xCC, 0xAF} }, + {INIT_DCS_CMD, 2, {0xCD, 0xFF} }, + {INIT_DCS_CMD, 2, {0xCE, 0xFF} }, + {INIT_DCS_CMD, 2, {0xB0, 0x08} }, + {INIT_DCS_CMD, 2, {0xB1, 0x04} }, + {INIT_DCS_CMD, 2, {0xB2, 0x08} }, + {INIT_DCS_CMD, 2, {0xB3, 0x19} }, + {INIT_DCS_CMD, 2, {0xB4, 0x31} }, + {INIT_DCS_CMD, 2, {0xB5, 0x46} }, + {INIT_DCS_CMD, 2, {0xB6, 0x55} }, + {INIT_DCS_CMD, 2, {0xB7, 0x6E} }, + {INIT_DCS_CMD, 2, {0xB8, 0x92} }, + {INIT_DCS_CMD, 2, {0xB9, 0xD4} }, + {INIT_DCS_CMD, 2, {0xBA, 0x1B} }, + {INIT_DCS_CMD, 2, {0xBB, 0x9B} }, + {DELAY_CMD, 0x05, {} }, + {INIT_DCS_CMD, 2, {0xBC, 0x28} }, + {INIT_DCS_CMD, 2, {0xBD, 0x2D} }, + {INIT_DCS_CMD, 2, {0xBE, 0xC3} }, + {INIT_DCS_CMD, 2, {0xBF, 0x2F} }, + {INIT_DCS_CMD, 2, {0xC0, 0x62} }, + {INIT_DCS_CMD, 2, {0xC1, 0x99} }, + {INIT_DCS_CMD, 2, {0xC2, 0xAB} }, + {INIT_DCS_CMD, 2, {0xC3, 0xBF} }, + {INIT_DCS_CMD, 2, {0xC4, 0xCF} }, + {INIT_DCS_CMD, 2, {0xC5, 0xDF} }, + {INIT_DCS_CMD, 2, {0xC6, 0xF0} }, + {INIT_DCS_CMD, 2, {0xC7, 0xF9} }, + {INIT_DCS_CMD, 2, {0xC8, 0xFC} }, + {INIT_DCS_CMD, 2, {0xC9, 0x00} }, + {INIT_DCS_CMD, 2, {0xCA, 0x00} }, + {INIT_DCS_CMD, 2, {0xCB, 0x16} }, + {INIT_DCS_CMD, 2, {0xCC, 0xAF} }, + {INIT_DCS_CMD, 2, {0xCD, 0xFF} }, + {INIT_DCS_CMD, 2, {0xCE, 0xFF} }, + {INIT_DCS_CMD, 2, {0xB0, 0x09} }, + {INIT_DCS_CMD, 2, {0xB1, 0x04} }, + {INIT_DCS_CMD, 2, {0xB2, 0x05} }, + {INIT_DCS_CMD, 2, {0xB3, 0x17} }, + {INIT_DCS_CMD, 2, {0xB4, 0x2E} }, + {INIT_DCS_CMD, 2, {0xB5, 0x42} }, + {INIT_DCS_CMD, 2, {0xB6, 0x51} }, + {INIT_DCS_CMD, 2, {0xB7, 0x69} }, + {INIT_DCS_CMD, 2, {0xB8, 0x88} }, + {INIT_DCS_CMD, 2, {0xB9, 0xC9} }, + {INIT_DCS_CMD, 2, {0xBA, 0x0C} }, + {INIT_DCS_CMD, 2, {0xBB, 0x86} }, + {DELAY_CMD, 0x05, {} }, + {INIT_DCS_CMD, 2, {0xBC, 0x03} }, + {INIT_DCS_CMD, 2, {0xBD, 0x08} }, + {INIT_DCS_CMD, 2, {0xBE, 0x95} }, + {INIT_DCS_CMD, 2, {0xBF, 0x05} }, + {INIT_DCS_CMD, 2, {0xC0, 0x35} }, + {INIT_DCS_CMD, 2, {0xC1, 0x62} }, + {INIT_DCS_CMD, 2, {0xC2, 0x81} }, + {INIT_DCS_CMD, 2, {0xC3, 0x96} }, + {INIT_DCS_CMD, 2, {0xC4, 0x9E} }, + {INIT_DCS_CMD, 2, {0xC5, 0xA5} }, + {INIT_DCS_CMD, 2, {0xC6, 0xAD} }, + {INIT_DCS_CMD, 2, {0xC7, 0xB1} }, + {INIT_DCS_CMD, 2, {0xC8, 0xB4} }, + {INIT_DCS_CMD, 2, {0xC9, 0x00} }, + {INIT_DCS_CMD, 2, {0xCA, 0x00} }, + {INIT_DCS_CMD, 2, {0xCB, 0x16} }, + {INIT_DCS_CMD, 2, {0xCC, 0xAF} }, + {INIT_DCS_CMD, 2, {0xCD, 0xFF} }, + {INIT_DCS_CMD, 2, {0xCE, 0xFF} }, + {INIT_DCS_CMD, 2, {0xB0, 0x0A} }, + {INIT_DCS_CMD, 2, {0xB1, 0x00} }, + {INIT_DCS_CMD, 2, {0xB2, 0x09} }, + {INIT_DCS_CMD, 2, {0xB3, 0x19} }, + {INIT_DCS_CMD, 2, {0xB4, 0x2F} }, + {INIT_DCS_CMD, 2, {0xB5, 0x44} }, + {INIT_DCS_CMD, 2, {0xB6, 0x52} }, + {INIT_DCS_CMD, 2, {0xB7, 0x6A} }, + {INIT_DCS_CMD, 2, {0xB8, 0x8A} }, + {INIT_DCS_CMD, 2, {0xB9, 0xCA} }, + {INIT_DCS_CMD, 2, {0xBA, 0x0C} }, + {INIT_DCS_CMD, 2, {0xBB, 0x87} }, + {DELAY_CMD, 0x05, {} }, + {INIT_DCS_CMD, 2, {0xBC, 0x06} }, + {INIT_DCS_CMD, 2, {0xBD, 0x0A} }, + {INIT_DCS_CMD, 2, {0xBE, 0x9B} }, + {INIT_DCS_CMD, 2, {0xBF, 0x0C} }, + {INIT_DCS_CMD, 2, {0xC0, 0x3D} }, + {INIT_DCS_CMD, 2, {0xC1, 0x71} }, + {INIT_DCS_CMD, 2, {0xC2, 0x90} }, + {INIT_DCS_CMD, 2, {0xC3, 0xA0} }, + {INIT_DCS_CMD, 2, {0xC4, 0xA8} }, + {INIT_DCS_CMD, 2, {0xC5, 0xB1} }, + {INIT_DCS_CMD, 2, {0xC6, 0xBB} }, + {INIT_DCS_CMD, 2, {0xC7, 0xC0} }, + {INIT_DCS_CMD, 2, {0xC8, 0xC4} }, + {INIT_DCS_CMD, 2, {0xC9, 0x00} }, + {INIT_DCS_CMD, 2, {0xCA, 0x00} }, + {INIT_DCS_CMD, 2, {0xCB, 0x16} }, + {INIT_DCS_CMD, 2, {0xCC, 0xAF} }, + {INIT_DCS_CMD, 2, {0xCD, 0xFF} }, + {INIT_DCS_CMD, 2, {0xCE, 0xFF} }, + {INIT_DCS_CMD, 2, {0xB0, 0x0B} }, + {INIT_DCS_CMD, 2, {0xB1, 0x04} }, + {INIT_DCS_CMD, 2, {0xB2, 0x08} }, + {INIT_DCS_CMD, 2, {0xB3, 0x19} }, + {INIT_DCS_CMD, 2, {0xB4, 0x31} }, + {INIT_DCS_CMD, 2, {0xB5, 0x46} }, + {INIT_DCS_CMD, 2, {0xB6, 0x55} }, + {INIT_DCS_CMD, 2, {0xB7, 0x6E} }, + {INIT_DCS_CMD, 2, {0xB8, 0x92} }, + {INIT_DCS_CMD, 2, {0xB9, 0xD4} }, + {INIT_DCS_CMD, 2, {0xBA, 0x1B} }, + {INIT_DCS_CMD, 2, {0xBB, 0x9B} }, + {DELAY_CMD, 0x05, {} }, + {INIT_DCS_CMD, 2, {0xBC, 0x28} }, + {INIT_DCS_CMD, 2, {0xBD, 0x2D} }, + {INIT_DCS_CMD, 2, {0xBE, 0xC3} }, + {INIT_DCS_CMD, 2, {0xBF, 0x2F} }, + {INIT_DCS_CMD, 2, {0xC0, 0x62} }, + {INIT_DCS_CMD, 2, {0xC1, 0x99} }, + {INIT_DCS_CMD, 2, {0xC2, 0xAB} }, + {INIT_DCS_CMD, 2, {0xC3, 0xBF} }, + {INIT_DCS_CMD, 2, {0xC4, 0xCF} }, + {INIT_DCS_CMD, 2, {0xC5, 0xDF} }, + {INIT_DCS_CMD, 2, {0xC6, 0xF0} }, + {INIT_DCS_CMD, 2, {0xC7, 0xF9} }, + {INIT_DCS_CMD, 2, {0xC8, 0xFC} }, + {INIT_DCS_CMD, 2, {0xC9, 0x00} }, + {INIT_DCS_CMD, 2, {0xCA, 0x00} }, + {INIT_DCS_CMD, 2, {0xCB, 0x16} }, + {INIT_DCS_CMD, 2, {0xCC, 0xAF} }, + {INIT_DCS_CMD, 2, {0xCD, 0xFF} }, + {INIT_DCS_CMD, 2, {0xCE, 0xFF} }, + {INIT_DCS_CMD, 2, {0xB0, 0x0C} }, + {INIT_DCS_CMD, 2, {0xB1, 0x04} }, + {INIT_DCS_CMD, 2, {0xB2, 0x05} }, + {INIT_DCS_CMD, 2, {0xB3, 0x17} }, + {INIT_DCS_CMD, 2, {0xB4, 0x2E} }, + {INIT_DCS_CMD, 2, {0xB5, 0x42} }, + {INIT_DCS_CMD, 2, {0xB6, 0x51} }, + {INIT_DCS_CMD, 2, {0xB7, 0x69} }, + {INIT_DCS_CMD, 2, {0xB8, 0x88} }, + {INIT_DCS_CMD, 2, {0xB9, 0xC9} }, + {INIT_DCS_CMD, 2, {0xBA, 0x0C} }, + {INIT_DCS_CMD, 2, {0xBB, 0x86} }, + {DELAY_CMD, 0x05, {} }, + {INIT_DCS_CMD, 2, {0xBC, 0x03} }, + {INIT_DCS_CMD, 2, {0xBD, 0x08} }, + {INIT_DCS_CMD, 2, {0xBE, 0x95} }, + {INIT_DCS_CMD, 2, {0xBF, 0x05} }, + {INIT_DCS_CMD, 2, {0xC0, 0x35} }, + {INIT_DCS_CMD, 2, {0xC1, 0x62} }, + {INIT_DCS_CMD, 2, {0xC2, 0x81} }, + {INIT_DCS_CMD, 2, {0xC3, 0x96} }, + {INIT_DCS_CMD, 2, {0xC4, 0x9E} }, + {INIT_DCS_CMD, 2, {0xC5, 0xA5} }, + {INIT_DCS_CMD, 2, {0xC6, 0xAD} }, + {INIT_DCS_CMD, 2, {0xC7, 0xB1} }, + {INIT_DCS_CMD, 2, {0xC8, 0xB4} }, + {INIT_DCS_CMD, 2, {0xC9, 0x00} }, + {INIT_DCS_CMD, 2, {0xCA, 0x00} }, + {INIT_DCS_CMD, 2, {0xCB, 0x16} }, + {INIT_DCS_CMD, 2, {0xCC, 0xAF} }, + {INIT_DCS_CMD, 2, {0xCD, 0xFF} }, + {INIT_DCS_CMD, 2, {0xCE, 0xFF} }, + {DELAY_CMD, 0x64, {} }, + {INIT_DCS_CMD, 2, {0xB0, 0x00} }, + {INIT_DCS_CMD, 2, {0xB3, 0x08} }, + {INIT_DCS_CMD, 2, {0xB0, 0x04} }, + {INIT_DCS_CMD, 2, {0xB8, 0x68} }, + {DELAY_CMD, 0x0A, {} }, + {INIT_DCS_CMD, 1, {0x11} }, + {DELAY_CMD, 0x78, {} }, + {INIT_DCS_CMD, 1, {0x29} }, + {DELAY_CMD, 0x14, {} }, +}; + +struct panel_info kodama_panel_info[] = { + PANEL(PANEL_KODAMA_BOE_TV101WUM_NL6, + 1417000, + kodama_boe_tv101wum_edid, + boe_tv101wum_lcm_INIT_DCS_CMD), + {{PANEL_KODAMA_UNKNOWN}, "PANEL_KODAMA_UNKNOWN", + 0, NULL, NULL, 0}, +}; + + +static union panel_id get_panel_id_from_adc(int channel, + struct board_display_intf *intf) +{ + uint32_t ver = board_id(); + if (ver == 0 || ver < 3) { + int id; + int value = auxadc_get_voltage(channel); + for (id = 0; id < intf->all_panel_info_size; id++) { + if (ABS(value - intf->all_panel_info[id].voltage) + < tolerance) { + return intf->all_panel_info[id].disp_id; + } + else + return intf->all_panel_info[id+1].disp_id; + } + + return (union panel_id)PANEL_KODAMA_UNKNOWN; + } else + return (union panel_id)PANEL_KODAMA_UNKNOWN; +} + + +static union panel_id kodama_get_panel_id(struct board_display_intf *intf) +{ + union panel_id id; + + id = get_panel_id_from_adc(KODAMA_PANEL_ADC_ID, + intf); + return id; +}; + +static bool kodama_is_panel_id_valid(union panel_id id) +{ + if (id.value < PANEL_KODAMA_UNKNOWN) + return true; + return false; +}; + +static int kodama_backlight(struct board_display_intf *intf) +{ + gpio_output(GPIO(PERIPHERAL_EN13), 1); + gpio_output(GPIO(DISP_PWM), 1); /* DISP_PWM0 */ + + return 0; +}; + +static int kodama_power(struct board_display_intf *intf) +{ + gpio_output(GPIO(LCM_RST), 0); + gpio_output(GPIO(MISC_BSI_CK_3), 1); + gpio_output(GPIO(PERIPHERAL_EN9), 1); + gpio_output(GPIO(SIM2_SRST), 1); + gpio_output(GPIO(LCM_RST), 0); + mdelay(20); + gpio_output(GPIO(LCM_RST), 1); + mdelay(10); + return 0; +}; + +struct board_display_intf panel_display_intf = { + .board = "kodama", + .all_panel_info = kodama_panel_info, + .all_panel_info_size = ARRAY_SIZE(kodama_panel_info), + .cur_panel_info = NULL, + .get_panel_id = &kodama_get_panel_id, + .is_panel_id_valid = &kodama_is_panel_id_valid, + .backlight = &kodama_backlight, + .power = &kodama_power, +}; +
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add a new panel configuration for Kodama ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34505/1/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_kodama.c:
https://review.coreboot.org/c/coreboot/+/34505/1/src/mainboard/google/kukui/... PS1, Line 389: else else should follow close brace '}'
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add a new panel configuration for Kodama ......................................................................
Patch Set 1: Code-Review-1
please create panel config on top of https://review.coreboot.org/c/coreboot/+/33413, and follow same style.
Hello Zhuohao Lee, Yu-Ping Wu, You-Cheng Syu, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34505
to look at the new patch set (#2).
Change subject: mediatek/mt8183: add a new panel configuration for Kodama ......................................................................
mediatek/mt8183: add a new panel configuration for Kodama
BUG=b:138156559 TEST=panel should be working properly in the coreboot phase
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/display.h A src/mainboard/google/kukui/panel_kodama.c 3 files changed, 568 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/2
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add a new panel configuration for Kodama ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34505/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_kodama.c:
https://review.coreboot.org/c/coreboot/+/34505/2/src/mainboard/google/kukui/... PS2, Line 389: else else should follow close brace '}'
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add a new panel configuration for Kodama ......................................................................
Patch Set 2:
Patch Set 1: Code-Review-1
please create panel config on top of https://review.coreboot.org/c/coreboot/+/33413, and follow same style.
copy that
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add a new panel configuration for Kodama ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34505/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/34505/2/src/mainboard/google/kukui/... PS2, Line 25: ramstage-y += display.c : ramstage-$(CONFIG_BOARD_GOOGLE_KUKUI) += panel_kukui.c : ramstage-$(CONFIG_BOARD_GOOGLE_KRANE) += panel_krane.c these should not exist in your commit.
https://review.coreboot.org/c/coreboot/+/34505/2/src/mainboard/google/kukui/... PS2, Line 28: panel_kodama can we just reuse panel_krane.c ?
https://review.coreboot.org/c/coreboot/+/34505/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/display.h:
https://review.coreboot.org/c/coreboot/+/34505/2/src/mainboard/google/kukui/... PS2, Line 2: This this file should be removed
https://review.coreboot.org/c/coreboot/+/34505/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_kodama.c:
https://review.coreboot.org/c/coreboot/+/34505/2/src/mainboard/google/kukui/... PS2, Line 35: PANEL_KODAMA_BOE_TV101WUM_NL6 Is this the same as TV101WUM N16? If yes, we should just share krane_panel.c (be aware the EDID and LCM init seq below are different).
If not, please sync with HW eng (ayo/alvis) to see if you should choose a new LCM ID that does not conflict.
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add a new panel configuration for Kodama ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34505/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_kodama.c:
https://review.coreboot.org/c/coreboot/+/34505/2/src/mainboard/google/kukui/... PS2, Line 35: PANEL_KODAMA_BOE_TV101WUM_NL6
Is this the same as TV101WUM N16? […]
It is TV101WUM-NL6. not N16. In addition, we have another panel source, vendor is AUO detail information need confirm with Lenovo, As I know it is a new model for us. Thanks
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add a new panel configuration for Kodama ......................................................................
Patch Set 2:
Dear Hung-te,
I am so confuse, below is reason: 1. I have compared cl:33413 and the code architecture has been modified. 2. I repo sync a new code base and follow build guide patch squash CL, but above modification not be applied. 3. So how to check these code modification information since this code not be merged.
Please kindly guide me.
Thanks and best regards
Hello Zhuohao Lee, Yu-Ping Wu, You-Cheng Syu, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34505
to look at the new patch set (#3).
Change subject: mediatek/mt8183: add a new panel configuration for Kodama ......................................................................
mediatek/mt8183: add a new panel configuration for Kodama
BUG=b:138156559 TEST=panel should be working properly in the coreboot phase
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 343 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/3
Hello Zhuohao Lee, Yu-Ping Wu, You-Cheng Syu, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34505
to look at the new patch set (#4).
Change subject: mediatek/mt8183: add a new panel configuration for Kodama ......................................................................
mediatek/mt8183: add a new panel configuration for Kodama
BUG=b:138156559 TEST=panel should be working properly in the coreboot phase
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 342 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/4
Hello Zhuohao Lee, Yu-Ping Wu, You-Cheng Syu, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34505
to look at the new patch set (#5).
Change subject: mediatek/mt8183: add a new panel configuration for Kodama ......................................................................
mediatek/mt8183: add a new panel configuration for Kodama
BUG=b:138156559 TEST=panel should be working properly in the coreboot phase
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 354 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/5
Hello Zhuohao Lee, Yu-Ping Wu, You-Cheng Syu, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34505
to look at the new patch set (#6).
Change subject: mediatek/mt8183: add a new panel configuration for Kodama ......................................................................
mediatek/mt8183: add a new panel configuration for Kodama
BUG=b:138156559 TEST=panel should be working properly in the coreboot phase
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 353 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/6
Hello Zhuohao Lee, Yu-Ping Wu, You-Cheng Syu, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34505
to look at the new patch set (#7).
Change subject: mediatek/mt8183: add a new panel configuration for Kodama ......................................................................
mediatek/mt8183: add a new panel configuration for Kodama
BUG=b:138156559 TEST=panel should be working properly in the coreboot phase
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 352 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/7
Hello Zhuohao Lee, Yu-Ping Wu, You-Cheng Syu, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34505
to look at the new patch set (#8).
Change subject: mediatek/mt8183: add a new panel configuration for Kodama ......................................................................
mediatek/mt8183: add a new panel configuration for Kodama
BUG=b:138156559 TEST=panel should be working properly in the coreboot phase
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 343 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/8
Hello Zhuohao Lee, Yu-Ping Wu, You-Cheng Syu, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34505
to look at the new patch set (#9).
Change subject: mediatek/mt8183: add a new panel configuration for Kodama ......................................................................
mediatek/mt8183: add a new panel configuration for Kodama
BUG=b:138156559 TEST=panel should be working properly in the coreboot phase
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 353 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/9
Hello Zhuohao Lee, Yu-Ping Wu, You-Cheng Syu, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34505
to look at the new patch set (#10).
Change subject: mediatek/mt8183: add a new panel configuration for Kodama ......................................................................
mediatek/mt8183: add a new panel configuration for Kodama
BUG=b:138156559 TEST=panel should be working properly in the coreboot phase
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 352 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/10
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add a new panel configuration for Kodama ......................................................................
Patch Set 10:
(16 comments)
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... File src/mainboard/google/kukui/panel_kodama.c:
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... PS10, Line 34: .name = "1200x1920@60Hz", code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... PS10, Line 34: .name = "1200x1920@60Hz", please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... PS10, Line 35: .pixel_clock = 156297, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... PS10, Line 35: .pixel_clock = 156297, please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... PS10, Line 36: .lvds_dual_channel = 0, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... PS10, Line 36: .lvds_dual_channel = 0, please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... PS10, Line 37: .refresh = 60, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... PS10, Line 37: .refresh = 60, please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... PS10, Line 38: .ha = 1200, .hbl = 164, .hso = 60, .hspw = 24, .hborder = 0, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... PS10, Line 38: .ha = 1200, .hbl = 164, .hso = 60, .hspw = 24, .hborder = 0, please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... PS10, Line 39: .va = 1920, .vbl = 26, .vso = 14, .vspw = 2, .vborder = 0, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... PS10, Line 39: .va = 1920, .vbl = 26, .vso = 14, .vspw = 2, .vborder = 0, please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... PS10, Line 40: .phsync = '-', .pvsync = '-', code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... PS10, Line 40: .phsync = '-', .pvsync = '-', please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... PS10, Line 41: .x_mm = 135, .y_mm = 216, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... PS10, Line 41: .x_mm = 135, .y_mm = 216, please, no space before tabs
Hello Zhuohao Lee, Yu-Ping Wu, You-Cheng Syu, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34505
to look at the new patch set (#11).
Change subject: mediatek/mt8183: add a new panel configuration for Kodama ......................................................................
mediatek/mt8183: add a new panel configuration for Kodama
BUG=b:138156559 TEST=panel should be working properly in the coreboot phase
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 352 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/11
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add a new panel configuration for Kodama ......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34505/9/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_kodama.c:
https://review.coreboot.org/c/coreboot/+/34505/9/src/mainboard/google/kukui/... PS9, Line 16: #include <console/console.h> : #include <console/console.h> : #include <delay.h> : #include <device/device.h> : #include <edid.h> : #include <gpio.h> : #include <soc/auxadc.h> : #include <soc/dsi.h> : #include <soc/gpio.h> : #include <boardid.h> : : #include "gpio.h" You don't need all these include. Just
#include "panel.h"
https://review.coreboot.org/c/coreboot/+/34505/9/src/mainboard/google/kukui/... PS9, Line 343: // [0] = &AUO_??? is not ready remove this if it's not ready.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add a new panel configuration for Kodama ......................................................................
Patch Set 11:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34505/11//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34505/11//COMMIT_MSG@7 PS11, Line 7: a You can remove the article. It’s not needed in the summary.
https://review.coreboot.org/c/coreboot/+/34505/11//COMMIT_MSG@8 PS11, Line 8: Please mention the panel name in the commit message description, and the datasheet name and revision you got the initialization sequence from.
https://review.coreboot.org/c/coreboot/+/34505/11//COMMIT_MSG@12 PS11, Line 12: Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Please move the Signed-off-by line below the Change-Id. (The git hooks should do it that way.)
https://review.coreboot.org/c/coreboot/+/34505/11/src/mainboard/google/kukui... File src/mainboard/google/kukui/panel_kodama.c:
https://review.coreboot.org/c/coreboot/+/34505/11/src/mainboard/google/kukui... PS11, Line 342: // [0] = &AUO_??? is not ready Should this be left in here?
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add a new panel configuration for Kodama ......................................................................
Patch Set 11:
The build fails with the error below.
``` src/mainboard/google/kukui/panel_kodama.c:28:15: error: variable 'BOE_TV101WUM_N53' has initializer but incomplete type static struct panel_description BOE_TV101WUM_N53 = { ^~~~~~~~~~~~~~~~~ src/mainboard/google/kukui/panel_kodama.c:29:3: error: 'struct panel_description' has no member named 'name' .name = "BOE TV101WUM NL6", ^~~~ src/mainboard/google/kukui/panel_kodama.c:29:10: error: excess elements in struct initializer [-Werror] .name = "BOE TV101WUM NL6", ^~~~~~~~~~~~~~~~~~ ```
Hello Zhuohao Lee, Yu-Ping Wu, You-Cheng Syu, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34505
to look at the new patch set (#12).
Change subject: mb/google/kukui: Add panels for Krane ......................................................................
mb/google/kukui: Add panels for Krane
Declare following panels for Krane: - BOE TV101WUM-NL6 - AUO KD101N80-45NA
The edid info and init command are from: https://crrev.com/c/1565758
BUG=b:129299873 BRANCH=none TEST=Builds krane image and boots properly.
Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 341 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/12
Hello Zhuohao Lee, Yu-Ping Wu, You-Cheng Syu, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34505
to look at the new patch set (#13).
Change subject: mediatek/mt8183: add panels for Kodama ......................................................................
mediatek/mt8183: add panels for Kodama
Declare following panels for Krane: - BOE TV101WUM-N53
The edid info and init command are from: https://crrev.com/c/1565758
BUG=b:138156559 TEST=builds Kodama image and working properly
Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 341 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/13
Hello Zhuohao Lee, Yu-Ping Wu, You-Cheng Syu, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34505
to look at the new patch set (#14).
Change subject: mediatek/mt8183: add panels for Kodama ......................................................................
mediatek/mt8183: add panels for Kodama
Declare following panels for Krane: - BOE TV101WUM-N53
The edid info and init command are from: https://crrev.com/c/1565758
BUG=b:138156559 TEST=builds Kodama image and working properly
Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 341 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/14
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add panels for Kodama ......................................................................
Patch Set 14:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34505/14/src/mainboard/google/kukui... File src/mainboard/google/kukui/panel_kodama.c:
https://review.coreboot.org/c/coreboot/+/34505/14/src/mainboard/google/kukui... PS14, Line 28: .hborder = 0, you can remove the 0 .hborder to prevent exceeding col 80.
https://review.coreboot.org/c/coreboot/+/34505/14/src/mainboard/google/kukui... PS14, Line 29: .vborder = 0, you can remove the 0 .vborder to prevent exceeding col 80.
https://review.coreboot.org/c/coreboot/+/34505/14/src/mainboard/google/kukui... PS14, Line 332: BOE_TV101WUM_N53 so it's N53, not N16?
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add panels for Kodama ......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34505/14//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34505/14//COMMIT_MSG@13 PS14, Line 13: https://crrev.com/c/1565758 Thank you for the URL, but it’s kind of “cheating” as that commit does not have any more information about the sequence either.
Hello Zhuohao Lee, Yu-Ping Wu, You-Cheng Syu, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34505
to look at the new patch set (#15).
Change subject: mediatek/mt8183: add panels for Kodama ......................................................................
mediatek/mt8183: add panels for Kodama
Declare following panels for Kodama: - BOE TV101WUM-N53
BUG=b:138156559 TEST=builds Kodama image and working properly
Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 341 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/15
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add panels for Kodama ......................................................................
Patch Set 15:
(1 comment)
Patch Set 14:
(3 comments)
Dear Hung-te, I have confirmed with our PM and we use BOE-TV101WUM-N53 for Kodama not NL6. In addition, I confirmed with vendor and wait for them feedback, we need know init code is different or same between NL6 and N53. Also I will go on tuning this panel when I got correct init code.
Thanks and best regards
https://review.coreboot.org/c/coreboot/+/34505/11/src/mainboard/google/kukui... File src/mainboard/google/kukui/panel_kodama.c:
https://review.coreboot.org/c/coreboot/+/34505/11/src/mainboard/google/kukui... PS11, Line 28: BOE_TV101WUM_N53 New panel source is BOE_TV101WUM_N53
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add panels for Kodama ......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34505/15/src/mainboard/google/kukui... File src/mainboard/google/kukui/panel_kodama.c:
https://review.coreboot.org/c/coreboot/+/34505/15/src/mainboard/google/kukui... PS15, Line 332: BOE_TV101WUM_N53 I have confirmed with verndor and init code is same with NL6, just edid need follow N53 spec. Detail information(spec and confirmation mail) you can check issue ticket:b/138156559 comment#4~5. Thanks a lot!
Hello Zhuohao Lee, Yu-Ping Wu, You-Cheng Syu, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34505
to look at the new patch set (#16).
Change subject: mediatek/mt8183: add panels for Kodama ......................................................................
mediatek/mt8183: add panels for Kodama
Declare following panels for Kodama: - BOE TV101WUM-N53
BUG=b:138156559 TEST=builds Kodama image and working properly
Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 341 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/16
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add panels for Kodama ......................................................................
Patch Set 16:
Hi Peichao, you have to cherry-pick the display/panel related changes locally, then apply yours on top of it, otherwise buildbot will keep failing.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add panels for Kodama ......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34505/16/src/mainboard/google/kukui... File src/mainboard/google/kukui/panel_kodama.c:
https://review.coreboot.org/c/coreboot/+/34505/16/src/mainboard/google/kukui... PS16, Line 332: [2] Do we already have some proto builds that come with [11] or [0]? If yes please add them with a comment like /* This is only for proto and may be reused later. */
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add panels for Kodama ......................................................................
Patch Set 16:
(1 comment)
Patch Set 16:
Hi Peichao, you have to cherry-pick the display/panel related changes locally, then apply yours on top of it, otherwise buildbot will keep failing.
Hi Hung-Te, I cherry pick cl beginning from https://review.coreboot.org/c/coreboot/+/32511/25 to the end cl: https://review.coreboot.org/c/coreboot/+/33571/14, and modify N53 panel right?
Thanks and best regards
https://review.coreboot.org/c/coreboot/+/34505/16/src/mainboard/google/kukui... File src/mainboard/google/kukui/panel_kodama.c:
https://review.coreboot.org/c/coreboot/+/34505/16/src/mainboard/google/kukui... PS16, Line 332: [2]
Do we already have some proto builds that come with [11] or [0]? […]
Ack
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add panels for Kodama ......................................................................
Patch Set 16:
you should start from https://review.coreboot.org/c/coreboot/+/31478 otherwise it won't compile.
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add panels for Kodama ......................................................................
Patch Set 16:
Patch Set 16:
you should start from https://review.coreboot.org/c/coreboot/+/31478 otherwise it won't compile.
I see, I am trying it. Thanks a lot!
Hello Zhuohao Lee, Yu-Ping Wu, You-Cheng Syu, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34505
to look at the new patch set (#17).
Change subject: mediatek/mt8183: add panels for Kodama ......................................................................
mediatek/mt8183: add panels for Kodama
Declare following panels for Kodama: - BOE TV101WUM-N53
BUG=b:138156559 TEST=builds Kodama image and working properly
Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 674 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/17
Hello Zhuohao Lee, Yu-Ping Wu, You-Cheng Syu, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34505
to look at the new patch set (#18).
Change subject: mediatek/mt8183: add panels for Kodama ......................................................................
mediatek/mt8183: add panels for Kodama
Declare following panels for Kodama: - BOE TV101WUM-N53
BUG=b:138156559 TEST=builds Kodama image and working properly
Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel.h A src/mainboard/google/kukui/panel_kodama.c 3 files changed, 706 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/18
Hello Zhuohao Lee, Yu-Ping Wu, You-Cheng Syu, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34505
to look at the new patch set (#19).
Change subject: mediatek/mt8183: add panels for Kodama ......................................................................
mediatek/mt8183: add panels for Kodama
Declare following panels for Kodama: - BOE TV101WUM-N53
BUG=b:138156559 TEST=builds Kodama image and working properly
Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel.h A src/mainboard/google/kukui/panel_kodama.c M src/soc/mediatek/mt8183/Makefile.inc A src/soc/mediatek/mt8183/ddp.c A src/soc/mediatek/mt8183/dsi.c 6 files changed, 1,392 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/19
Hello Zhuohao Lee, Yu-Ping Wu, Julius Werner, You-Cheng Syu, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34505
to look at the new patch set (#20).
Change subject: mediatek/mt8183: add panels for Kodama ......................................................................
mediatek/mt8183: add panels for Kodama
Declare following panels for Kodama: - BOE TV101WUM-N53
BUG=b:138156559 TEST=builds Kodama image and working properly
Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel.h A src/mainboard/google/kukui/panel_kodama.c M src/soc/mediatek/mt8183/Makefile.inc A src/soc/mediatek/mt8183/ddp.c A src/soc/mediatek/mt8183/dsi.c M src/soc/mediatek/mt8183/include/soc/addressmap.h A src/soc/mediatek/mt8183/include/soc/ddp.h A src/soc/mediatek/mt8183/include/soc/dsi.h 9 files changed, 2,209 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/20
Hello Zhuohao Lee, Yu-Ping Wu, Julius Werner, You-Cheng Syu, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34505
to look at the new patch set (#21).
Change subject: mediatek/mt8183: add panels for Kodama ......................................................................
mediatek/mt8183: add panels for Kodama
Declare following panels for Kodama: - BOE TV101WUM-N53
BUG=b:138156559 TEST=builds Kodama image and working properly
Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel.h A src/mainboard/google/kukui/panel_kodama.c M src/soc/mediatek/mt8183/Makefile.inc A src/soc/mediatek/mt8183/ddp.c A src/soc/mediatek/mt8183/dsi.c M src/soc/mediatek/mt8183/include/soc/addressmap.h A src/soc/mediatek/mt8183/include/soc/ddp.h A src/soc/mediatek/mt8183/include/soc/dsi.h 9 files changed, 2,207 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/21
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add panels for Kodama ......................................................................
Patch Set 21:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34505/21/src/soc/mediatek/mt8183/in... File src/soc/mediatek/mt8183/include/soc/dsi.h:
https://review.coreboot.org/c/coreboot/+/34505/21/src/soc/mediatek/mt8183/in... PS21, Line 486: #endif adding a line without newline at end of file
Hello Zhuohao Lee, Yu-Ping Wu, Julius Werner, You-Cheng Syu, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34505
to look at the new patch set (#22).
Change subject: mediatek/mt8183: add panels for Kodama ......................................................................
mediatek/mt8183: add panels for Kodama
Declare following panels for Kodama: - BOE TV101WUM-N53
BUG=b:138156559 TEST=builds Kodama image and working properly
Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel.h A src/mainboard/google/kukui/panel_kodama.c M src/soc/mediatek/mt8183/Makefile.inc A src/soc/mediatek/mt8183/ddp.c A src/soc/mediatek/mt8183/dsi.c M src/soc/mediatek/mt8183/include/soc/addressmap.h A src/soc/mediatek/mt8183/include/soc/ddp.h A src/soc/mediatek/mt8183/include/soc/dsi.h 9 files changed, 2,208 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/22
Hello Zhuohao Lee, Yu-Ping Wu, Julius Werner, You-Cheng Syu, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34505
to look at the new patch set (#23).
Change subject: mediatek/mt8183: add panels for Kodama ......................................................................
mediatek/mt8183: add panels for Kodama
Declare following panels for Kodama: - BOE TV101WUM-N53
BUG=b:138156559 TEST=builds Kodama image and working properly
Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel.h A src/mainboard/google/kukui/panel_kodama.c M src/soc/mediatek/mt8183/Makefile.inc A src/soc/mediatek/mt8183/ddp.c A src/soc/mediatek/mt8183/dsi.c M src/soc/mediatek/mt8183/include/soc/addressmap.h A src/soc/mediatek/mt8183/include/soc/ddp.h A src/soc/mediatek/mt8183/include/soc/dsi.h 9 files changed, 2,207 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/23
Hung-Te Lin has uploaded a new patch set (#24) to the change originally created by Peichao Li. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add panels for Kodama ......................................................................
mediatek/mt8183: add panels for Kodama
Declare following panels for Kodama: - BOE TV101WUM-N53
BUG=b:138156559 TEST=builds Kodama image and working properly
Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 674 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/24
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add panels for Kodama ......................................................................
Patch Set 24:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34505/24/src/mainboard/google/kukui... File src/mainboard/google/kukui/panel_kodama.c:
https://review.coreboot.org/c/coreboot/+/34505/24/src/mainboard/google/kukui... PS24, Line 24: gpio_output(GPIO(LCM_RST), 0); : udelay(1500); : gpio_output(GPIO(SIM2_SRST), 1); : mdelay(5); : gpio_output(GPIO(PERIPHERAL_EN9), 1); : gpio_output(GPIO(MISC_BSI_CK_3), 1); : mdelay(100); : gpio_output(GPIO(LCM_RST), 1); : mdelay(10); Why is this power on sequence so different from krane or kukui?
Hung-Te Lin has uploaded a new patch set (#25) to the change originally created by Peichao Li. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add panels for Kodama ......................................................................
mediatek/mt8183: add panels for Kodama
Declare following panels for Kodama: - BOE TV101WUM-N53
BUG=b:138156559 TEST=builds Kodama image and working properly
Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 674 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/25
Hello Zhuohao Lee, Yu-Ping Wu, Julius Werner, You-Cheng Syu, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34505
to look at the new patch set (#26).
Change subject: mediatek/mt8183: add panels for Kodama ......................................................................
mediatek/mt8183: add panels for Kodama
Declare following panels for Kodama: - BOE TV101WUM-N53
BUG=b:138156559 TEST=builds Kodama image and working properly
Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 655 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/26
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add panels for Kodama ......................................................................
Patch Set 26: Code-Review+2
Hung-Te Lin has uploaded a new patch set (#28) to the change originally created by Peichao Li. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mb/google/kukui: Add panels for Kodama ......................................................................
mb/google/kukui: Add panels for Kodama
Declare following panels for Kodama: - BOE TV101WUM-N53 - BOE TV101WUM-NL6
BUG=b:138156559 TEST=builds Kodama image and working properly
Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 655 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/28
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mb/google/kukui: Add panels for Kodama ......................................................................
Patch Set 28:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34505/24/src/mainboard/google/kukui... File src/mainboard/google/kukui/panel_kodama.c:
https://review.coreboot.org/c/coreboot/+/34505/24/src/mainboard/google/kukui... PS24, Line 24: gpio_output(GPIO(LCM_RST), 0); : udelay(1500); : gpio_output(GPIO(SIM2_SRST), 1); : mdelay(5); : gpio_output(GPIO(PERIPHERAL_EN9), 1); : gpio_output(GPIO(MISC_BSI_CK_3), 1); : mdelay(100); : gpio_output(GPIO(LCM_RST), 1); : mdelay(10);
Why is this power on sequence so different from krane or kukui?
Ack
Hung-Te Lin has uploaded a new patch set (#29) to the change originally created by Peichao Li. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mb/google/kukui: Add panels for Kodama ......................................................................
mb/google/kukui: Add panels for Kodama
Declare following panels for Kodama: - BOE TV101WUM-N53 - BOE TV101WUM-NL6
BUG=b:138156559 TEST=builds Kodama image and working properly
Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 655 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/29
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mb/google/kukui: Add panels for Kodama ......................................................................
Patch Set 29:
(10 comments)
https://review.coreboot.org/c/coreboot/+/34505/11//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34505/11//COMMIT_MSG@7 PS11, Line 7: a
You can remove the article. It’s not needed in the summary.
Ack
https://review.coreboot.org/c/coreboot/+/34505/11//COMMIT_MSG@8 PS11, Line 8:
Please mention the panel name in the commit message description, and the datasheet name and revision […]
Ack
https://review.coreboot.org/c/coreboot/+/34505/11//COMMIT_MSG@12 PS11, Line 12: Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com
Please move the Signed-off-by line below the Change-Id. (The git hooks should do it that way. […]
Ack
https://review.coreboot.org/c/coreboot/+/34505/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/34505/2/src/mainboard/google/kukui/... PS2, Line 25: ramstage-y += display.c : ramstage-$(CONFIG_BOARD_GOOGLE_KUKUI) += panel_kukui.c : ramstage-$(CONFIG_BOARD_GOOGLE_KRANE) += panel_krane.c
these should not exist in your commit.
Ack
https://review.coreboot.org/c/coreboot/+/34505/2/src/mainboard/google/kukui/... PS2, Line 28: panel_kodama
can we just reuse panel_krane. […]
Ack
https://review.coreboot.org/c/coreboot/+/34505/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/display.h:
https://review.coreboot.org/c/coreboot/+/34505/2/src/mainboard/google/kukui/... PS2, Line 2: This
this file should be removed
Ack
https://review.coreboot.org/c/coreboot/+/34505/9/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_kodama.c:
https://review.coreboot.org/c/coreboot/+/34505/9/src/mainboard/google/kukui/... PS9, Line 16: #include <console/console.h> : #include <console/console.h> : #include <delay.h> : #include <device/device.h> : #include <edid.h> : #include <gpio.h> : #include <soc/auxadc.h> : #include <soc/dsi.h> : #include <soc/gpio.h> : #include <boardid.h> : : #include "gpio.h"
You don't need all these include. Just […]
Ack
https://review.coreboot.org/c/coreboot/+/34505/9/src/mainboard/google/kukui/... PS9, Line 343: // [0] = &AUO_??? is not ready
remove this if it's not ready.
Ack
https://review.coreboot.org/c/coreboot/+/34505/11/src/mainboard/google/kukui... File src/mainboard/google/kukui/panel_kodama.c:
https://review.coreboot.org/c/coreboot/+/34505/11/src/mainboard/google/kukui... PS11, Line 28: BOE_TV101WUM_N53
New panel source is BOE_TV101WUM_N53
Ack
https://review.coreboot.org/c/coreboot/+/34505/11/src/mainboard/google/kukui... PS11, Line 342: // [0] = &AUO_??? is not ready
Should this be left in here?
Ack
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mb/google/kukui: Add panels for Kodama ......................................................................
Patch Set 29:
(5 comments)
https://review.coreboot.org/c/coreboot/+/34505/14//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34505/14//COMMIT_MSG@13 PS14, Line 13: https://crrev.com/c/1565758
Thank you for the URL, but it’s kind of “cheating” as that commit does not have any more information […]
Ack
https://review.coreboot.org/c/coreboot/+/34505/14/src/mainboard/google/kukui... File src/mainboard/google/kukui/panel_kodama.c:
https://review.coreboot.org/c/coreboot/+/34505/14/src/mainboard/google/kukui... PS14, Line 28: .hborder = 0,
you can remove the 0 .hborder to prevent exceeding col 80.
Ack
https://review.coreboot.org/c/coreboot/+/34505/14/src/mainboard/google/kukui... PS14, Line 29: .vborder = 0,
you can remove the 0 .vborder to prevent exceeding col 80.
Ack
https://review.coreboot.org/c/coreboot/+/34505/14/src/mainboard/google/kukui... PS14, Line 332: BOE_TV101WUM_N53
so it's N53, not N16?
Ack
https://review.coreboot.org/c/coreboot/+/34505/15/src/mainboard/google/kukui... File src/mainboard/google/kukui/panel_kodama.c:
https://review.coreboot.org/c/coreboot/+/34505/15/src/mainboard/google/kukui... PS15, Line 332: BOE_TV101WUM_N53
I have confirmed with verndor and init code is same with NL6, just edid need follow N53 spec. […]
Ack
Hello Zhuohao Lee, Yu-Ping Wu, Julius Werner, You-Cheng Syu, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34505
to look at the new patch set (#30).
Change subject: mediatek/mt8183: add panels for Kodama ......................................................................
mediatek/mt8183: add panels for Kodama
Declare following panels for Kodama: - BOE TV101WUM-N53
BUG=b:138156559 TEST=builds Kodama image and working properly
Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 341 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/30
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add panels for Kodama ......................................................................
Patch Set 30:
the cmd buffer default size has been shrinked to 7 so you don't need to remove 2nd panel.
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add panels for Kodama ......................................................................
Patch Set 30:
Patch Set 30:
the cmd buffer default size has been shrinked to 7 so you don't need to remove 2nd panel.
Dear Hung-Te,
I have confirmed with our PM and EE, we will never apply NL6 in the EVT stage. So keep N53 is ok. Thanks a lot!
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add panels for Kodama ......................................................................
Patch Set 30:
so you have no plan to use it, even for 2nd source ?
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add panels for Kodama ......................................................................
Patch Set 30:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34505/30//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34505/30//COMMIT_MSG@7 PS30, Line 7: add Capitalize
https://review.coreboot.org/c/coreboot/+/34505/30//COMMIT_MSG@9 PS30, Line 9: following the following
https://review.coreboot.org/c/coreboot/+/34505/30//COMMIT_MSG@9 PS30, Line 9: panels panel
https://review.coreboot.org/c/coreboot/+/34505/30/src/mainboard/google/kukui... File src/mainboard/google/kukui/panel_kodama.c:
https://review.coreboot.org/c/coreboot/+/34505/30/src/mainboard/google/kukui... PS30, Line 36: {INIT_DCS_CMD, 2, { 0xB0, 0x05 } }, Consider using _INIT_DCS_CMD (added in https://review.coreboot.org/c/coreboot/+/32511/29).
Hello Zhuohao Lee, Yu-Ping Wu, Julius Werner, You-Cheng Syu, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34505
to look at the new patch set (#31).
Change subject: mediatek/mt8183: add panel for Kodama ......................................................................
mediatek/mt8183: add panel for Kodama
Declare the following panel for Kodama: - BOE TV101WUM-N53
BUG=b:138156559 TEST=builds Kodama image and working properly
Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 341 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/31
Hung-Te Lin has uploaded a new patch set (#32) to the change originally created by Peichao Li. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mb/google/kukui: Add panels for Kodama ......................................................................
mb/google/kukui: Add panels for Kodama
Declare the following panels for Kodama: - BOE TV101WUM-N53 - BOE TV101WUM-NL6
BUG=b:138156559 TEST=builds Kodama image and working properly
Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 655 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/32
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mb/google/kukui: Add panels for Kodama ......................................................................
Patch Set 35: Code-Review+1
Hello Zhuohao Lee, Yu-Ping Wu, Julius Werner, You-Cheng Syu, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34505
to look at the new patch set (#36).
Change subject: mediatek/mt8183: add panel for Kodama ......................................................................
mediatek/mt8183: add panel for Kodama
Declare the following panel for Kodama: - BOE TV101WUM-N53
BUG=b:138156559 TEST=builds Kodama image and working properly
Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 341 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/36
Hello Zhuohao Lee, Yu-Ping Wu, Julius Werner, You-Cheng Syu, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34505
to look at the new patch set (#38).
Change subject: mediatek/mt8183: add panel for Kodama ......................................................................
mediatek/mt8183: add panel for Kodama
Declare the following panel for Kodama: - BOE TV101WUM-N53
BUG=b:138156559 TEST=builds Kodama image and working properly
Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 341 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/38
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add panel for Kodama ......................................................................
Patch Set 44:
(1 comment)
Dear Hung-Te,
I have uprev the code and rebase it to master. Need your help why build bot verify minus 1.
Thanks
https://review.coreboot.org/c/coreboot/+/34505/30/src/mainboard/google/kukui... File src/mainboard/google/kukui/panel_kodama.c:
https://review.coreboot.org/c/coreboot/+/34505/30/src/mainboard/google/kukui... PS30, Line 36: {INIT_DCS_CMD, 2, { 0xB0, 0x05 } },
Consider using _INIT_DCS_CMD (added in https://review.coreboot.org/c/coreboot/+/32511/29).
Ack
Hello Zhuohao Lee, Yu-Ping Wu, Julius Werner, You-Cheng Syu, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34505
to look at the new patch set (#47).
Change subject: mediatek/mt8183: add panel for Kodama ......................................................................
mediatek/mt8183: add panel for Kodama
Declare the following panel for Kodama: - BOE TV101WUM-N53
BUG=b:138156559 TEST=builds Kodama image and working properly
Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 341 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/47
You-Cheng Syu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add panel for Kodama ......................................................................
Patch Set 47:
Patch Set 44:
(1 comment)
Dear Hung-Te,
I have uprev the code and rebase it to master. Need your help why build bot verify minus 1.
Thanks
check this https://qa.coreboot.org/job/coreboot-gerrit/100375/testReport/board/chromeos...
Hello Zhuohao Lee, Yu-Ping Wu, Julius Werner, You-Cheng Syu, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34505
to look at the new patch set (#48).
Change subject: mediatek/mt8183: add panel for Kodama ......................................................................
mediatek/mt8183: add panel for Kodama
Declare the following panel for Kodama: - BOE TV101WUM-N53
BUG=b:138156559 TEST=builds Kodama image and working properly
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 341 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/48
Hung-Te Lin has uploaded a new patch set (#49) to the change originally created by Peichao Li. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mb/google/kukui: Add panel for Kodama ......................................................................
mb/google/kukui: Add panel for Kodama
Declare the following panel for Kodama: - BOE TV101WUM-N53
BUG=b:138156559 TEST=builds Kodama image and working properly
Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 341 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/49
Hung-Te Lin has uploaded a new patch set (#52) to the change originally created by Peichao Li. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mb/google/kukui: Add panel for Kodama ......................................................................
mb/google/kukui: Add panel for Kodama
Declare the following panel for Kodama: - BOE TV101WUM-N53
BUG=b:138156559 TEST=builds Kodama image and working properly
Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 341 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/52
Hung-Te Lin has uploaded a new patch set (#55) to the change originally created by Peichao Li. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mb/google/kukui: Add panel for Kodama ......................................................................
mb/google/kukui: Add panel for Kodama
Declare the following panel for Kodama: - BOE TV101WUM-N53
BUG=b:138156559 TEST=builds Kodama image and working properly
Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 341 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/55
Hung-Te Lin has uploaded a new patch set (#61) to the change originally created by Peichao Li. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mb/google/kukui: Add panel for Kodama ......................................................................
mb/google/kukui: Add panel for Kodama
Declare the following panel for Kodama: - BOE TV101WUM-N53
BUG=b:138156559 TEST=builds Kodama image and working properly
Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 342 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/61
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mb/google/kukui: Add panel for Kodama ......................................................................
Patch Set 62: Code-Review+2
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mb/google/kukui: Add panel for Kodama ......................................................................
Patch Set 67:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34505/30//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34505/30//COMMIT_MSG@7 PS30, Line 7: add
Capitalize
Ack
https://review.coreboot.org/c/coreboot/+/34505/30//COMMIT_MSG@9 PS30, Line 9: panels
panel
Ack
https://review.coreboot.org/c/coreboot/+/34505/30//COMMIT_MSG@9 PS30, Line 9: following
the following
Ack
Hung-Te Lin has uploaded a new patch set (#68) to the change originally created by Peichao Li. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mb/google/kukui: Add panel for Kodama ......................................................................
mb/google/kukui: Add panel for Kodama
Declare the following panel for Kodama: - BOE TV101WUM-N53
BUG=b:138156559 TEST=builds Kodama image and working properly
Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 342 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/68
Hung-Te Lin has uploaded a new patch set (#69) to the change originally created by Peichao Li. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mb/google/kukui: Add panel for Kodama ......................................................................
mb/google/kukui: Add panel for Kodama
Declare the following panel for Kodama: - BOE TV101WUM-N53
BUG=b:138156559 TEST=builds Kodama image and working properly
Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 342 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/69
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mb/google/kukui: Add panel for Kodama ......................................................................
Patch Set 70: Code-Review+2
Hung-Te Lin has uploaded a new patch set (#72) to the change originally created by Peichao Li. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mb/google/kukui: Add panel for Kodama ......................................................................
mb/google/kukui: Add panel for Kodama
Declare the following panel for Kodama: - BOE TV101WUM-N53
BUG=b:138156559 TEST=builds Kodama image and working properly
Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 342 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34505/72
Julius Werner has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mb/google/kukui: Add panel for Kodama ......................................................................
mb/google/kukui: Add panel for Kodama
Declare the following panel for Kodama: - BOE TV101WUM-N53
BUG=b:138156559 TEST=builds Kodama image and working properly
Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34505 Reviewed-by: Julius Werner jwerner@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/panel_kodama.c 2 files changed, 342 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved
diff --git a/src/mainboard/google/kukui/Makefile.inc b/src/mainboard/google/kukui/Makefile.inc index 727f889..3f3d931 100644 --- a/src/mainboard/google/kukui/Makefile.inc +++ b/src/mainboard/google/kukui/Makefile.inc @@ -24,6 +24,7 @@ ramstage-y += chromeos.c ramstage-y += mainboard.c ramstage-y += memlayout.ld +ramstage-$(CONFIG_BOARD_GOOGLE_KODAMA) += panel_kodama.c ramstage-$(CONFIG_BOARD_GOOGLE_KRANE) += panel_krane.c ramstage-$(CONFIG_BOARD_GOOGLE_KUKUI) += panel_kukui.c ramstage-y += reset.c diff --git a/src/mainboard/google/kukui/panel_kodama.c b/src/mainboard/google/kukui/panel_kodama.c new file mode 100644 index 0000000..15e46a4 --- /dev/null +++ b/src/mainboard/google/kukui/panel_kodama.c @@ -0,0 +1,341 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2019 Bitland Tech Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include "panel.h" + +static struct panel_description BOE_TV101WUM_N53 = { + .edid = { + .ascii_string = "TV101WUM-N53", + .panel_bits_per_color = 8, + .panel_bits_per_pixel = 24, + .mode = { + .name = "1200x1920@60Hz", + .pixel_clock = 156297, + .lvds_dual_channel = 0, + .refresh = 60, + .ha = 1200, .hbl = 164, .hso = 60, .hspw = 24, + .va = 1920, .vbl = 26, .vso = 14, .vspw = 2, + .phsync = '-', .pvsync = '-', + .x_mm = 135, .y_mm = 216, + }, + }, + .orientation = LB_FB_ORIENTATION_LEFT_UP, + .init = { + INIT_DELAY_CMD(24), + INIT_DCS_CMD(0xB0, 0x05), + INIT_DCS_CMD(0xB1, 0xE5), + INIT_DCS_CMD(0xB3, 0x52), + INIT_DCS_CMD(0xB0, 0x00), + INIT_DCS_CMD(0xB3, 0x88), + INIT_DCS_CMD(0xB0, 0x04), + INIT_DCS_CMD(0xB8, 0x00), + INIT_DCS_CMD(0xB0, 0x00), + INIT_DCS_CMD(0xB6, 0x03), + INIT_DCS_CMD(0xBA, 0x8B), + INIT_DCS_CMD(0xBF, 0x1A), + INIT_DCS_CMD(0xC0, 0x0F), + INIT_DCS_CMD(0xC2, 0x0C), + INIT_DCS_CMD(0xC3, 0x02), + INIT_DCS_CMD(0xC4, 0x0C), + INIT_DCS_CMD(0xC5, 0x02), + INIT_DCS_CMD(0xB0, 0x01), + INIT_DCS_CMD(0xE0, 0x26), + INIT_DCS_CMD(0xE1, 0x26), + INIT_DCS_CMD(0xDC, 0x00), + INIT_DCS_CMD(0xDD, 0x00), + INIT_DCS_CMD(0xCC, 0x26), + INIT_DCS_CMD(0xCD, 0x26), + INIT_DCS_CMD(0xC8, 0x00), + INIT_DCS_CMD(0xC9, 0x00), + INIT_DCS_CMD(0xD2, 0x03), + INIT_DCS_CMD(0xD3, 0x03), + INIT_DCS_CMD(0xE6, 0x04), + INIT_DCS_CMD(0xE7, 0x04), + INIT_DCS_CMD(0xC4, 0x09), + INIT_DCS_CMD(0xC5, 0x09), + INIT_DCS_CMD(0xD8, 0x0A), + INIT_DCS_CMD(0xD9, 0x0A), + INIT_DCS_CMD(0xC2, 0x0B), + INIT_DCS_CMD(0xC3, 0x0B), + INIT_DCS_CMD(0xD6, 0x0C), + INIT_DCS_CMD(0xD7, 0x0C), + INIT_DCS_CMD(0xC0, 0x05), + INIT_DCS_CMD(0xC1, 0x05), + INIT_DCS_CMD(0xD4, 0x06), + INIT_DCS_CMD(0xD5, 0x06), + INIT_DCS_CMD(0xCA, 0x07), + INIT_DCS_CMD(0xCB, 0x07), + INIT_DCS_CMD(0xDE, 0x08), + INIT_DCS_CMD(0xDF, 0x08), + INIT_DCS_CMD(0xB0, 0x02), + INIT_DCS_CMD(0xC0, 0x00), + INIT_DCS_CMD(0xC1, 0x0D), + INIT_DCS_CMD(0xC2, 0x17), + INIT_DCS_CMD(0xC3, 0x26), + INIT_DCS_CMD(0xC4, 0x31), + INIT_DCS_CMD(0xC5, 0x1C), + INIT_DCS_CMD(0xC6, 0x2C), + INIT_DCS_CMD(0xC7, 0x33), + INIT_DCS_CMD(0xC8, 0x31), + INIT_DCS_CMD(0xC9, 0x37), + INIT_DCS_CMD(0xCA, 0x37), + INIT_DCS_CMD(0xCB, 0x37), + INIT_DCS_CMD(0xCC, 0x39), + INIT_DCS_CMD(0xCD, 0x2E), + INIT_DCS_CMD(0xCE, 0x2F), + INIT_DCS_CMD(0xCF, 0x2F), + INIT_DCS_CMD(0xD0, 0x07), + INIT_DCS_CMD(0xD2, 0x00), + INIT_DCS_CMD(0xD3, 0x0D), + INIT_DCS_CMD(0xD4, 0x17), + INIT_DCS_CMD(0xD5, 0x26), + INIT_DCS_CMD(0xD6, 0x31), + INIT_DCS_CMD(0xD7, 0x3F), + INIT_DCS_CMD(0xD8, 0x3F), + INIT_DCS_CMD(0xD9, 0x3F), + INIT_DCS_CMD(0xDA, 0x3F), + INIT_DCS_CMD(0xDB, 0x37), + INIT_DCS_CMD(0xDC, 0x37), + INIT_DCS_CMD(0xDD, 0x37), + INIT_DCS_CMD(0xDE, 0x39), + INIT_DCS_CMD(0xDF, 0x2E), + INIT_DCS_CMD(0xE0, 0x2F), + INIT_DCS_CMD(0xE1, 0x2F), + INIT_DCS_CMD(0xE2, 0x07), + INIT_DCS_CMD(0xB0, 0x03), + INIT_DCS_CMD(0xC8, 0x0B), + INIT_DCS_CMD(0xC9, 0x07), + INIT_DCS_CMD(0xC3, 0x00), + INIT_DCS_CMD(0xE7, 0x00), + INIT_DCS_CMD(0xC5, 0x2A), + INIT_DCS_CMD(0xDE, 0x2A), + INIT_DCS_CMD(0xCA, 0x43), + INIT_DCS_CMD(0xC9, 0x07), + INIT_DCS_CMD(0xE4, 0xC0), + INIT_DCS_CMD(0xE5, 0x0D), + INIT_DCS_CMD(0xCB, 0x00), + INIT_DCS_CMD(0xB0, 0x06), + INIT_DCS_CMD(0xB8, 0xA5), + INIT_DCS_CMD(0xC0, 0xA5), + INIT_DCS_CMD(0xC7, 0x0F), + INIT_DCS_CMD(0xD5, 0x32), + INIT_DCS_CMD(0xB8, 0x00), + INIT_DCS_CMD(0xC0, 0x00), + INIT_DCS_CMD(0xBC, 0x00), + INIT_DCS_CMD(0xB0, 0x07), + INIT_DCS_CMD(0xB1, 0x00), + INIT_DCS_CMD(0xB2, 0x02), + INIT_DCS_CMD(0xB3, 0x0F), + INIT_DCS_CMD(0xB4, 0x25), + INIT_DCS_CMD(0xB5, 0x39), + INIT_DCS_CMD(0xB6, 0x4E), + INIT_DCS_CMD(0xB7, 0x72), + INIT_DCS_CMD(0xB8, 0x97), + INIT_DCS_CMD(0xB9, 0xDC), + INIT_DCS_CMD(0xBA, 0x22), + INIT_DCS_CMD(0xBB, 0xA4), + INIT_DCS_CMD(0xBC, 0x2B), + INIT_DCS_CMD(0xBD, 0x2F), + INIT_DCS_CMD(0xBE, 0xA9), + INIT_DCS_CMD(0xBF, 0x25), + INIT_DCS_CMD(0xC0, 0x61), + INIT_DCS_CMD(0xC1, 0x97), + INIT_DCS_CMD(0xC2, 0xB2), + INIT_DCS_CMD(0xC3, 0xCD), + INIT_DCS_CMD(0xC4, 0xD9), + INIT_DCS_CMD(0xC5, 0xE7), + INIT_DCS_CMD(0xC6, 0xF4), + INIT_DCS_CMD(0xC7, 0xFA), + INIT_DCS_CMD(0xC8, 0xFC), + INIT_DCS_CMD(0xC9, 0x00), + INIT_DCS_CMD(0xCA, 0x00), + INIT_DCS_CMD(0xCB, 0x16), + INIT_DCS_CMD(0xCC, 0xAF), + INIT_DCS_CMD(0xCD, 0xFF), + INIT_DCS_CMD(0xCE, 0xFF), + INIT_DCS_CMD(0xB0, 0x08), + INIT_DCS_CMD(0xB1, 0x04), + INIT_DCS_CMD(0xB2, 0x05), + INIT_DCS_CMD(0xB3, 0x11), + INIT_DCS_CMD(0xB4, 0x24), + INIT_DCS_CMD(0xB5, 0x39), + INIT_DCS_CMD(0xB6, 0x4F), + INIT_DCS_CMD(0xB7, 0x72), + INIT_DCS_CMD(0xB8, 0x98), + INIT_DCS_CMD(0xB9, 0xDC), + INIT_DCS_CMD(0xBA, 0x23), + INIT_DCS_CMD(0xBB, 0xA6), + INIT_DCS_CMD(0xBC, 0x2C), + INIT_DCS_CMD(0xBD, 0x30), + INIT_DCS_CMD(0xBE, 0xAA), + INIT_DCS_CMD(0xBF, 0x26), + INIT_DCS_CMD(0xC0, 0x62), + INIT_DCS_CMD(0xC1, 0x9B), + INIT_DCS_CMD(0xC2, 0xB5), + INIT_DCS_CMD(0xC3, 0xCF), + INIT_DCS_CMD(0xC4, 0xDB), + INIT_DCS_CMD(0xC5, 0xE8), + INIT_DCS_CMD(0xC6, 0xF5), + INIT_DCS_CMD(0xC7, 0xFA), + INIT_DCS_CMD(0xC8, 0xFC), + INIT_DCS_CMD(0xC9, 0x00), + INIT_DCS_CMD(0xCA, 0x00), + INIT_DCS_CMD(0xCB, 0x16), + INIT_DCS_CMD(0xCC, 0xAF), + INIT_DCS_CMD(0xCD, 0xFF), + INIT_DCS_CMD(0xCE, 0xFF), + INIT_DCS_CMD(0xB0, 0x09), + INIT_DCS_CMD(0xB1, 0x04), + INIT_DCS_CMD(0xB2, 0x02), + INIT_DCS_CMD(0xB3, 0x16), + INIT_DCS_CMD(0xB4, 0x24), + INIT_DCS_CMD(0xB5, 0x3B), + INIT_DCS_CMD(0xB6, 0x4F), + INIT_DCS_CMD(0xB7, 0x73), + INIT_DCS_CMD(0xB8, 0x99), + INIT_DCS_CMD(0xB9, 0xE0), + INIT_DCS_CMD(0xBA, 0x26), + INIT_DCS_CMD(0xBB, 0xAD), + INIT_DCS_CMD(0xBC, 0x36), + INIT_DCS_CMD(0xBD, 0x3A), + INIT_DCS_CMD(0xBE, 0xAE), + INIT_DCS_CMD(0xBF, 0x2A), + INIT_DCS_CMD(0xC0, 0x66), + INIT_DCS_CMD(0xC1, 0x9E), + INIT_DCS_CMD(0xC2, 0xB8), + INIT_DCS_CMD(0xC3, 0xD1), + INIT_DCS_CMD(0xC4, 0xDD), + INIT_DCS_CMD(0xC5, 0xE9), + INIT_DCS_CMD(0xC6, 0xF6), + INIT_DCS_CMD(0xC7, 0xFA), + INIT_DCS_CMD(0xC8, 0xFC), + INIT_DCS_CMD(0xC9, 0x00), + INIT_DCS_CMD(0xCA, 0x00), + INIT_DCS_CMD(0xCB, 0x16), + INIT_DCS_CMD(0xCC, 0xAF), + INIT_DCS_CMD(0xCD, 0xFF), + INIT_DCS_CMD(0xCE, 0xFF), + INIT_DCS_CMD(0xB0, 0x0A), + INIT_DCS_CMD(0xB1, 0x00), + INIT_DCS_CMD(0xB2, 0x02), + INIT_DCS_CMD(0xB3, 0x0F), + INIT_DCS_CMD(0xB4, 0x25), + INIT_DCS_CMD(0xB5, 0x39), + INIT_DCS_CMD(0xB6, 0x4E), + INIT_DCS_CMD(0xB7, 0x72), + INIT_DCS_CMD(0xB8, 0x97), + INIT_DCS_CMD(0xB9, 0xDC), + INIT_DCS_CMD(0xBA, 0x22), + INIT_DCS_CMD(0xBB, 0xA4), + INIT_DCS_CMD(0xBC, 0x2B), + INIT_DCS_CMD(0xBD, 0x2F), + INIT_DCS_CMD(0xBE, 0xA9), + INIT_DCS_CMD(0xBF, 0x25), + INIT_DCS_CMD(0xC0, 0x61), + INIT_DCS_CMD(0xC1, 0x97), + INIT_DCS_CMD(0xC2, 0xB2), + INIT_DCS_CMD(0xC3, 0xCD), + INIT_DCS_CMD(0xC4, 0xD9), + INIT_DCS_CMD(0xC5, 0xE7), + INIT_DCS_CMD(0xC6, 0xF4), + INIT_DCS_CMD(0xC7, 0xFA), + INIT_DCS_CMD(0xC8, 0xFC), + INIT_DCS_CMD(0xC9, 0x00), + INIT_DCS_CMD(0xCA, 0x00), + INIT_DCS_CMD(0xCB, 0x16), + INIT_DCS_CMD(0xCC, 0xAF), + INIT_DCS_CMD(0xCD, 0xFF), + INIT_DCS_CMD(0xCE, 0xFF), + INIT_DCS_CMD(0xB0, 0x0B), + INIT_DCS_CMD(0xB1, 0x04), + INIT_DCS_CMD(0xB2, 0x05), + INIT_DCS_CMD(0xB3, 0x11), + INIT_DCS_CMD(0xB4, 0x24), + INIT_DCS_CMD(0xB5, 0x39), + INIT_DCS_CMD(0xB6, 0x4F), + INIT_DCS_CMD(0xB7, 0x72), + INIT_DCS_CMD(0xB8, 0x98), + INIT_DCS_CMD(0xB9, 0xDC), + INIT_DCS_CMD(0xBA, 0x23), + INIT_DCS_CMD(0xBB, 0xA6), + INIT_DCS_CMD(0xBC, 0x2C), + INIT_DCS_CMD(0xBD, 0x30), + INIT_DCS_CMD(0xBE, 0xAA), + INIT_DCS_CMD(0xBF, 0x26), + INIT_DCS_CMD(0xC0, 0x62), + INIT_DCS_CMD(0xC1, 0x9B), + INIT_DCS_CMD(0xC2, 0xB5), + INIT_DCS_CMD(0xC3, 0xCF), + INIT_DCS_CMD(0xC4, 0xDB), + INIT_DCS_CMD(0xC5, 0xE8), + INIT_DCS_CMD(0xC6, 0xF5), + INIT_DCS_CMD(0xC7, 0xFA), + INIT_DCS_CMD(0xC8, 0xFC), + INIT_DCS_CMD(0xC9, 0x00), + INIT_DCS_CMD(0xCA, 0x00), + INIT_DCS_CMD(0xCB, 0x16), + INIT_DCS_CMD(0xCC, 0xAF), + INIT_DCS_CMD(0xCD, 0xFF), + INIT_DCS_CMD(0xCE, 0xFF), + INIT_DCS_CMD(0xB0, 0x0C), + INIT_DCS_CMD(0xB1, 0x04), + INIT_DCS_CMD(0xB2, 0x02), + INIT_DCS_CMD(0xB3, 0x16), + INIT_DCS_CMD(0xB4, 0x24), + INIT_DCS_CMD(0xB5, 0x3B), + INIT_DCS_CMD(0xB6, 0x4F), + INIT_DCS_CMD(0xB7, 0x73), + INIT_DCS_CMD(0xB8, 0x99), + INIT_DCS_CMD(0xB9, 0xE0), + INIT_DCS_CMD(0xBA, 0x26), + INIT_DCS_CMD(0xBB, 0xAD), + INIT_DCS_CMD(0xBC, 0x36), + INIT_DCS_CMD(0xBD, 0x3A), + INIT_DCS_CMD(0xBE, 0xAE), + INIT_DCS_CMD(0xBF, 0x2A), + INIT_DCS_CMD(0xC0, 0x66), + INIT_DCS_CMD(0xC1, 0x9E), + INIT_DCS_CMD(0xC2, 0xB8), + INIT_DCS_CMD(0xC3, 0xD1), + INIT_DCS_CMD(0xC4, 0xDD), + INIT_DCS_CMD(0xC5, 0xE9), + INIT_DCS_CMD(0xC6, 0xF6), + INIT_DCS_CMD(0xC7, 0xFA), + INIT_DCS_CMD(0xC8, 0xFC), + INIT_DCS_CMD(0xC9, 0x00), + INIT_DCS_CMD(0xCA, 0x00), + INIT_DCS_CMD(0xCB, 0x16), + INIT_DCS_CMD(0xCC, 0xAF), + INIT_DCS_CMD(0xCD, 0xFF), + INIT_DCS_CMD(0xCE, 0xFF), + INIT_DCS_CMD(0xB0, 0x00), + INIT_DCS_CMD(0xB3, 0x08), + INIT_DCS_CMD(0xB0, 0x04), + INIT_DCS_CMD(0xB8, 0x68), + INIT_DELAY_CMD(150), + INIT_END_CMD, + }, +}; + +static struct panel_description *kodama_panels[] = { + [2] = &BOE_TV101WUM_N53, +}; + +struct panel_description *get_panel_description(int panel_id) +{ + if (panel_id < 0 || panel_id >= ARRAY_SIZE(kodama_panels)) + return NULL; + return kodama_panels[panel_id]; +}
-
build bot (Jenkins) (Code Review) -
Hung-Te Lin (Code Review)
-
Julius Werner (Code Review)
-
Paul Menzel (Code Review)
-
Peichao Li (Code Review)
-
You-Cheng Syu (Code Review)
-
Yu-Ping Wu (Code Review)