Attention is currently required from: Kangheui Won, Paul Menzel, Tim Wawrzynczak, Usha P.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62731 )
Change subject: mb/google/nissa/var/nivviks: Add TcssAuxori for nivviks
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/nivviks/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62731/comment/ee317ac5_cdad0d73
PS2, Line 12: register "TcssAuxOri" = "5"
+1. Even better if you can also add some information as comments.
There's an explanation of the bitfield here: https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src...
So I assume the 5 is because we don't have external retimers for ports C0 and C1? But yes, I agree a comment in the code would be nice.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62731
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I219de6092ac9a9c773adbaa99f5a7d6196a2c937
Gerrit-Change-Number: 62731
Gerrit-PatchSet: 2
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-CC: harsha.b.r@intel.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Usha P
usha.p@intel.com
Gerrit-Comment-Date: Wed, 16 Mar 2022 23:40:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kangheui Won
khwon@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment