Attention is currently required from: Ashish Kumar Mishra, Saurabh Mishra.
Subrata Banik has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/84142?usp=email )
Change subject: src/include/: Introducing a new BIT_32(x) macro.
......................................................................
Patch Set 4: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84142/comment/2cfd7383_96cc1471?usp... :
PS1, Line 9: If MS4V is defined using the BIT macro such in as in BIT(18) for
: instance, it is replaced with (1ul << 18)
Implemented BIT_32(x).
Acknowledged
Commit Message:
https://review.coreboot.org/c/coreboot/+/84142/comment/92927ede_1e9964e0?usp... :
PS3, Line 7: soc/intel/common/block/pmc: Fix compilation error with MS4V=BIT(18)
Sure, updated,
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84142?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I70be1ccba59d25af2ba85a2014232072abf2f87d
Gerrit-Change-Number: 84142
Gerrit-PatchSet: 4
Gerrit-Owner: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-CC: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.com
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-CC: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-CC: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-CC: Sanju Jose Thottan
sanjujose.thottan@intel.com
Gerrit-CC: Saurabh Mishra
mishra.saurabh@intel.corp-partner.google.com
Gerrit-CC: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Attention: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Comment-Date: Sun, 01 Sep 2024 08:11:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Saurabh Mishra
mishra.saurabh@intel.com
Comment-In-Reply-To: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com