Attention is currently required from: Jamie Chen, Henry Sun, Paul Menzel, Tim Wawrzynczak, Ren Kuo, Simon Yang, Angel Pons, Kane Chen, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60009 )
Change subject: soc/intel/jasperlake: Add CdClock frequency config
......................................................................
Patch Set 28: Code-Review+2
(2 comments)
File src/soc/intel/jasperlake/chip.h:
https://review.coreboot.org/c/coreboot/+/60009/comment/758b2f62_a2d95a68
PS28, Line 411: FSP will use the value to program clock frequency for core display if GOP
: * is not run. Ex: the Chromebook normal mode.
: * For the cases GOP is run, GOP will be in charge of the related register
: * settings.
This is a very nice comment. IMO, exactly the kind of information that
the UPD comments in FSP headers always lack.
(I've been pocking Intel to document the UPDs for years but they don't
seem interested :-/ )
File src/soc/intel/jasperlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/60009/comment/be47b42a_b3f2bc82
PS21, Line 212: params->CdClock = config->cd_clock ? config->cd_clock - 1 : 0xff;
sorry for missed the comment and thank you for your kindly remind. […]
Looks done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60009
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I917c2f10b130b0cd54f60e2ba98eb971d5ec3c97
Gerrit-Change-Number: 60009
Gerrit-PatchSet: 28
Gerrit-Owner: Simon Yang
simon1.yang@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Jamie Chen
jamie.chen@intel.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Simon Yang
simon1.yang@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 30 Dec 2021 12:15:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Simon Yang
simon1.yang@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment