Xi Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46616 )
Change subject: soc/mediatek/mt8192: update descriptions for dram config ......................................................................
soc/mediatek/mt8192: update descriptions for dram config
MEMORY_TEST MT8192_DRAM_DVFS
Signed-off-by: Xi Chen xixi.chen@mediatek.com Change-Id: I2e714c0ce588e48bbe6bd8e59c03bdb69dea01e6 --- M src/soc/mediatek/mt8192/Kconfig 1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/46616/1
diff --git a/src/soc/mediatek/mt8192/Kconfig b/src/soc/mediatek/mt8192/Kconfig index 1d1cf7b..0f42365 100644 --- a/src/soc/mediatek/mt8192/Kconfig +++ b/src/soc/mediatek/mt8192/Kconfig @@ -32,10 +32,15 @@ bool default n help - This options enables DRAM calibration with multiple frequencies (low, - medium and high) for DVFS feature. + This option enables DRAM calibration with multiple frequencies (low, + medium and high frequency group, total 7 freqencies) for DVFS feature. + All supported data rates are: 800, 1200, 1600, 1866, 2400, 3200, 4266.
config MEMORY_TEST bool default y + help + This option enables memory basic compare test to verify the dram read + or write is as expected. + endif
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46616 )
Change subject: soc/mediatek/mt8192: update descriptions for dram config ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46616/1/src/soc/mediatek/mt8192/Kco... File src/soc/mediatek/mt8192/Kconfig:
https://review.coreboot.org/c/coreboot/+/46616/1/src/soc/mediatek/mt8192/Kco... PS1, Line 36: medium and high frequency group, total 7 freqencies) for DVFS feature. 'freqencies' may be misspelled - perhaps 'frequencies'?
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46616
to look at the new patch set (#2).
Change subject: soc/mediatek/mt8192: update descriptions for dram config ......................................................................
soc/mediatek/mt8192: update descriptions for dram config
MEMORY_TEST MT8192_DRAM_DVFS
Signed-off-by: Xi Chen xixi.chen@mediatek.com Change-Id: I2e714c0ce588e48bbe6bd8e59c03bdb69dea01e6 --- M src/soc/mediatek/mt8192/Kconfig 1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/46616/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46616 )
Change subject: soc/mediatek/mt8192: update descriptions for dram config ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/46616/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46616/2//COMMIT_MSG@9 PS2, Line 9: MEMORY_TEST : MT8192_DRAM_DVFS Could be formatted as a list.
https://review.coreboot.org/c/coreboot/+/46616/2/src/soc/mediatek/mt8192/Kco... File src/soc/mediatek/mt8192/Kconfig:
https://review.coreboot.org/c/coreboot/+/46616/2/src/soc/mediatek/mt8192/Kco... PS2, Line 43: dram DRAM
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46616 )
Change subject: soc/mediatek/mt8192: update descriptions for dram config ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46616/2/src/soc/mediatek/mt8192/Kco... File src/soc/mediatek/mt8192/Kconfig:
https://review.coreboot.org/c/coreboot/+/46616/2/src/soc/mediatek/mt8192/Kco... PS2, Line 36: total with total
https://review.coreboot.org/c/coreboot/+/46616/2/src/soc/mediatek/mt8192/Kco... PS2, Line 36: group groups
Hello build bot (Jenkins), Yidi Lin, Paul Menzel, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46616
to look at the new patch set (#3).
Change subject: soc/mediatek/mt8192: update descriptions for dram config ......................................................................
soc/mediatek/mt8192: update descriptions for dram config
MEMORY_TEST, MT8192_DRAM_DVFS
Signed-off-by: Xi Chen xixi.chen@mediatek.com Change-Id: I2e714c0ce588e48bbe6bd8e59c03bdb69dea01e6 --- M src/soc/mediatek/mt8192/Kconfig 1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/46616/3
Xixi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46616 )
Change subject: soc/mediatek/mt8192: update descriptions for dram config ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46616/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46616/2//COMMIT_MSG@9 PS2, Line 9: MEMORY_TEST : MT8192_DRAM_DVFS
Could be formatted as a list.
Ack
https://review.coreboot.org/c/coreboot/+/46616/2/src/soc/mediatek/mt8192/Kco... File src/soc/mediatek/mt8192/Kconfig:
https://review.coreboot.org/c/coreboot/+/46616/2/src/soc/mediatek/mt8192/Kco... PS2, Line 36: total
with total
Ack
https://review.coreboot.org/c/coreboot/+/46616/2/src/soc/mediatek/mt8192/Kco... PS2, Line 36: group
groups
Ack
https://review.coreboot.org/c/coreboot/+/46616/2/src/soc/mediatek/mt8192/Kco... PS2, Line 43: dram
DRAM
Ack
Hello build bot (Jenkins), Yidi Lin, Paul Menzel, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46616
to look at the new patch set (#4).
Change subject: soc/mediatek/mt8192: update descriptions for dram config ......................................................................
soc/mediatek/mt8192: update descriptions for dram config
MEMORY_TEST, MT8192_DRAM_DVFS
Signed-off-by: Xi Chen xixi.chen@mediatek.com Change-Id: I2e714c0ce588e48bbe6bd8e59c03bdb69dea01e6 --- M src/soc/mediatek/mt8192/Kconfig 1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/46616/4
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46616 )
Change subject: soc/mediatek/mt8192: update descriptions for dram config ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46616/4/src/soc/mediatek/mt8192/Kco... File src/soc/mediatek/mt8192/Kconfig:
https://review.coreboot.org/c/coreboot/+/46616/4/src/soc/mediatek/mt8192/Kco... PS4, Line 36: feature Move to the next line? I know the limit is 96 now, but it's nice to use 80 for text like this whenever possible (and also for consistency with other configs in this file).
Xixi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46616 )
Change subject: soc/mediatek/mt8192: update descriptions for dram config ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46616/4/src/soc/mediatek/mt8192/Kco... File src/soc/mediatek/mt8192/Kconfig:
https://review.coreboot.org/c/coreboot/+/46616/4/src/soc/mediatek/mt8192/Kco... PS4, Line 36: feature
Move to the next line? I know the limit is 96 now, but it's nice to use 80 for text like this whenev […]
Ack
Hello build bot (Jenkins), Yidi Lin, Paul Menzel, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46616
to look at the new patch set (#5).
Change subject: soc/mediatek/mt8192: update descriptions for dram config ......................................................................
soc/mediatek/mt8192: update descriptions for dram config
MEMORY_TEST, MT8192_DRAM_DVFS
Signed-off-by: Xi Chen xixi.chen@mediatek.com Change-Id: I2e714c0ce588e48bbe6bd8e59c03bdb69dea01e6 --- M src/soc/mediatek/mt8192/Kconfig 1 file changed, 8 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/46616/5
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46616 )
Change subject: soc/mediatek/mt8192: update descriptions for dram config ......................................................................
Patch Set 5: Code-Review+1
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46616 )
Change subject: soc/mediatek/mt8192: update descriptions for dram config ......................................................................
Patch Set 6: Code-Review+2
Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46616 )
Change subject: soc/mediatek/mt8192: update descriptions for dram config ......................................................................
soc/mediatek/mt8192: update descriptions for dram config
MEMORY_TEST, MT8192_DRAM_DVFS
Signed-off-by: Xi Chen xixi.chen@mediatek.com Change-Id: I2e714c0ce588e48bbe6bd8e59c03bdb69dea01e6 Reviewed-on: https://review.coreboot.org/c/coreboot/+/46616 Reviewed-by: Hung-Te Lin hungte@chromium.org Reviewed-by: Yu-Ping Wu yupingso@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/mediatek/mt8192/Kconfig 1 file changed, 8 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Hung-Te Lin: Looks good to me, approved Yu-Ping Wu: Looks good to me, but someone else must approve
diff --git a/src/soc/mediatek/mt8192/Kconfig b/src/soc/mediatek/mt8192/Kconfig index 18d9d41..8425005 100644 --- a/src/soc/mediatek/mt8192/Kconfig +++ b/src/soc/mediatek/mt8192/Kconfig @@ -33,10 +33,16 @@ bool default n help - This options enables DRAM calibration with multiple frequencies (low, - medium and high) for DVFS feature. + This option enables DRAM calibration with multiple frequencies (low, + medium and high frequency groups, with total 7 frequencies) for DVFS + feature. All supported data rates are: 800, 1200, 1600, 1866, 2400, + 3200, 4266.
config MEMORY_TEST bool default y + help + This option enables memory basic compare test to verify the DRAM read + or write is as expected. + endif
-
build bot (Jenkins) (Code Review) -
Hung-Te Lin (Code Review)
-
Paul Menzel (Code Review)
-
Xi Chen (Code Review)
-
Xixi Chen (Code Review)
-
Yu-Ping Wu (Code Review)