Attention is currently required from: Raul Rangel, Furquan Shaikh, Paul Menzel, Julius Werner, Arthur Heymans, Karthik Ramasubramanian, Felix Held.
Eric Peers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57627 )
Change subject: arch/x86,cpu/x86: Introduce new method for accessing cpu_info
......................................................................
Patch Set 5:
(1 comment)
File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/57627/comment/11bf2136_a3d65c68
PS5, Line 227: /* Adjust the stack top to take into account cpu_info. */
might want to add a bit more comment to say we normally would throw this away in sipi init, but we need to reserve the pointer for *thread later, so we need to move the stack pointer top down further so we don't stomp on it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57627
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I79dce9597cb784acb39a96897fb3c2f2973bfd98
Gerrit-Change-Number: 57627
Gerrit-PatchSet: 5
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 24 Sep 2021 17:18:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment