Attention is currently required from: David Wu, Zhuohao Lee, Alan Huang. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59086 )
Change subject: mb/google/brya/var/brask: Make LAN driver to support RT8125 ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59086/comment/c26e1eae_d34f7ef4 PS2, Line 7: mb/google/brya/var/brask: Make LAN driver to support RT8125 suggestion: `drivers/net/r8168: Add support for Realtek RT8125`
https://review.coreboot.org/c/coreboot/+/59086/comment/c1f13c44_f9dfbbb2 PS2, Line 8: : Add new device id 0x8125 to the driver. suggestion: ``` The Realtek RT8168 and RT8125 have a similar programming interface, therefore add the PCI device ID for the RT8125 into driver for support ```
File src/drivers/net/r8168.c:
https://review.coreboot.org/c/coreboot/+/59086/comment/42692a0c_7c6e9c12 PS2, Line 364: 0x8168, : 0x8125, Now that there is more than one, should we add these to https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src... instead?
https://review.coreboot.org/c/coreboot/+/59086/comment/3fa02254_40456b85 PS2, Line 371: 0x10ec While you're here, do you mind changing this to `PCI_VENDOR_ID_REALTEK` ?
-
Tim Wawrzynczak (Code Review)