Change in coreboot[master]: [TEST ONLY] Jenkins buildtest CONFIG_USE_CANNONLAKE_FSP_CAR

[PraveenX Hodagatta Pranesh (Code Review)]

PraveenX Hodagatta Pranesh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37275 )

Change subject: [TEST ONLY] Jenkins buildtest CONFIG_USE_CANNONLAKE_FSP_CAR
......................................................................

[TEST ONLY] Jenkins buildtest CONFIG_USE_CANNONLAKE_FSP_CAR

Change-Id: I004fc02bd84b7b8d5c5fb96451e59f143f0fe6d3
Signed-off-by: Praveen Hodagatta Pranesh 
---
A configs/config.test
1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/37275/1

diff --git a/configs/config.test b/configs/config.test
new file mode 100644
index 0000000..23ddc26
--- /dev/null
+++ b/configs/config.test
@@ -0,0 +1 @@
+CONFIG_USE_CANNONLAKE_FSP_CAR=y

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37275 )

Change subject: [TEST ONLY] Jenkins buildtest CONFIG_USE_CANNONLAKE_FSP_CAR
......................................................................

Patch Set 1: Code-Review+1

Hi Praveen,

Thanks for creating this change! Here's some tips to make it even better:

The `configs/` folder contains specific configurations that Jenkins should build-test. Since FSP CAR isn't build-tested with the current configs, adding a new config was needed. To build-test this config for every CL, and not only CB:37265, this CL should get merged in. So, the `[TEST ONLY]` prefix should be dropped.

Also, since you boot-tested Coffeelake RVP with CB:37265, it would be nice to use that config to build-test. To get a config file with only values that differ from defaults, run `make savedefconfig`; this will generate a file named `defconfig` that you can use instead.

[Lean Sheng Tan (Code Review)]

Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37275 )

Change subject: [TEST ONLY] Jenkins buildtest CONFIG_USE_CANNONLAKE_FSP_CAR
......................................................................

Patch Set 1: Code-Review+1

Change in coreboot[master]: configs: Jenkins buildtest for FSP_CAR

[PraveenX Hodagatta Pranesh (Code Review)]

Hello Angel Pons, Lean Sheng Tan, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37275

to look at the new patch set (#2).

Change subject: configs: Jenkins buildtest for FSP_CAR
......................................................................

configs: Jenkins buildtest for FSP_CAR

Change-Id: I004fc02bd84b7b8d5c5fb96451e59f143f0fe6d3
Signed-off-by: Praveen Hodagatta Pranesh 
---
A configs/config.intel.cfl_rvp11_fsp_car
1 file changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/37275/2

Change in coreboot[master]: configs: Jenkins buildtest for FSP_CAR

[PraveenX Hodagatta Pranesh (Code Review)]

PraveenX Hodagatta Pranesh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37275 )

Change subject: configs: Jenkins buildtest for FSP_CAR
......................................................................

Patch Set 2:
> Patch Set 1: Code-Review+1
>
> Hi Praveen,
>
> Thanks for creating this change! Here's some tips to make it even better:
>
> The `configs/` folder contains specific configurations that Jenkins should build-test. Since FSP CAR isn't build-tested with the current configs, adding a new config was needed. To build-test this config for every CL, and not only CB:37265, this CL should get merged in. So, the `[TEST ONLY]` prefix should be dropped.
>
> Also, since you boot-tested Coffeelake RVP with CB:37265, it would be nice to use that config to build-test. To get a config file with only values that differ from defaults, run `make savedefconfig`; this will generate a file named `defconfig` that you can use instead.

done

Change in coreboot[master]: configs: Jenkins buildtest for FSP_CAR

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37275 )

Change subject: configs: Jenkins buildtest for FSP_CAR
......................................................................

Patch Set 2: Code-Review+2

Thank you!

Change in coreboot[master]: configs: Jenkins buildtest for FSP_CAR

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37275 )

Change subject: configs: Jenkins buildtest for FSP_CAR
......................................................................

configs: Jenkins buildtest for FSP_CAR

Change-Id: I004fc02bd84b7b8d5c5fb96451e59f143f0fe6d3
Signed-off-by: Praveen Hodagatta Pranesh 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37275
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
---
A configs/config.intel.cfl_rvp11_fsp_car
1 file changed, 9 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/configs/config.intel.cfl_rvp11_fsp_car b/configs/config.intel.cfl_rvp11_fsp_car
new file mode 100644
index 0000000..33192c4
--- /dev/null
+++ b/configs/config.intel.cfl_rvp11_fsp_car
@@ -0,0 +1,9 @@
+CONFIG_USE_BLOBS=y
+CONFIG_VENDOR_INTEL=y
+CONFIG_INTEL_GMA_VBT_FILE="3rdparty/fsp/CoffeeLakeFspBinPkg/SampleCode/Vbt/Vbt.bin"
+CONFIG_BOARD_INTEL_COFFEELAKE_RVP11=y
+CONFIG_ADD_FSP_BINARIES=y
+CONFIG_USE_CANNONLAKE_FSP_CAR=y
+CONFIG_RUN_FSP_GOP=y
+CONFIG_FSP_USE_REPO=y
+CONFIG_PAYLOAD_NONE=y