Change in coreboot[master]: cpu/intel/common: Update CPPCv3 Nominal Frequency entry - coreboot-gerrit

12 Nov 2021


      Attention is currently required from: Sugnan Prabhu S, Ravindra, Sridhar Siricilla, Michael Niewöhner, Patrick Rudolph, Ravindra N.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57783 )
Change subject: cpu/intel/common: Update CPPCv3 Nominal Frequency entry
......................................................................
Patch Set 7:
(1 comment)
File src/cpu/intel/common/common_init.c:
https://review.coreboot.org/c/coreboot/+/57783/comment/2ddd228e_4c2ede7b 
PS7, Line 136: CPPC_DWORD(0);
Isn't this functionally the same thing? the field reads back as zero, and the kernel interprets this as CPC not supported.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/57783
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If39e5e4ac77a71b143cdb5f043fb398abb398ee3
Gerrit-Change-Number: 57783
Gerrit-PatchSet: 7
Gerrit-Owner: Ravindra ravindra@intel.com
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Sridhar Siricilla sridhar.siricilla@intel.com
Gerrit-Reviewer: Sugnan Prabhu S sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Ravindra N ravindra@intel.corp-partner.google.com
Gerrit-CC: Subrata Banik subrata.banik@intel.com
Gerrit-Attention: Sugnan Prabhu S sugnan.prabhu.s@intel.com
Gerrit-Attention: Ravindra ravindra@intel.com
Gerrit-Attention: Sridhar Siricilla sridhar.siricilla@intel.com
Gerrit-Attention: Michael Niewöhner foss@mniewoehner.de
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Attention: Ravindra N ravindra@intel.corp-partner.google.com
Gerrit-Comment-Date: Fri, 12 Nov 2021 18:04:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment