Attention is currently required from: Jérémy Compostella, Patrick Rudolph.
Shuo Liu has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/87256?usp=email )
Change subject: arch/x86/c_start: Drop switching the code selector
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Maybe keeping the switches helps the code robustness. Since there is still lgdt, so the following switching seems natural.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87256?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I67200fe691ddd9f2fd8de5b4464f6e48fd31e75b
Gerrit-Change-Number: 87256
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Comment-Date: Fri, 11 Apr 2025 10:01:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No