Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46721 )
Change subject: libpayload: Add <stdbool.h> ......................................................................
libpayload: Add <stdbool.h>
Change-Id: I972c78c5da4136bc61e78fcbb52d7d162cc1b698 Signed-off-by: Nico Huber nico.h@gmx.de --- A payloads/libpayload/include/stdbool.h 1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/46721/1
diff --git a/payloads/libpayload/include/stdbool.h b/payloads/libpayload/include/stdbool.h new file mode 100644 index 0000000..c8b9807 --- /dev/null +++ b/payloads/libpayload/include/stdbool.h @@ -0,0 +1,10 @@ +/* SPDX-License-Identifier: BSD-3-Clause */ + +#ifndef __STDBOOL_H +#define __STDBOOL_H + +#define bool _Bool +#define false 0 +#define true (!false) + +#endif
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46721 )
Change subject: libpayload: Add <stdbool.h> ......................................................................
Patch Set 1: Code-Review+2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46721 )
Change subject: libpayload: Add <stdbool.h> ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46721/1/payloads/libpayload/include... File payloads/libpayload/include/stdbool.h:
https://review.coreboot.org/c/coreboot/+/46721/1/payloads/libpayload/include... PS1, Line 8: tab, while the other are spaces
https://review.coreboot.org/c/coreboot/+/46721/1/payloads/libpayload/include... PS1, Line 8: (!false) nit: spec says true == 1
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46721 )
Change subject: libpayload: Add <stdbool.h> ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Angel Pons, Michael Niewöhner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46721
to look at the new patch set (#2).
Change subject: libpayload: Add <stdbool.h> ......................................................................
libpayload: Add <stdbool.h>
Change-Id: I972c78c5da4136bc61e78fcbb52d7d162cc1b698 Signed-off-by: Nico Huber nico.h@gmx.de --- A payloads/libpayload/include/stdbool.h 1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/46721/2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46721 )
Change subject: libpayload: Add <stdbool.h> ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46721/1/payloads/libpayload/include... File payloads/libpayload/include/stdbool.h:
https://review.coreboot.org/c/coreboot/+/46721/1/payloads/libpayload/include... PS1, Line 8:
tab, while the other are spaces
weird
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46721 )
Change subject: libpayload: Add <stdbool.h> ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46721 )
Change subject: libpayload: Add <stdbool.h> ......................................................................
libpayload: Add <stdbool.h>
Change-Id: I972c78c5da4136bc61e78fcbb52d7d162cc1b698 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/46721 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- A payloads/libpayload/include/stdbool.h 1 file changed, 10 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/payloads/libpayload/include/stdbool.h b/payloads/libpayload/include/stdbool.h new file mode 100644 index 0000000..33858d5 --- /dev/null +++ b/payloads/libpayload/include/stdbool.h @@ -0,0 +1,10 @@ +/* SPDX-License-Identifier: BSD-3-Clause */ + +#ifndef __STDBOOL_H +#define __STDBOOL_H + +#define bool _Bool +#define false 0 +#define true (!false) + +#endif
-
Angel Pons (Code Review) -
Michael Niewöhner (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)