Attention is currently required from: Raul Rangel, Karthik Ramasubramanian. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52801 )
Change subject: mb/google/guybrush: Fix S0i3/S3 GPIO configuration ......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/52801/comment/252a3019_d063bff4 PS1, Line 20: PAD_SCI I think we might have to use GPIO-controller wake route for the pen eject if we need to apply debounce logic at the pad. Some background from my experiments on Zork: b/159832123#comment16
Quick summary: Debounce logic at the GPIO pad is applied only for the GPIO-controller route and not for the SCI route. For pen detect (I think it really is pen eject from garage), the hardware debouncing on the board has proved to be ineffective on most platforms. And so we have had to apply GPIO controller based debouncing. Thus, to ensure that wake happens only when pen is ejected, we have had to use the GPIO controller route. That should be okay as we do not expose GPE in this case but instead the GPIO IRQ route info: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thir...
-
Furquan Shaikh (Code Review)