Attention is currently required from: David Wu, Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Ivy Jian has posted comments on this change by Ivy Jian. ( https://review.coreboot.org/c/coreboot/+/86250?usp=email )
Change subject: mb/google/nissa/var/dirks: Add initial override devicetree
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/dirks/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/86250/comment/2658f2ed_39f7996d?usp... :
PS2, Line 264:
use tab?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86250?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic0b80e3121d94ede771ecc30cf0c66a67b9a41d0
Gerrit-Change-Number: 86250
Gerrit-PatchSet: 3
Gerrit-Owner: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Mon, 10 Feb 2025 02:06:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com