Change in ...coreboot[master]: vendorcode/intel/fsp/fsp2_0/cml: Add FSP header files for Cometlake
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31529 )
Change subject: vendorcode/intel/fsp/fsp2_0/cml: Add FSP header files for Cometlake ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/31529/3/src/vendorcode/intel/fsp/fsp2_0/come... File src/vendorcode/intel/fsp/fsp2_0/cometlake/FspUpd.h:
https://review.coreboot.org/#/c/31529/3/src/vendorcode/intel/fsp/fsp2_0/come... PS3, Line 3: Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
The date is wrong. It should reflect the date when the contents […]
i don't understand the point of this argument.
CML FSP code base is newly created in FSP stream in 2019.
https://review.coreboot.org/#/c/31529/3/src/vendorcode/intel/fsp/fsp2_0/come... PS3, Line 40: #define FSPT_UPD_SIGNATURE 0x545F4450554C4643 /* 'CFLUPD_T' */
Same signatures as for Coffee Lake? I was told by somebody @intel […]
this is a bug, we have already raised hence nothing much to worry. once fix it will available for next RC release.
-
Subrata Banik (Code Review)