Change in coreboot[master]: coreboot tables: Add SPI flash memory map windows to coreboot tables - coreboot-gerrit

30 Nov 2020

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48185 )
Change subject: coreboot tables: Add SPI flash memory map windows to coreboot tables
......................................................................
coreboot tables: Add SPI flash memory map windows to coreboot tables
This change adds details about the memory map windows to translate
addresses between SPI flash space and host address space to coreboot
tables. This is useful for payloads to setup the translation using the
decode windows already known to coreboot. Until now, there was a
single decode window at the top of 4G used by all x86
platforms. However, going forward, platforms might support more decode
windows and hence in order to avoid duplication in payloads this
information is filled in coreboot tables.
`lb_spi_flash()` is updated to fill in the details about these windows
by making a call to `spi_flash_get_mmap_windows()` which is
implemented by the driver providing the boot media mapping device.
Signed-off-by: Furquan Shaikh furquan@google.com
Change-Id: I00ae33d9b53fecd0a8eadd22531fdff8bde9ee94
---
M payloads/libpayload/include/coreboot_tables.h
M payloads/libpayload/include/sysinfo.h
M payloads/libpayload/libc/coreboot.c
M src/arch/x86/mmap_boot.c
M src/commonlib/include/commonlib/coreboot_tables.h
M src/drivers/spi/spi_flash.c
M src/include/spi_flash.h
M src/soc/intel/apollolake/mmap_boot.c
M src/soc/intel/common/block/fast_spi/mmap_boot.c
9 files changed, 101 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/48185/1

diff --git a/payloads/libpayload/include/coreboot_tables.h b/payloads/libpayload/include/coreboot_tables.h
index 64db83b..e042a90 100644
--- a/payloads/libpayload/include/coreboot_tables.h
+++ b/payloads/libpayload/include/coreboot_tables.h
@@ -261,12 +261,25 @@
    uint32_t index;
 };
+/* Memory map windows to translate addresses between SPI flash space and host address space. */
+struct flash_mmap_window {
+	uint32_t flash_base;
+	uint32_t host_base;
+	uint32_t size;
+};
+
 struct cb_spi_flash {
    uint32_t tag;
    uint32_t size;
    uint32_t flash_size;
    uint32_t sector_size;
    uint32_t erase_cmd;
+	/*
+	 * Number of mmap windows used by the platform to decode addresses between SPI flash
+	 * space and host address space. This determines the number of entries in mmap_table.
+	 */
+	uint32_t mmap_count;
+	struct flash_mmap_window mmap_table[0];
 };
struct cb_boot_media_params {
diff --git a/payloads/libpayload/include/sysinfo.h b/payloads/libpayload/include/sysinfo.h
index dd739ab..5a24e14 100644
--- a/payloads/libpayload/include/sysinfo.h
+++ b/payloads/libpayload/include/sysinfo.h
@@ -40,6 +40,9 @@
 /* Up to 10 MAC addresses */
 #define SYSINFO_MAX_MACS 10
+/* Maximum of 2 MMAP windows for decoding SPI flash. */
+#define SYSINFO_MAX_MMAP_WINDOWS 2
+
 #include <coreboot_tables.h>
/*
@@ -126,6 +129,8 @@
    	uint32_t size;
    	uint32_t sector_size;
    	uint32_t erase_cmd;
+		uint32_t mmap_window_count;
+		struct flash_mmap_window mmap_table[SYSINFO_MAX_MMAP_WINDOWS];
    } spi_flash;
    uint64_t fmap_offset;
    uint64_t cbfs_offset;
diff --git a/payloads/libpayload/libc/coreboot.c b/payloads/libpayload/libc/coreboot.c
index b7d2a53..7e23afe 100644
--- a/payloads/libpayload/libc/coreboot.c
+++ b/payloads/libpayload/libc/coreboot.c
@@ -211,6 +211,13 @@
    info->spi_flash.size = flash->flash_size;
    info->spi_flash.sector_size = flash->sector_size;
    info->spi_flash.erase_cmd = flash->erase_cmd;
+
+	if (flash->mmap_count == 0)
+		return;
+
+	info->spi_flash.mmap_window_count = MIN(flash->mmap_count, SYSINFO_MAX_MMAP_WINDOWS);
+	memcpy(info->spi_flash.mmap_table, flash->mmap_table,
+	       info->spi_flash.mmap_window_count * sizeof(struct flash_mmap_window));
 }
static void cb_parse_boot_media_params(unsigned char *ptr,
diff --git a/src/arch/x86/mmap_boot.c b/src/arch/x86/mmap_boot.c
index 66ba0e1..f0ccc86 100644
--- a/src/arch/x86/mmap_boot.c
+++ b/src/arch/x86/mmap_boot.c
@@ -2,6 +2,7 @@
#include <boot_device.h>
 #include <endian.h>
+#include <spi_flash.h>
/* The ROM is memory mapped just below 4GiB. Form a pointer for the base. */
 #define rom_base ((void *)(uintptr_t)(0x100000000ULL-CONFIG_ROM_SIZE))
@@ -13,3 +14,12 @@
 {
    return &boot_dev.rdev;
 }
+
+uint32_t spi_flash_get_mmap_windows(struct flash_mmap_window *table)
+{
+	table->flash_base = 0;
+	table->host_base = (uint32_t)(uintptr_t)rom_base;
+	table->size = CONFIG_ROM_SIZE;
+
+	return 1;
+}
diff --git a/src/commonlib/include/commonlib/coreboot_tables.h b/src/commonlib/include/commonlib/coreboot_tables.h
index 3e74e6b..c740975 100644
--- a/src/commonlib/include/commonlib/coreboot_tables.h
+++ b/src/commonlib/include/commonlib/coreboot_tables.h
@@ -349,12 +349,26 @@
    uint32_t index;
 };
+/* Memory map windows to translate addresses between SPI flash space and host address space. */
+struct flash_mmap_window {
+	uint32_t flash_base;
+	uint32_t host_base;
+	uint32_t size;
+};
+
 struct lb_spi_flash {
    uint32_t tag;
    uint32_t size;
    uint32_t flash_size;
    uint32_t sector_size;
    uint32_t erase_cmd;
+	/*
+	 * Number of mmap windows used by the platform to decode addresses between SPI flash
+	 * space and host address space. This determines the number of entries in mmap_table.
+	 */
+
+	uint32_t mmap_count;
+	struct flash_mmap_window mmap_table[0];
 };
struct lb_boot_media_params {
diff --git a/src/drivers/spi/spi_flash.c b/src/drivers/spi/spi_flash.c
index f2610a1..2406a90 100644
--- a/src/drivers/spi/spi_flash.c
+++ b/src/drivers/spi/spi_flash.c
@@ -663,6 +663,14 @@
    	flash->sector_size = 64 * KiB;
    	flash->erase_cmd = CMD_BLOCK_ERASE;
    }
+
+	if (!CONFIG(BOOT_DEVICE_MEMORY_MAPPED)) {
+		flash->mmap_count = 0;
+	} else {
+		struct flash_mmap_window *table = (struct flash_mmap_window *)(flash + 1);
+		flash->mmap_count = spi_flash_get_mmap_windows(table);
+		flash->size += flash->mmap_count * sizeof(*table);
+	}
 }
int spi_flash_ctrlr_protect_region(const struct spi_flash *flash,
diff --git a/src/include/spi_flash.h b/src/include/spi_flash.h
index 1061e99..a7f707e 100644
--- a/src/include/spi_flash.h
+++ b/src/include/spi_flash.h
@@ -225,4 +225,12 @@
    int (*func)(const struct spi_slave *slave, const void *dout,
    	    size_t bytesout, void *din, size_t bytesin));
+/*
+ * Fill in the memory mapped windows used by the SPI flash device. This is useful for payloads
+ * to identify SPI flash to host space mapping.
+ *
+ * Returns number of windows added to the table.
+ */
+uint32_t spi_flash_get_mmap_windows(struct flash_mmap_window *table);
+
 #endif /* _SPI_FLASH_H_ */
diff --git a/src/soc/intel/apollolake/mmap_boot.c b/src/soc/intel/apollolake/mmap_boot.c
index 4ced6ba..b103e7c 100644
--- a/src/soc/intel/apollolake/mmap_boot.c
+++ b/src/soc/intel/apollolake/mmap_boot.c
@@ -5,6 +5,7 @@
 #include <console/console.h>
 #include <fmap.h>
 #include <intelblocks/fast_spi.h>
+#include <spi_flash.h>
/*
  * BIOS region on the flash is mapped right below 4GiB in the address
@@ -98,3 +99,14 @@
return &real_dev.rdev;
 }
+
+uint32_t spi_flash_get_mmap_windows(struct flash_mmap_window *table)
+{
+	bios_mmap_init();
+
+	table->flash_base = region_offset(&real_dev_window.sub_region);
+	table->host_base = (uintptr_t)rdev_mmap_full(&shadow_dev.rdev);
+	table->size = region_sz(&real_dev_window.sub_region);
+
+	return 1;
+}
diff --git a/src/soc/intel/common/block/fast_spi/mmap_boot.c b/src/soc/intel/common/block/fast_spi/mmap_boot.c
index a415cbd..9d0cc04 100644
--- a/src/soc/intel/common/block/fast_spi/mmap_boot.c
+++ b/src/soc/intel/common/block/fast_spi/mmap_boot.c
@@ -4,6 +4,7 @@
 #include <commonlib/region.h>
 #include <fmap.h>
 #include <intelblocks/fast_spi.h>
+#include <spi_flash.h>
enum window_type {
    /* Fixed decode window of max 16MiB size just below 4G boundary */
@@ -151,3 +152,26 @@
    	*base = (uintptr_t)rdev_mmap_full(rd);
    }
 }
+
+uint32_t spi_flash_get_mmap_windows(struct flash_mmap_window *table)
+{
+	int i;
+	uint32_t count = 0;
+
+	bios_mmap_init();
+
+	for (i = 0; i < TOTAL_DECODE_WINDOWS; i++) {
+
+		if (region_sz(&real_dev_windows[i].sub_region) == 0)
+			continue;
+
+		count++;
+		table->flash_base = region_offset(&real_dev_windows[i].sub_region);
+		table->host_base = (uintptr_t)rdev_mmap_full(&shadow_devs[i].rdev);
+		table->size = region_sz(&real_dev_windows[i].sub_region);
+
+		table++;
+	}
+
+	return count;
+}
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/48185
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00ae33d9b53fecd0a8eadd22531fdff8bde9ee94
Gerrit-Change-Number: 48185
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-MessageType: newchange



    