Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35499 )
Change subject: sc7180: Add QUPv3 FW load & config
......................................................................
Patch Set 45:
Patch Set 45:
*ping*
Ravi, this is still not any closer to resolving that outstanding comment (https://review.coreboot.org/c/coreboot/+/35499/40/src/soc/qualcomm/sc7180/in..., about moving the QUPV3_UART_SRC_HZ constant to soc/clock.h and using it in clock code). Can you *please* acknowledge that you are actually aware of this, that it is actively being worked on, and give me an ETA for when we can expect it resolved? It has been 1.5 months now.
Hi Julius,
I am aware of this, the clocks team has made the appropriate changes in clock.h file below.
https://review.coreboot.org/c/coreboot/+/40329/1
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35499
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d91dd10488931247f81a87b0bdcc598f4bceb31
Gerrit-Change-Number: 35499
Gerrit-PatchSet: 45
Gerrit-Owner: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: Doug Anderson
dianders@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Akash Asthana
akashast@qualcomm.corp-partner.google.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Roja Rani Yarubandi
c_rojay@qualcomm.corp-partner.google.com
Gerrit-CC: Satya Priya Kakitapalli
c_skakit@qualcomm.corp-partner.google.com
Gerrit-CC: Stephen Boyd
swboyd@chromium.org
Gerrit-CC: Taniya Das
tdas@codeaurora.org
Gerrit-Comment-Date: Wed, 15 Apr 2020 08:08:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment