Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43728 )
Change subject: nb/intel/ironlake/hostbridge_regs: Drop D0F0_PMBASE ......................................................................
nb/intel/ironlake/hostbridge_regs: Drop D0F0_PMBASE
This register does not seem to exist on Ironlake.
Change-Id: I3fba6a3fd443f2c9eab874e1d1b8f081f58b1536 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/ironlake/hostbridge_regs.h 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/43728/1
diff --git a/src/northbridge/intel/ironlake/hostbridge_regs.h b/src/northbridge/intel/ironlake/hostbridge_regs.h index 087e3ef..cd865aa 100644 --- a/src/northbridge/intel/ironlake/hostbridge_regs.h +++ b/src/northbridge/intel/ironlake/hostbridge_regs.h @@ -14,8 +14,6 @@ #define PCIEXBAR 0x60 #define DMIBAR 0x68
-#define D0F0_PMBASE 0x78 - #define LAC 0x87 /* Legacy Access Control */
#define D0F0_REMAPBASE 0x98
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43728 )
Change subject: nb/intel/ironlake/hostbridge_regs: Drop D0F0_PMBASE ......................................................................
Patch Set 1:
I'd merge it with 43727 ....
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43728 )
Change subject: nb/intel/ironlake/hostbridge_regs: Drop D0F0_PMBASE ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43728 )
Change subject: nb/intel/ironlake/hostbridge_regs: Drop D0F0_PMBASE ......................................................................
nb/intel/ironlake/hostbridge_regs: Drop D0F0_PMBASE
This register does not seem to exist on Ironlake.
Change-Id: I3fba6a3fd443f2c9eab874e1d1b8f081f58b1536 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43728 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/northbridge/intel/ironlake/hostbridge_regs.h 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/northbridge/intel/ironlake/hostbridge_regs.h b/src/northbridge/intel/ironlake/hostbridge_regs.h index 087e3ef..cd865aa 100644 --- a/src/northbridge/intel/ironlake/hostbridge_regs.h +++ b/src/northbridge/intel/ironlake/hostbridge_regs.h @@ -14,8 +14,6 @@ #define PCIEXBAR 0x60 #define DMIBAR 0x68
-#define D0F0_PMBASE 0x78 - #define LAC 0x87 /* Legacy Access Control */
#define D0F0_REMAPBASE 0x98
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)