Attention is currently required from: Lance Zhao, Raul Rangel, Tim Wawrzynczak, Felix Held. Hello Lance Zhao, build bot (Jenkins), Raul Rangel, Tim Wawrzynczak, Felix Held,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/62533
to review the following change.
Change subject: Revert "acpi/acpi: drop weak cpu_get_lapic_addr implementation" ......................................................................
Revert "acpi/acpi: drop weak cpu_get_lapic_addr implementation"
This reverts commit 89d6764fd58e407fe5eb59c76dc286ac04f0645b.
Reason for revert: <INSERT REASONING HERE> No good
Change-Id: Ic86a9c0c4cb0894cc75154176115dbed12296685 --- M src/acpi/acpi.c 1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/62533/1
diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index f7545b2..4e2b8df 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -224,6 +224,15 @@ return lapic_nmi->length; }
+__weak uintptr_t cpu_get_lapic_addr(void) +{ + /* + * If an architecture does not support LAPIC, this weak implementation returns LAPIC + * addr as 0. + */ + return 0; +} + void acpi_create_madt(acpi_madt_t *madt) { acpi_header_t *header = &(madt->header);