Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43865 )
Change subject: cpu/qemu-x86: Drop select SMP ......................................................................
cpu/qemu-x86: Drop select SMP
With MAX_CPUS==1, this has the effect of removing spinlock implementation. But since is_smp_boot() evaluates false and SMM uses separate smi_semaphore, there is no concurrency to protect against with a spinlock.
Change-Id: I7c2ac221af78055879e7359bd03907f2416a9919 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/cpu/qemu-x86/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/43865/1
diff --git a/src/cpu/qemu-x86/Kconfig b/src/cpu/qemu-x86/Kconfig index 21ada02..3136162 100644 --- a/src/cpu/qemu-x86/Kconfig +++ b/src/cpu/qemu-x86/Kconfig @@ -6,7 +6,6 @@ select ARCH_VERSTAGE_X86_32 select ARCH_ROMSTAGE_X86_32 select ARCH_RAMSTAGE_X86_32 - select SMP select UDELAY_TSC select TSC_MONOTONIC_TIMER select UNKNOWN_TSC_RATE
Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43865 )
Change subject: cpu/qemu-x86: Drop select SMP ......................................................................
Abandoned
Kyösti Mälkki has restored this change. ( https://review.coreboot.org/c/coreboot/+/43865 )
Change subject: cpu/qemu-x86: Drop select SMP ......................................................................
Restored
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43865
to look at the new patch set (#2).
Change subject: cpu/qemu-x86: Drop select SMP ......................................................................
cpu/qemu-x86: Drop select SMP
With MAX_CPUS==1, this has the effect of removing spinlock implementation. But since is_smp_boot() evaluates false and SMM uses separate smi_semaphore, there is no concurrency to protect against with a spinlock.
Change-Id: I7c2ac221af78055879e7359bd03907f2416a9919 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/cpu/qemu-x86/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/43865/2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43865 )
Change subject: cpu/qemu-x86: Drop select SMP ......................................................................
Patch Set 3: Code-Review+2
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43865 )
Change subject: cpu/qemu-x86: Drop select SMP ......................................................................
Patch Set 3:
Isn't that needed as MAX_CPUS is one on qemu, but you can specify the core count on the command line, so you need the SMP semaphores, even when there's only one core by default?
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43865 )
Change subject: cpu/qemu-x86: Drop select SMP ......................................................................
Patch Set 3:
Isn't that needed as MAX_CPUS is one on qemu, but you can specify the core count on the command line, so you need the SMP semaphores, even when there's only one core by default?
AIUI, MAX_CPUS==1 implies that we won't start up any APs. So they'd only be running our code if they execute the reset vector. Which they shouldn't if Intel is emulated.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43865 )
Change subject: cpu/qemu-x86: Drop select SMP ......................................................................
Patch Set 3: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43865 )
Change subject: cpu/qemu-x86: Drop select SMP ......................................................................
cpu/qemu-x86: Drop select SMP
With MAX_CPUS==1, this has the effect of removing spinlock implementation. But since is_smp_boot() evaluates false and SMM uses separate smi_semaphore, there is no concurrency to protect against with a spinlock.
Change-Id: I7c2ac221af78055879e7359bd03907f2416a9919 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43865 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/cpu/qemu-x86/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/cpu/qemu-x86/Kconfig b/src/cpu/qemu-x86/Kconfig index c8c99b7..87d02fc 100644 --- a/src/cpu/qemu-x86/Kconfig +++ b/src/cpu/qemu-x86/Kconfig @@ -2,7 +2,6 @@
config CPU_QEMU_X86 bool - select SMP select UDELAY_TSC select TSC_MONOTONIC_TIMER select UNKNOWN_TSC_RATE
-
Angel Pons (Code Review) -
Kyösti Mälkki (Code Review)
-
Nico Huber (Code Review)
-
Patrick Rudolph (Code Review)