[XL] Change in coreboot[master]: ec/clevo/it5570e: add driver for EC used on various Clevo laptops - coreboot-gerrit

1 Nov 2022


      Attention is currently required from: Felix Singer, Michał Żygowski, Michał Kopeć, Angel Pons, Arthur Heymans, Michael Niewöhner.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68791 )
Change subject: ec/clevo/it5570e: add driver for EC used on various Clevo laptops
......................................................................
Patch Set 6:
(1 comment)
File src/ec/clevo/it5570e/ssdt.c:
https://review.coreboot.org/c/coreboot/+/68791/comment/293490ed_968b47cd 
PS4, Line 119: 			goto pop;
...
the whole function is only about the custom fan curve
You can also avoid gotos by checking for errors before you begin writing anything to the tables.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/68791
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8c0bee9002ad9edcd10c83b775fc723744caaa0
Gerrit-Change-Number: 68791
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Michał Kopeć michal.kopec@3mdeb.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Attention: Michał Kopeć michal.kopec@3mdeb.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Michael Niewöhner foss@mniewoehner.de
Gerrit-Comment-Date: Tue, 01 Nov 2022 16:47:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner foss@mniewoehner.de
Gerrit-MessageType: comment