Attention is currently required from: Star Labs, Andy Pont, Tim Wawrzynczak, Paul Menzel, Patrick Rudolph.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52800 )
Change subject: soc/intel: Allow enable/disable ME via CMOS
......................................................................
Patch Set 20:
(1 comment)
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/52800/comment/dd083940_e1cc5f72
PS20, Line 871: #if CONFIG(ME_STATE_BY_CMOS)
Have you seen the output of running: grep -r "if CONFIG" src/*
With C your code will get compiled and therefore also buildtested regardless of the value of the Kconfig. Unused codepath will be optimized away so it does not affect the image. If you use CPP this is not the case, broken code can lie behind CPP and depending on the defaults for Kconfig this could not be caught by the buildsystem.
The tree is full of bad examples but that is not a reason to do things the wrong way.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52800
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I374db3b7c0ded71cdc18f27970252fec7220cc20
Gerrit-Change-Number: 52800
Gerrit-PatchSet: 20
Gerrit-Owner: Star Labs
admin@starlabs.systems
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andy Pont
andy.pont@sdcsystems.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Star Labs
admin@starlabs.systems
Gerrit-Attention: Andy Pont
andy.pont@sdcsystems.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 02 Jun 2021 07:26:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Andy Pont
andy.pont@sdcsystems.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment