Attention is currently required from: YH Lin, Zhuohao Lee, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62478 )
Change subject: mb/google/brask/variants/moli: Change DDR4 Interleave to Non-Interleave
......................................................................
Patch Set 2:
(3 comments)
File src/mainboard/google/brya/variants/moli/memory.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-142867):
https://review.coreboot.org/c/coreboot/+/62478/comment/f2589c7a_bd7210cc
PS2, Line 16: return &ddr4_mem_config;
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-142867):
https://review.coreboot.org/c/coreboot/+/62478/comment/c35fc2cf_9b49ea1e
PS2, Line 16: return &ddr4_mem_config;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-142867):
https://review.coreboot.org/c/coreboot/+/62478/comment/4d8ebc30_c5b9a14b
PS2, Line 17: }
adding a line without newline at end of file
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62478
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab153f16a3b729e7fa9daaa3dbfbccc70e6d789d
Gerrit-Change-Number: 62478
Gerrit-PatchSet: 2
Gerrit-Owner: Zoey Wu
zoey_wu@wistron.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-CC: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Peter Chi
peter_chi@wistron.corp-partner.google.com
Gerrit-CC: Raihow Shi
raihow_shi@wistron.corp-partner.google.com
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 02 Mar 2022 00:56:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment