Attention is currently required from: Matt DeVillier, Karthik Ramasubramanian. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62443 )
Change subject: mb/google/zork: fix SMMSTORE size, alignment in default FMAP ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62443/comment/1fd87318_7c92a04c PS1, Line 9: 64k Where is this documented?
https://review.coreboot.org/c/coreboot/+/62443/comment/4c71634c_e8038adb PS1, Line 12: asserts Which asserts?
File src/mainboard/google/zork/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/62443/comment/0b1c36fb_1bb79497 PS1, Line 15: RW_ELOG(PRESERVE) 4K : RW_SHARED 16K { : SHARED_DATA 8K : VBLOCK_DEV 8K : } : RW_VPD(PRESERVE) 8K : RW_NVRAM(PRESERVE) 20K This is going to invalidate all this data. Can you maybe add some padding before SMMSTORE?