Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86607?usp=email )
Change subject: drivers/generic/bayhub: Use boolean for power_saving ......................................................................
drivers/generic/bayhub: Use boolean for power_saving
Change-Id: I7cc89989296b48e20b41e6ff06570a9d30bfc114 Signed-off-by: Elyes Haouas ehaouas@noos.fr --- M src/drivers/generic/bayhub/chip.h M src/mainboard/google/kahlee/variants/baseboard/devicetree.cb M src/mainboard/google/kahlee/variants/nuwani/overridetree.cb M src/mainboard/google/kahlee/variants/treeya/overridetree.cb M src/mainboard/google/sarien/variants/arcada/devicetree.cb M src/mainboard/google/sarien/variants/sarien/devicetree.cb 6 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/86607/1
diff --git a/src/drivers/generic/bayhub/chip.h b/src/drivers/generic/bayhub/chip.h index 82fe670..e43bf5f0 100644 --- a/src/drivers/generic/bayhub/chip.h +++ b/src/drivers/generic/bayhub/chip.h @@ -9,8 +9,8 @@ * Bayhub BG720 PCI to eMMC bridge */ struct drivers_generic_bayhub_config { - /* 1 to enable power-saving mode, 0 to disable */ - int power_saving; + /* enable/disable power-saving mode */ + bool power_saving;
/* When set, disables programming HS200 mode */ bool disable_hs200_mode; diff --git a/src/mainboard/google/kahlee/variants/baseboard/devicetree.cb b/src/mainboard/google/kahlee/variants/baseboard/devicetree.cb index 4deac2b..6176b69 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/kahlee/variants/baseboard/devicetree.cb @@ -20,7 +20,7 @@ device ref gpp_bridge_1 on end # WLAN device ref gpp_bridge_3 on chip drivers/generic/bayhub - register "power_saving" = "1" + register "power_saving" = "true" device pci 00.0 on end end end diff --git a/src/mainboard/google/kahlee/variants/nuwani/overridetree.cb b/src/mainboard/google/kahlee/variants/nuwani/overridetree.cb index f53a672..c618542 100644 --- a/src/mainboard/google/kahlee/variants/nuwani/overridetree.cb +++ b/src/mainboard/google/kahlee/variants/nuwani/overridetree.cb @@ -40,7 +40,7 @@ device domain 0 on device ref gpp_bridge_3 on chip drivers/generic/bayhub - register "power_saving" = "1" + register "power_saving" = "true" register "vih_tuning_value" = "0x35" device pci 00.0 on end end diff --git a/src/mainboard/google/kahlee/variants/treeya/overridetree.cb b/src/mainboard/google/kahlee/variants/treeya/overridetree.cb index 011b3a1..fe9e6ac 100644 --- a/src/mainboard/google/kahlee/variants/treeya/overridetree.cb +++ b/src/mainboard/google/kahlee/variants/treeya/overridetree.cb @@ -40,7 +40,7 @@ device domain 0 on device ref gpp_bridge_3 on chip drivers/generic/bayhub - register "power_saving" = "1" + register "power_saving" = "true" register "vih_tuning_value" = "0x35" device pci 00.0 on end end diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb index b521763..75e4896 100644 --- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb +++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb @@ -350,7 +350,7 @@ device ref pcie_rp13 on # x4 lanes chip drivers/generic/bayhub - register "power_saving" = "1" + register "power_saving" = "true" device pci 00.0 on end end smbios_slot_desc "SlotTypeM2Socket3" "SlotLengthOther" "2280" "SlotDataBusWidth4X" diff --git a/src/mainboard/google/sarien/variants/sarien/devicetree.cb b/src/mainboard/google/sarien/variants/sarien/devicetree.cb index d47e183..8f66c40 100644 --- a/src/mainboard/google/sarien/variants/sarien/devicetree.cb +++ b/src/mainboard/google/sarien/variants/sarien/devicetree.cb @@ -370,7 +370,7 @@ end device ref pcie_rp9 on chip drivers/generic/bayhub - register "power_saving" = "1" + register "power_saving" = "true" device pci 00.0 on end end smbios_slot_desc "SlotTypeM2Socket1_SD" "SlotLengthOther" "2230" "SlotDataBusWidth1X" @@ -382,7 +382,7 @@ device ref pcie_rp13 on # x4 lanes chip drivers/generic/bayhub - register "power_saving" = "1" + register "power_saving" = "true" device pci 00.0 on end end smbios_slot_desc "SlotTypeM2Socket3" "SlotLengthOther" "2280" "SlotDataBusWidth4X"
-
Elyes Haouas (Code Review)