Change in ...coreboot[master]: src/include/device/pci_ids.h: Added another Kabylake DT src/soc/intel...

[Christian Walter (Code Review)]

Christian Walter has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32850

Change subject: src/include/device/pci_ids.h: Added another Kabylake DT src/soc/intelcommon/block/systemagent/systemagent.c: Added another KabyLake DT
......................................................................

src/include/device/pci_ids.h: Added another Kabylake DT
src/soc/intelcommon/block/systemagent/systemagent.c: Added another KabyLake DT

Change-Id: I496b3a91f765d4fa137c32c9ee1e244803fc25d8
Signed-off-by: Christian Walter 
---
M src/include/device/pci_ids.h
M src/soc/intel/common/block/systemagent/systemagent.c
2 files changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/32850/1

diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h
index 6453951..553deaf 100644
--- a/src/include/device/pci_ids.h
+++ b/src/include/device/pci_ids.h
@@ -3081,6 +3081,7 @@
 #define PCI_DEVICE_ID_INTEL_KBL_ID_Y	0x590c
 #define PCI_DEVICE_ID_INTEL_KBL_ID_H	0x5910
 #define PCI_DEVICE_ID_INTEL_KBL_U_R	0x5914
+#define PCI_DEVICE_ID_INTEL_KBL_ID_DT_2 0x5918
 #define PCI_DEVICE_ID_INTEL_KBL_ID_DT	0x591f
 #define PCI_DEVICE_ID_INTEL_CNL_ID_U	0x5A04
 #define PCI_DEVICE_ID_INTEL_CNL_ID_Y	0x5A02
diff --git a/src/soc/intel/common/block/systemagent/systemagent.c b/src/soc/intel/common/block/systemagent/systemagent.c
index 0f91156..281a7f7 100644
--- a/src/soc/intel/common/block/systemagent/systemagent.c
+++ b/src/soc/intel/common/block/systemagent/systemagent.c
@@ -351,6 +351,7 @@
    PCI_DEVICE_ID_INTEL_KBL_ID_H,
    PCI_DEVICE_ID_INTEL_KBL_U_R,
    PCI_DEVICE_ID_INTEL_KBL_ID_DT,
+	PCI_DEVICE_ID_INTEL_KBL_ID_DT_2,
    PCI_DEVICE_ID_INTEL_CFL_ID_U,
    PCI_DEVICE_ID_INTEL_CFL_ID_H,
    PCI_DEVICE_ID_INTEL_CFL_ID_S,

[Alex Thiessen (Code Review)]

Alex Thiessen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32850 )

Change subject: src/include/device/pci_ids.h: Added another Kabylake DT src/soc/intelcommon/block/systemagent/systemagent.c: Added another KabyLake DT
......................................................................

Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/32850/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/32850/1//COMMIT_MSG@7 
PS1, Line 7: Added
use imperative mood in the subject line

https://review.coreboot.org/#/c/32850/1//COMMIT_MSG@7 
PS1, Line 7: src/include/device/pci_ids.h: Added another Kabylake DT
           : src/soc/intelcommon/block/systemagent/systemagent.c: Added another KabyLake DT
a too long subject line

https://review.coreboot.org/#/c/32850/1/src/include/device/pci_ids.h 
File src/include/device/pci_ids.h:

https://review.coreboot.org/#/c/32850/1/src/include/device/pci_ids.h@3084 
PS1, Line 3084:  
guess this should have been a tab, not a space

Change in ...coreboot[master]: src/include/device/pci_ids.h: Add another Kabylake DT src/soc/intelco...

[Christian Walter (Code Review)]

Hello Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32850

to look at the new patch set (#2).

Change subject: src/include/device/pci_ids.h: Add another Kabylake DT src/soc/intelcommon/block/systemagent/systemagent.c: Add another KabyLake DT
......................................................................

src/include/device/pci_ids.h: Add another Kabylake DT
src/soc/intelcommon/block/systemagent/systemagent.c: Add another KabyLake DT

Change-Id: I496b3a91f765d4fa137c32c9ee1e244803fc25d8
Signed-off-by: Christian Walter 
---
M src/include/device/pci_ids.h
M src/soc/intel/common/block/systemagent/systemagent.c
2 files changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/32850/2

Change in ...coreboot[master]: src/include/device/pci_ids.h: Add another Kabylake DT src/soc/intelco...

[Christian Walter (Code Review)]

Hello Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32850

to look at the new patch set (#3).

Change subject: src/include/device/pci_ids.h: Add another Kabylake DT src/soc/intelcommon/block/systemagent/systemagent.c: Add another KabyLake DT
......................................................................

src/include/device/pci_ids.h: Add another Kabylake DT
src/soc/intelcommon/block/systemagent/systemagent.c:
Add another KabyLake DT

Change-Id: I496b3a91f765d4fa137c32c9ee1e244803fc25d8
Signed-off-by: Christian Walter 
---
M src/include/device/pci_ids.h
M src/soc/intel/common/block/systemagent/systemagent.c
2 files changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/32850/3

Change in ...coreboot[master]: src/include/device/pci_ids.h: Add another Kabylake DT src/soc/intelco...

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32850 )

Change subject: src/include/device/pci_ids.h: Add another Kabylake DT src/soc/intelcommon/block/systemagent/systemagent.c: Add another KabyLake DT
......................................................................

Patch Set 3:

Please follow https://doc.coreboot.org/getting_started/gerrit_guidelines.html to change the commit message, also report_platform.c under src/soc/intel/skylake/bootblock need to be updated as well.

Change in ...coreboot[master]: src/include/device/pci_ids.h: Add another Kabylake DT src/soc/intelco...

[Alex Thiessen (Code Review)]

Alex Thiessen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32850 )

Change subject: src/include/device/pci_ids.h: Add another Kabylake DT src/soc/intelcommon/block/systemagent/systemagent.c: Add another KabyLake DT
......................................................................

Patch Set 3:

(1 comment)

one comment was resolved

https://review.coreboot.org/#/c/32850/1/src/include/device/pci_ids.h 
File src/include/device/pci_ids.h:

https://review.coreboot.org/#/c/32850/1/src/include/device/pci_ids.h@3084 
PS1, Line 3084:
> guess this should have been a tab, not a space

Done

Change in ...coreboot[master]: soc/intel/skylake: Add PCI Id for Kabylake DT

[Christian Walter (Code Review)]

Hello Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32850

to look at the new patch set (#4).

Change subject: soc/intel/skylake: Add PCI Id for Kabylake DT
......................................................................

soc/intel/skylake: Add PCI Id for Kabylake DT

Change-Id: I496b3a91f765d4fa137c32c9ee1e244803fc25d8
Signed-off-by: Christian Walter 
---
M src/include/device/pci_ids.h
M src/soc/intel/common/block/systemagent/systemagent.c
M src/soc/intel/skylake/bootblock/report_platform.c
3 files changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/32850/4

Change in ...coreboot[master]: soc/intel/skylake: Add PCI Id for Kabylake DT

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32850 )

Change subject: soc/intel/skylake: Add PCI Id for Kabylake DT
......................................................................

Patch Set 4: Code-Review+2

Change in ...coreboot[master]: soc/intel/skylake: Add PCI Id for Kabylake DT

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32850 )

Change subject: soc/intel/skylake: Add PCI Id for Kabylake DT
......................................................................

Patch Set 4: Code-Review+1

Change in ...coreboot[master]: soc/intel/skylake: Add PCI Id for Kabylake DT

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32850 )

Change subject: soc/intel/skylake: Add PCI Id for Kabylake DT
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/32850/4/src/soc/intel/skylake/bootblock/repo... 
File src/soc/intel/skylake/bootblock/report_platform.c:

https://review.coreboot.org/#/c/32850/4/src/soc/intel/skylake/bootblock/repo... 
PS4, Line 62: Kabylake DT
DT2? Or at least different name?

Change in ...coreboot[master]: soc/intel/skylake: Add PCI Id for Kabylake DT

[Alex Thiessen (Code Review)]

Alex Thiessen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32850 )

Change subject: soc/intel/skylake: Add PCI Id for Kabylake DT
......................................................................

Patch Set 4: Code-Review+1

(2 comments)

https://review.coreboot.org/#/c/32850/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/32850/1//COMMIT_MSG@7 
PS1, Line 7: Added
> use imperative mood in the subject line

Done

https://review.coreboot.org/#/c/32850/1//COMMIT_MSG@7 
PS1, Line 7: src/include/device/pci_ids.h: Added another Kabylake DT
           : src/soc/intelcommon/block/systemagent/systemagent.c: Added another KabyLake DT
> a too long subject line

Done

Change in ...coreboot[master]: soc/intel/skylake: Add PCI Id for Kabylake DT

[Christian Walter (Code Review)]

Hello Alex Thiessen, Patrick Rudolph, Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32850

to look at the new patch set (#7).

Change subject: soc/intel/skylake: Add PCI Id for Kabylake DT
......................................................................

soc/intel/skylake: Add PCI Id for Kabylake DT

Change-Id: I496b3a91f765d4fa137c32c9ee1e244803fc25d8
Signed-off-by: Christian Walter 
---
M src/include/device/pci_ids.h
M src/soc/intel/common/block/systemagent/systemagent.c
M src/soc/intel/skylake/bootblock/report_platform.c
3 files changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/32850/7

Change in ...coreboot[master]: soc/intel/skylake: Add PCI Id for Kabylake DT

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32850 )

Change subject: soc/intel/skylake: Add PCI Id for Kabylake DT
......................................................................

Patch Set 7: Code-Review+2

Change in ...coreboot[master]: soc/intel/skylake: Add PCI Id for Kabylake DT

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32850 )

Change subject: soc/intel/skylake: Add PCI Id for Kabylake DT
......................................................................

soc/intel/skylake: Add PCI Id for Kabylake DT

Change-Id: I496b3a91f765d4fa137c32c9ee1e244803fc25d8
Signed-off-by: Christian Walter 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32850
Reviewed-by: Lijian Zhao 
Tested-by: build bot (Jenkins) 
---
M src/include/device/pci_ids.h
M src/soc/intel/common/block/systemagent/systemagent.c
M src/soc/intel/skylake/bootblock/report_platform.c
3 files changed, 3 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Lijian Zhao: Looks good to me, approved

diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h
index 6453951..553deaf 100644
--- a/src/include/device/pci_ids.h
+++ b/src/include/device/pci_ids.h
@@ -3081,6 +3081,7 @@
 #define PCI_DEVICE_ID_INTEL_KBL_ID_Y	0x590c
 #define PCI_DEVICE_ID_INTEL_KBL_ID_H	0x5910
 #define PCI_DEVICE_ID_INTEL_KBL_U_R	0x5914
+#define PCI_DEVICE_ID_INTEL_KBL_ID_DT_2 0x5918
 #define PCI_DEVICE_ID_INTEL_KBL_ID_DT	0x591f
 #define PCI_DEVICE_ID_INTEL_CNL_ID_U	0x5A04
 #define PCI_DEVICE_ID_INTEL_CNL_ID_Y	0x5A02
diff --git a/src/soc/intel/common/block/systemagent/systemagent.c b/src/soc/intel/common/block/systemagent/systemagent.c
index 0f91156..281a7f7 100644
--- a/src/soc/intel/common/block/systemagent/systemagent.c
+++ b/src/soc/intel/common/block/systemagent/systemagent.c
@@ -351,6 +351,7 @@
    PCI_DEVICE_ID_INTEL_KBL_ID_H,
    PCI_DEVICE_ID_INTEL_KBL_U_R,
    PCI_DEVICE_ID_INTEL_KBL_ID_DT,
+	PCI_DEVICE_ID_INTEL_KBL_ID_DT_2,
    PCI_DEVICE_ID_INTEL_CFL_ID_U,
    PCI_DEVICE_ID_INTEL_CFL_ID_H,
    PCI_DEVICE_ID_INTEL_CFL_ID_S,
diff --git a/src/soc/intel/skylake/bootblock/report_platform.c b/src/soc/intel/skylake/bootblock/report_platform.c
index de845c7..1e81809 100644
--- a/src/soc/intel/skylake/bootblock/report_platform.c
+++ b/src/soc/intel/skylake/bootblock/report_platform.c
@@ -59,6 +59,7 @@
    { PCI_DEVICE_ID_INTEL_KBL_ID_H, "Kabylake-H" },
    { PCI_DEVICE_ID_INTEL_KBL_ID_S, "Kabylake-S" },
    { PCI_DEVICE_ID_INTEL_KBL_ID_DT, "Kabylake DT" },
+	{ PCI_DEVICE_ID_INTEL_KBL_ID_DT_2, "Kabylake DT 2" },
 };

static struct {

Change in ...coreboot[master]: soc/intel/skylake: Add PCI Id for Kabylake DT

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32850 )

Change subject: soc/intel/skylake: Add PCI Id for Kabylake DT
......................................................................

Patch Set 9:

What is DT? If it's supposed to mean Desktop, wouldn't that be Kabylake-S?

Change in ...coreboot[master]: soc/intel/skylake: Add PCI Id for Kabylake DT

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32850 )

Change subject: soc/intel/skylake: Add PCI Id for Kabylake DT
......................................................................

Patch Set 10:
> Patch Set 9:
>
> What is DT? If it's supposed to mean Desktop, wouldn't that be Kabylake-S?

Kabylake DT is an "entry level server" variant.

Change in ...coreboot[master]: soc/intel/skylake: Add PCI Id for Kabylake DT

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32850 )

Change subject: soc/intel/skylake: Add PCI Id for Kabylake DT
......................................................................

Patch Set 10:

(1 comment)
> Patch Set 10:
> > Patch Set 9:
> >
> > What is DT? If it's supposed to mean Desktop, wouldn't that be Kabylake-S?
>
> Kabylake DT is an "entry level server" variant.

Thanks.

https://review.coreboot.org/#/c/32850/10/src/include/device/pci_ids.h 
File src/include/device/pci_ids.h:

https://review.coreboot.org/#/c/32850/10/src/include/device/pci_ids.h@3085 
PS10, Line 3085: #define PCI_DEVICE_ID_INTEL_KBL_ID_DT	0x591f
Now that I learned about DT, this 0x591f one is documented as S/X in
doc 567957.

Again, I guess we could have better lists if Intel would publish the
stepping and id guides.