Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/57258 )
Change subject: src/*: Specify type of `DIMM_MAX` once ......................................................................
src/*: Specify type of `DIMM_MAX` once
Specify the type of the `DIMM_MAX` Kconfig symbol once.
Change-Id: I2e86baaa8bd50c7b82c399fde5dcea05da6b4307 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/57258 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Crawford tcrawford@system76.com Reviewed-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/51nb/x210/Kconfig M src/mainboard/clevo/cml-u/Kconfig M src/mainboard/clevo/kbl-u/Kconfig M src/mainboard/facebook/monolith/Kconfig M src/mainboard/google/drallion/Kconfig M src/mainboard/google/fizz/Kconfig M src/mainboard/google/hatch/Kconfig M src/mainboard/google/sarien/Kconfig M src/mainboard/hp/280_g2/Kconfig M src/mainboard/kontron/bsl6/Kconfig M src/mainboard/libretrend/lt1000/Kconfig M src/mainboard/ocp/deltalake/Kconfig M src/mainboard/protectli/vault_bsw/Kconfig M src/mainboard/protectli/vault_kbl/Kconfig M src/mainboard/purism/librem_cnl/Kconfig M src/mainboard/purism/librem_skl/Kconfig M src/mainboard/system76/gaze15/Kconfig M src/mainboard/system76/lemp9/Kconfig M src/mainboard/system76/oryp5/Kconfig M src/mainboard/system76/oryp6/Kconfig M src/mainboard/system76/whl-u/Kconfig M src/soc/intel/xeon_sp/cpx/Kconfig 22 files changed, 0 insertions(+), 22 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Tim Crawford: Looks good to me, but someone else must approve
diff --git a/src/mainboard/51nb/x210/Kconfig b/src/mainboard/51nb/x210/Kconfig index 3a0be4e..038b2a5 100644 --- a/src/mainboard/51nb/x210/Kconfig +++ b/src/mainboard/51nb/x210/Kconfig @@ -31,7 +31,6 @@ default "8086,5917"
config DIMM_MAX - int default 2
config DIMM_SPD_SIZE diff --git a/src/mainboard/clevo/cml-u/Kconfig b/src/mainboard/clevo/cml-u/Kconfig index 0452bc1..274db95 100644 --- a/src/mainboard/clevo/cml-u/Kconfig +++ b/src/mainboard/clevo/cml-u/Kconfig @@ -54,7 +54,6 @@ default 8 if BOARD_CLEVO_L140CU_BASE
config DIMM_MAX - int default 2 if BOARD_CLEVO_L140CU_BASE
config VGA_BIOS_ID diff --git a/src/mainboard/clevo/kbl-u/Kconfig b/src/mainboard/clevo/kbl-u/Kconfig index f3844be..b5e45aa 100644 --- a/src/mainboard/clevo/kbl-u/Kconfig +++ b/src/mainboard/clevo/kbl-u/Kconfig @@ -53,7 +53,6 @@ # default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/fmds/vboot-roab.fmd" if VBOOT_SLOTS_RW_AB
config DIMM_MAX - int default 2
config DIMM_SPD_SIZE diff --git a/src/mainboard/facebook/monolith/Kconfig b/src/mainboard/facebook/monolith/Kconfig index a51e28d..212ca82 100644 --- a/src/mainboard/facebook/monolith/Kconfig +++ b/src/mainboard/facebook/monolith/Kconfig @@ -61,7 +61,6 @@ default 0
config DIMM_MAX - int default 2
config MAINBOARD_SUPPORTS_SKYLAKE_CPU diff --git a/src/mainboard/google/drallion/Kconfig b/src/mainboard/google/drallion/Kconfig index 55f203e..060a75a 100644 --- a/src/mainboard/google/drallion/Kconfig +++ b/src/mainboard/google/drallion/Kconfig @@ -41,7 +41,6 @@ select USE_SAR
config DIMM_MAX - int default 2
config DRIVER_TPM_I2C_BUS diff --git a/src/mainboard/google/fizz/Kconfig b/src/mainboard/google/fizz/Kconfig index 4b9f561..cac3e4f 100644 --- a/src/mainboard/google/fizz/Kconfig +++ b/src/mainboard/google/fizz/Kconfig @@ -57,7 +57,6 @@ default "Google_Endeavour" if BOARD_GOOGLE_ENDEAVOUR
config DIMM_MAX - int default 2
config DIMM_SPD_SIZE diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index fb48433..6fe44e0 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -66,7 +66,6 @@ default "variants/baseboard/devicetree.cb"
config DIMM_MAX - int default 2
config ROMSTAGE_SPD_CBFS diff --git a/src/mainboard/google/sarien/Kconfig b/src/mainboard/google/sarien/Kconfig index 383436a..6d34685 100644 --- a/src/mainboard/google/sarien/Kconfig +++ b/src/mainboard/google/sarien/Kconfig @@ -37,7 +37,6 @@ select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC
config DIMM_MAX - int default 2
config DRIVER_TPM_I2C_BUS diff --git a/src/mainboard/hp/280_g2/Kconfig b/src/mainboard/hp/280_g2/Kconfig index 95e721b..df3f626 100644 --- a/src/mainboard/hp/280_g2/Kconfig +++ b/src/mainboard/hp/280_g2/Kconfig @@ -23,7 +23,6 @@ default "280 G2"
config DIMM_MAX - int default 2
config DIMM_SPD_SIZE diff --git a/src/mainboard/kontron/bsl6/Kconfig b/src/mainboard/kontron/bsl6/Kconfig index 98acfc3..e4e29e0 100644 --- a/src/mainboard/kontron/bsl6/Kconfig +++ b/src/mainboard/kontron/bsl6/Kconfig @@ -50,7 +50,6 @@ default 0x600000 if BOARD_SIEMENS_BOXER26
config DIMM_MAX - int default 2
config DIMM_SPD_SIZE diff --git a/src/mainboard/libretrend/lt1000/Kconfig b/src/mainboard/libretrend/lt1000/Kconfig index 46dfddf..fd6e520 100644 --- a/src/mainboard/libretrend/lt1000/Kconfig +++ b/src/mainboard/libretrend/lt1000/Kconfig @@ -31,7 +31,6 @@ default "8086,1916"
config DIMM_MAX - int default 2
config DIMM_SPD_SIZE diff --git a/src/mainboard/ocp/deltalake/Kconfig b/src/mainboard/ocp/deltalake/Kconfig index 06d8393..737bc1d 100644 --- a/src/mainboard/ocp/deltalake/Kconfig +++ b/src/mainboard/ocp/deltalake/Kconfig @@ -48,7 +48,6 @@
# Deltalake is single socket server, the platform design has 1 DIMM per channel config DIMM_MAX - int default 6
config CONSOLE_POST diff --git a/src/mainboard/protectli/vault_bsw/Kconfig b/src/mainboard/protectli/vault_bsw/Kconfig index 016165f..1f9fa20 100644 --- a/src/mainboard/protectli/vault_bsw/Kconfig +++ b/src/mainboard/protectli/vault_bsw/Kconfig @@ -32,7 +32,6 @@ default "Protectli"
config DIMM_MAX - int default 1
config DIMM_SPD_SIZE diff --git a/src/mainboard/protectli/vault_kbl/Kconfig b/src/mainboard/protectli/vault_kbl/Kconfig index 6a09391..5f76b8d 100644 --- a/src/mainboard/protectli/vault_kbl/Kconfig +++ b/src/mainboard/protectli/vault_kbl/Kconfig @@ -26,7 +26,6 @@ default "FW6"
config DIMM_MAX - int default 2
config DIMM_SPD_SIZE diff --git a/src/mainboard/purism/librem_cnl/Kconfig b/src/mainboard/purism/librem_cnl/Kconfig index d46972d..9194622 100644 --- a/src/mainboard/purism/librem_cnl/Kconfig +++ b/src/mainboard/purism/librem_cnl/Kconfig @@ -41,7 +41,6 @@ default 0x900000 if BOARD_PURISM_LIBREM_14
config DIMM_MAX - int default 2
config DIMM_SPD_SIZE diff --git a/src/mainboard/purism/librem_skl/Kconfig b/src/mainboard/purism/librem_skl/Kconfig index 814b08e..9d2688f 100644 --- a/src/mainboard/purism/librem_skl/Kconfig +++ b/src/mainboard/purism/librem_skl/Kconfig @@ -54,7 +54,6 @@ default "src/mainboard/$(MAINBOARDDIR)/data.vbt"
config DIMM_MAX - int default 1
config DIMM_SPD_SIZE diff --git a/src/mainboard/system76/gaze15/Kconfig b/src/mainboard/system76/gaze15/Kconfig index 2d19fad..e6265e4 100644 --- a/src/mainboard/system76/gaze15/Kconfig +++ b/src/mainboard/system76/gaze15/Kconfig @@ -56,7 +56,6 @@ default 16
config DIMM_MAX - int default 2
config VGA_BIOS_ID diff --git a/src/mainboard/system76/lemp9/Kconfig b/src/mainboard/system76/lemp9/Kconfig index 2a547fd..81e9d3d 100644 --- a/src/mainboard/system76/lemp9/Kconfig +++ b/src/mainboard/system76/lemp9/Kconfig @@ -53,7 +53,6 @@ default 8
config DIMM_MAX - int default 2
config VGA_BIOS_FILE diff --git a/src/mainboard/system76/oryp5/Kconfig b/src/mainboard/system76/oryp5/Kconfig index fa4ec7f..317e29b 100644 --- a/src/mainboard/system76/oryp5/Kconfig +++ b/src/mainboard/system76/oryp5/Kconfig @@ -57,7 +57,6 @@ default 12
config DIMM_MAX - int default 2
config POST_DEVICE diff --git a/src/mainboard/system76/oryp6/Kconfig b/src/mainboard/system76/oryp6/Kconfig index 4f17e55..eeed385 100644 --- a/src/mainboard/system76/oryp6/Kconfig +++ b/src/mainboard/system76/oryp6/Kconfig @@ -54,7 +54,6 @@ default 16
config DIMM_MAX - int default 2
config VGA_BIOS_ID diff --git a/src/mainboard/system76/whl-u/Kconfig b/src/mainboard/system76/whl-u/Kconfig index 95f861a..0283168 100644 --- a/src/mainboard/system76/whl-u/Kconfig +++ b/src/mainboard/system76/whl-u/Kconfig @@ -67,7 +67,6 @@ default 8
config DIMM_MAX - int default 2
config POST_DEVICE diff --git a/src/soc/intel/xeon_sp/cpx/Kconfig b/src/soc/intel/xeon_sp/cpx/Kconfig index 3e3b8c1..51fc927 100644 --- a/src/soc/intel/xeon_sp/cpx/Kconfig +++ b/src/soc/intel/xeon_sp/cpx/Kconfig @@ -105,7 +105,6 @@ # CPX-SP has 2 IMCs, 3 channels per IMC, 2 DIMMs per channel # Default value is set to one socket, full config. config DIMM_MAX - int default 12
# DDR4
-
Felix Held (Code Review)