Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30872 )
Change subject: arch/x86: Add symbols for CAR MTRRs in linker script ......................................................................
Patch Set 10:
(4 comments)
https://review.coreboot.org/c/coreboot/+/30872/5/src/arch/x86/car.ld File src/arch/x86/car.ld:
https://review.coreboot.org/c/coreboot/+/30872/5/src/arch/x86/car.ld@90 PS5, Line 90: _xip_mtrr_mask = ~(MAX(4096, _xip_program_sz_log2) - 1);
The references are in couple cache_as_ram. […]
Ack
https://review.coreboot.org/c/coreboot/+/30872/5/src/arch/x86/car.ld@92 PS5, Line 92: /* Use CACHE_ROM_SIZE instead ? */
<commonlib/helpers.h> from <cpu/x86/mtrr. […]
Done
https://review.coreboot.org/c/coreboot/+/30872/7/src/arch/x86/car.ld File src/arch/x86/car.ld:
https://review.coreboot.org/c/coreboot/+/30872/7/src/arch/x86/car.ld@3 PS7, Line 3: #include <cpu/x86/mtrr.h>
What did we need this #include for again? LOG2CEIL is a linker thing.
CACHE_ROM_SIZE
https://review.coreboot.org/c/coreboot/+/30872/9/src/arch/x86/car.ld File src/arch/x86/car.ld:
https://review.coreboot.org/c/coreboot/+/30872/9/src/arch/x86/car.ld@83 PS9, Line 83: _car_mtrr_start = _car_region_start;
And we'd expose this value for which stages? Presumably these would only need to be exposed in C_ENV […]
We dropped C_ENVIRONMENT_BOOTBLOCK already.
-
Kyösti Mälkki (Code Review)