[XS] Change in coreboot[main]: cbfs: Restore 32-bit padding in cbfs_header

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78239?usp=email )

Change subject: cbfs: Restore 32-bit padding in cbfs_header
......................................................................

Patch Set 3:

(1 comment)

Patchset:

PS3:
> FYI: https://docs.kernel.org/process/deprecated. […]

That isn't the problem here, quite the opposite: The field is called "pad", so it serves as padding. That is: it exists for the sole purpose to ensure that the struct spans a certain size (also, pad fields can easily be repurposed in the future).

The concern in that Linux doc (not that we care _too_ much about what Linux does) is that a trailing field is used as an accessor:

```
struct foo {
  ...
  char name[1]
}
```

as a way to have a flexible length "name" field after foo that is easily accessed. That breaks down any sizeof() work that tries to determine the size of foo without the name.

Again: not the thing this pad field is about.