Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61503 )
Change subject: mb/google/brya: Remove `mb_gpio_lock_config()` override function
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
I think putting the responsibility of locking (or not locking) gpios onto the motherboard is fine (since we're not trying to protect from someone opening up the DUT and connecting up HW to hack in, it seems silly to lock gpios that could be NCs on a DUT, which is what the soc_lock_gpios() currently does).
True
Thanks for this work, you're making lots of good changes.
Thanks 😊
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61503
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifc7354f2ae3817459b5494d572c603eba48ec66a
Gerrit-Change-Number: 61503
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 03 Feb 2022 19:43:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment