Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48090 )
Change subject: soc/intel/common/block/gpio: add code for NMI enabling
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48090/10/src/soc/intel/skylake/acpi...
File src/soc/intel/skylake/acpi.c:
https://review.coreboot.org/c/coreboot/+/48090/10/src/soc/intel/skylake/acpi...
PS10, Line 526: 1)
always LINT1?
yes, see IOAPIC spec
https://review.coreboot.org/c/coreboot/+/48090/10/src/soc/intel/skylake/acpi...
PS10, Line 526: 5,
will this always be active-high, edge-triggered?
mh, LINT1 is a ISA interrupt (see IOAPIC spec) - and ISA interrupts are always edge/active-high according to the ACPI spec
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48090
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4fc1a35c99c6a28b20e08a80b97bb4b8624935c9
Gerrit-Change-Number: 48090
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 02 Dec 2020 13:01:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment