Change in coreboot[master]: soc/intel/skylake/Kconfig: Select FSPT XIP in FSP CAR is used
Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43396 )
Change subject: soc/intel/skylake/Kconfig: Select FSPT XIP in FSP CAR is used ......................................................................
soc/intel/skylake/Kconfig: Select FSPT XIP in FSP CAR is used
Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com Change-Id: Ic7c984c6e2c0f93cbb97a7aa8426c2f6ef889162 --- M src/soc/intel/skylake/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/43396/1
diff --git a/src/soc/intel/skylake/Kconfig b/src/soc/intel/skylake/Kconfig index a3e8d9f..1f36c27 100644 --- a/src/soc/intel/skylake/Kconfig +++ b/src/soc/intel/skylake/Kconfig @@ -30,6 +30,7 @@ select CPU_INTEL_FIRMWARE_INTERFACE_TABLE select CPU_INTEL_COMMON_HYPERTHREADING select FSP_M_XIP + select FSP_T_XIP if FSP_CAR select GENERIC_GPIO_LIB select HAVE_FSP_GOP select HAVE_FSP_LOGO_SUPPORT
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43396 )
Change subject: soc/intel/skylake/Kconfig: Select FSPT XIP in FSP CAR is used ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/43396/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43396/1//COMMIT_MSG@7 PS1, Line 7: in if
https://review.coreboot.org/c/coreboot/+/43396/1//COMMIT_MSG@7 PS1, Line 7: FSPT FSP-T
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43396 )
Change subject: soc/intel/skylake/Kconfig: Select FSPT XIP in FSP CAR is used ......................................................................
Patch Set 1:
Why does `config FSP_T_XIP` exist? If there is no use case to leave it disabled (I can't think of any), should the option be removed instead?
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43396 )
Change subject: soc/intel/skylake/Kconfig: Select FSPT XIP in FSP CAR is used ......................................................................
Patch Set 1:
Patch Set 1:
Why does `config FSP_T_XIP` exist? If there is no use case to leave it disabled (I can't think of any), should the option be removed instead?
True, this option should be removed as XIP is mandatory AFAIK
Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43396?usp=email )
Change subject: soc/intel/skylake/Kconfig: Select FSPT XIP in FSP CAR is used ......................................................................
Abandoned
-
Angel Pons (Code Review) -
Michał Żygowski (Code Review)
-
Nico Huber (Code Review)
-
Stefan Reinauer (Code Review)