Attention is currently required from: Arthur Heymans, Hsuan Ting Chen, Julius Werner, Kapil Porwal, Martin L Roth, Martin Roth, Subrata Banik.
Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79056?usp=email )
Change subject: tests/lib: Skip ux_locales-test for !VBOOT platforms
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79056/comment/f29edb21_5a08ceb9 :
PS2, Line 7: tests/lib: Skip ux_locales-test for !VBOOT platforms
Could we change the title and the comments? like "always use vboot for ux_locales-test"
Patchset:
PS2:
LGTM for the USE_VBOOT approach.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79056?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2828eb062e2b601e073e7dab9aef7316fc6ba2cd
Gerrit-Change-Number: 79056
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Hsuan Ting Chen
roccochen@chromium.org
Gerrit-Reviewer: Hsuan-ting Chen
roccochen@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Hsuan Ting Chen
roccochen@chromium.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Wed, 15 Nov 2023 05:15:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment