Attention is currently required from: Tarun Tuli, Dtrain Hsu, Ian Feng, Paul Menzel, Eric Lai.
Van Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73741 )
Change subject: mb/google/nissa/var/uldren: Update gpio settings
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/google/brya/variants/uldren/gpio.c:
https://review.coreboot.org/c/coreboot/+/73741/comment/773fae68_f3876d64
PS6, Line 55: static const struct pad_config early_gpio_table[] = {
I think we also need […]
done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73741
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id414c9b0d94faffd2d71c348fc7146a6101196e9
Gerrit-Change-Number: 73741
Gerrit-PatchSet: 7
Gerrit-Owner: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Tue, 28 Mar 2023 09:43:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-MessageType: comment