Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86091?usp=email )
Change subject: soc/intel/cmn/cnvi: Drop CNIP ACPI method ......................................................................
soc/intel/cmn/cnvi: Drop CNIP ACPI method
This method is used in the Intel/AMI reference code to verify that the device is present (vendor ID != 0xFFFFFFFF), but that's neither used nor needed here, as coreboot only generates SSDT code for devices which are actually present.
TEST=build/boot Linux, verify no ACPI issues after dropping
Change-Id: Ib60c48852923e965620f4eee6a886c8c0f5c1783 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/soc/intel/common/block/cnvi/cnvi.c 1 file changed, 0 insertions(+), 25 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/86091/1
diff --git a/src/soc/intel/common/block/cnvi/cnvi.c b/src/soc/intel/common/block/cnvi/cnvi.c index 5e75f6d..301fb3a 100644 --- a/src/soc/intel/common/block/cnvi/cnvi.c +++ b/src/soc/intel/common/block/cnvi/cnvi.c @@ -358,31 +358,6 @@ acpigen_pop_len(); } acpigen_pop_len(); - -/* - * Method (CNIP, 0, NotSerialized) - * { - * If (^CNVW.VDID == 0xFFFFFFFF) - * { - * Return (Zero) - * } Else { - * Return (One) - * } - * } - */ - acpigen_write_method("CNIP", 0); - { - acpigen_write_if_lequal_namestr_int("^CNVW.VDID", 0xffffffff); - { - acpigen_write_return_integer(0); - } - acpigen_write_else(); - { - acpigen_write_return_integer(1); - } - acpigen_pop_len(); - } - acpigen_pop_len(); }
static struct device_operations cnvi_wifi_ops = {