Change in ...coreboot[master]: nb/i945: Consolidate sdram_setup_processor_side()

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33781

Change subject: nb/i945: Consolidate sdram_setup_processor_side()
......................................................................

nb/i945: Consolidate sdram_setup_processor_side()

Change-Id: I9c5aae06ae8e3643253fe4a5b080448403f81ebc
Signed-off-by: Elyes HAOUAS 
---
M src/northbridge/intel/i945/raminit.c
1 file changed, 3 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/33781/1

diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c
index 281e7b2..c994786 100644
--- a/src/northbridge/intel/i945/raminit.c
+++ b/src/northbridge/intel/i945/raminit.c
@@ -2695,13 +2695,11 @@

static void sdram_setup_processor_side(void)
 {
-	if (i945_silicon_revision() == 0)
+	if (i945_silicon_revision() == 0) {
    	MCHBAR32(FSBPMC3) |= (1 << 2);
-
-	MCHBAR8(0xb00) |= 1;
-
-	if (i945_silicon_revision() == 0)
    	MCHBAR32(SLPCTL) |= (1 << 8);
+	}
+	MCHBAR8(0xb00) |= 1;
 }

/**

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33781 )

Change subject: nb/i945: Consolidate sdram_setup_processor_side()
......................................................................

Patch Set 1:

This is no pure consolidation, it's reordering. Can you confirm
by any means that the order doesn't matter?

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33781 )

Change subject: nb/i945: Consolidate sdram_setup_processor_side()
......................................................................

Patch Set 1:
> Patch Set 1:
>
> This is no pure consolidation, it's reordering. Can you confirm
> by any means that the order doesn't matter?

Well, I can't test it as the silicon_revision of the chip I have is !=0, however, vendor did that ...

Change in ...coreboot[master]: nb/i945: Reorder sdram_setup_processor_side()

[HAOUAS Elyes (Code Review)]

Hello Arthur Heymans, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33781

to look at the new patch set (#2).

Change subject: nb/i945: Reorder sdram_setup_processor_side()
......................................................................

nb/i945: Reorder sdram_setup_processor_side()

Change-Id: I9c5aae06ae8e3643253fe4a5b080448403f81ebc
Signed-off-by: Elyes HAOUAS 
---
M src/northbridge/intel/i945/raminit.c
1 file changed, 3 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/33781/2

Change in coreboot[master]: nb/i945: Reorder sdram_setup_processor_side()

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33781 )

Change subject: nb/i945: Reorder sdram_setup_processor_side()
......................................................................

Abandoned