Change in coreboot[master]: cpu/intel/smm/gen1: Use correct MSR for model_6fx and model_1067x
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/27585 )
Change subject: cpu/intel/smm/gen1: Use correct MSR for model_6fx and model_1067x ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
some style nits, otherwise LGTM
https://review.coreboot.org/#/c/27585/1/src/cpu/intel/smm/gen1/smmrelocate.c File src/cpu/intel/smm/gen1/smmrelocate.c:
https://review.coreboot.org/#/c/27585/1/src/cpu/intel/smm/gen1/smmrelocate.c... PS1, Line 66: have a different msr that could be understood as "these two differ in MSR" or "these two differ in MSR from everything else", please clarify.
https://review.coreboot.org/#/c/27585/1/src/cpu/intel/smm/gen1/smmrelocate.c... PS1, Line 72: (1 << 3) are there names for the bits?
-
Patrick Georgi (Code Review)