Attention is currently required from: Nick Vaccaro, Paul Menzel, Robert Chen, Shawn Ku, Subrata Banik.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79173?usp=email )
Change subject: mb/google/nissa/var/quandiso: Disable un-used C1 port by daughterboard
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/brya/variants/quandiso/fw_config.c:
https://review.coreboot.org/c/coreboot/+/79173/comment/a1df9dc6_9c553b58 :
PS4, Line 76: static const struct pad_config disable_usbc1_pins[] = {
I only found aux pin here register "typec_aux_bias_pads[0]" = "{.pad_auxp_dc = GPP_E22, .pad_auxn_dc = GPP_E23}" why A21 a22?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79173?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6f702f60c772176e80b3452bf957d10625564102
Gerrit-Change-Number: 79173
Gerrit-PatchSet: 4
Gerrit-Owner: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Shawn Ku
shawnku@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Shawn Ku
shawnku@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 22 Nov 2023 02:47:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment