Change in coreboot[master]: google/eve: tweak VBT settings

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Matt DeVillier (Code Review)

14 Jan 2020 14 Jan '20

2:21 a.m.

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38396 )

Change subject: google/eve: tweak VBT settings ......................................................................

google/eve: tweak VBT settings

- Disable Windows driver DPST function - Set POST resolution to 1800x1200 - Set POST brightness to 225 (0-255 scale)

Test: Boot Windows on EVE, verify display backlight control functional and no lock ups from switching in/out of tablet mode.

Change-Id: Ida64a44df2449f1ff0dc5c8d0ec7b40a183566a7 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/eve/data.vbt 1 file changed, 0 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/38396/1

diff --git a/src/mainboard/google/eve/data.vbt b/src/mainboard/google/eve/data.vbt index 0f17726..c615d5e 100644 --- a/src/mainboard/google/eve/data.vbt +++ b/src/mainboard/google/eve/data.vbt Binary files differ

Attachments:

attachment.htm (text/html — 2.2 KB)

Show replies by date

Angel Pons (Code Review)

18 Jan 18 Jan

4:33 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38396 )

Change subject: google/eve: tweak VBT settings ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38396 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida64a44df2449f1ff0dc5c8d0ec7b40a183566a7 Gerrit-Change-Number: 38396 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 18 Jan 2020 07:33:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

8:20 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38396 )

Change subject: google/eve: tweak VBT settings ......................................................................

google/eve: tweak VBT settings

- Disable Windows driver DPST function - Set POST resolution to 1800x1200 - Set POST brightness to 225 (0-255 scale)

Test: Boot Windows on EVE, verify display backlight control functional and no lock ups from switching in/out of tablet mode.

Change-Id: Ida64a44df2449f1ff0dc5c8d0ec7b40a183566a7 Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38396 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/eve/data.vbt 1 file changed, 0 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/38396 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida64a44df2449f1ff0dc5c8d0ec7b40a183566a7 Gerrit-Change-Number: 38396 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

9elements QA (Code Review)

8:39 a.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38396 )

Change subject: google/eve: tweak VBT settings ......................................................................

Patch Set 2:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/154 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/153 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/152

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/38396 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida64a44df2449f1ff0dc5c8d0ec7b40a183566a7 Gerrit-Change-Number: 38396 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-Comment-Date: Sat, 18 Jan 2020 11:39:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Name of user not set (Code Review)

25 Jan 25 Jan

8:06 p.m.

greg@unrelenting.technology has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38396 )

Change subject: google/eve: tweak VBT settings ......................................................................

Patch Set 2:

but backlight in windows was already functional without reducing the resolution >_<

-- To view, visit https://review.coreboot.org/c/coreboot/+/38396 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida64a44df2449f1ff0dc5c8d0ec7b40a183566a7 Gerrit-Change-Number: 38396 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: greg@unrelenting.technology Gerrit-Comment-Date: Sat, 25 Jan 2020 23:06:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Matt DeVillier (Code Review)

11:04 p.m.

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38396 )

Change subject: google/eve: tweak VBT settings ......................................................................

Patch Set 2:

...

Patch Set 2:

but backlight in windows was already functional without reducing the resolution >_<

~90% of Eve users running Windows, including myself, experienced consistent display-related lockups with the original updated VBT. Disabling DPST in the VBT settings fixed that for all affected users.

Adjusting the fixed boot resolution is unrelated, and just makes the Tianocore settings menu easier to read.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38396 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida64a44df2449f1ff0dc5c8d0ec7b40a183566a7 Gerrit-Change-Number: 38396 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: greg@unrelenting.technology Gerrit-Comment-Date: Sun, 26 Jan 2020 02:04:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1912

days inactive

1924

days old

coreboot-gerrit@coreboot.org

5 comments

5 participants

tags (0)

participants (5)

9elements QA (Code Review)
Angel Pons (Code Review)
Matt DeVillier (Code Review)
Name of user not set (Code Review)
Patrick Georgi (Code Review)